Title: Created handler for PatchCollection by FarukFS · Pull Request #24028 · matplotlib/matplotlib · GitHub
Open Graph Title: Created handler for PatchCollection by FarukFS · Pull Request #24028 · matplotlib/matplotlib
X Title: Created handler for PatchCollection by FarukFS · Pull Request #24028 · matplotlib/matplotlib
Description: PR Summary As indicated in Issue #23998, PatchCollection is not supported in legends, even though LineCollection and Patch are supported. It was mentioned that this could be a nice feature to include. Hence, I created a legend handler for PatchCollection objetcts. I must mention that for the color of the legend handler, I don't know whether to use the edgecolor or facecolor, I opted for the last mentioned. This is my first contribution to an open source project, so I am a bit confused about the documentation. Should this feature have a .rst in doc/users/next_whats_new/ ? PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).
Open Graph Description: PR Summary As indicated in Issue #23998, PatchCollection is not supported in legends, even though LineCollection and Patch are supported. It was mentioned that this could be a nice feature to inclu...
X Description: PR Summary As indicated in Issue #23998, PatchCollection is not supported in legends, even though LineCollection and Patch are supported. It was mentioned that this could be a nice feature to inclu...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/24028
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:29a44aa6-d262-2e37-fa18-dc160da40f29 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D382:1A1F1B:2CF4C62:3DCBFBA:6A4F0F55 |
| html-safe-nonce | 407ad0afb51aff8665236a23df438a984a9272ad5f6fc4acd8e58bdf7c42cd7d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzgyOjFBMUYxQjoyQ0Y0QzYyOjNEQ0JGQkE6NkE0RjBGNTUiLCJ2aXNpdG9yX2lkIjoiNDU3Njk1OTUzODg4MDUxNTkyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f86d2071d41717b8a53b7ce56ff9a2feacd96bab36f82120782edff75bb1c6f2 |
| hovercard-subject-tag | pull_request:1069868077 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/24028/files |
| twitter:image | https://avatars.githubusercontent.com/u/65820309?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/65820309?s=400&v=4 |
| og:image:alt | PR Summary As indicated in Issue #23998, PatchCollection is not supported in legends, even though LineCollection and Patch are supported. It was mentioned that this could be a nice feature to inclu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width