Title: Improve rubberband rendering in wx and tk by oscargus · Pull Request #23985 · matplotlib/matplotlib · GitHub
Open Graph Title: Improve rubberband rendering in wx and tk by oscargus · Pull Request #23985 · matplotlib/matplotlib
X Title: Improve rubberband rendering in wx and tk by oscargus · Pull Request #23985 · matplotlib/matplotlib
Description: PR Summary Closes #23969 (as there is a separate OSX issue #23777) Draw a solid white rectangle and then add a dashed black rectangle so that it works on both light and dark backgrounds. For the tk backend it messes up the deprecated lastrect as bit since it only can contain one of the two rectangles. Not sure what lastrect is used for. If it is only to get the position it should be OK, but if it is to possibly modify the rectangle it may not work. No obvious way to test it in the CI. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).
Open Graph Description: PR Summary Closes #23969 (as there is a separate OSX issue #23777) Draw a solid white rectangle and then add a dashed black rectangle so that it works on both light and dark backgrounds. For the tk...
X Description: PR Summary Closes #23969 (as there is a separate OSX issue #23777) Draw a solid white rectangle and then add a dashed black rectangle so that it works on both light and dark backgrounds. For the tk...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/23985
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4b6a1363-969b-9988-6f1d-04513ab8b182 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E61E:5105D:AD184C5:F382131:6A50FD25 |
| html-safe-nonce | 186c0ac308fb731189c2bbe9aeb76df1d1c0694082ef9c368dab41f01a46aae2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjFFOjUxMDVEOkFEMTg0QzU6RjM4MjEzMTo2QTUwRkQyNSIsInZpc2l0b3JfaWQiOiI1ODkyNzUyODA0NzE2NTQzMjY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | dfd079f72e61455273913377c6c2ad2d28a414134107f85f83e27929b8813d6b |
| hovercard-subject-tag | pull_request:1064313228 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/23985/files |
| twitter:image | https://avatars.githubusercontent.com/u/8114497?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8114497?s=400&v=4 |
| og:image:alt | PR Summary Closes #23969 (as there is a separate OSX issue #23777) Draw a solid white rectangle and then add a dashed black rectangle so that it works on both light and dark backgrounds. For the tk... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8d836581d020676cc0ef4a83cd2fe17e4af02c3d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width