| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:905ae366-3828-fbcd-abe5-71f009d06d2b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E086:3FF72D:683290:940686:6A50C8B0 |
| html-safe-nonce | e49da3a28ba9bcd54ba35ab7f911768a875f9b9f5800062a80d82142f0d1c2ec |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDg2OjNGRjcyRDo2ODMyOTA6OTQwNjg2OjZBNTBDOEIwIiwidmlzaXRvcl9pZCI6Ijg4MjIxMDkzMjAyMzU3NjM4ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f134966a4c9daaf9328d8e3eeedff3f6c6bb615d3e89ea9545f1e4ef2e4d3d4c |
| hovercard-subject-tag | pull_request:1064313228 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/23985/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0fb64232119a9682a7076cbe01c74afbd5418605a84161f866d1968a79540867/matplotlib/matplotlib/pull/23985 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0fb64232119a9682a7076cbe01c74afbd5418605a84161f866d1968a79540867/matplotlib/matplotlib/pull/23985 |
| og:image:alt | PR Summary
Closes #23969 (as there is a separate OSX issue #23777)
Draw a solid white rectangle and then add a dashed black rectangle so that it works on both light and dark backgrounds. For the tk... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | oscargus |
| hostname | github.com |
| expected-hostname | github.com |
| None | 72b13e0e8d0319acdd27a145cfe73f4f06c791713d0ac4690e41fb68ad28cac0 |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 08e79d53fc070870d5b168356afebb1e286a2ffe |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/23985#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23985 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23985 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/23985 |
| Reload | https://github.com/matplotlib/matplotlib/pull/23985 |
| Reload | https://github.com/matplotlib/matplotlib/pull/23985 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23985 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23985 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
411
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| tacaswell | https://github.com/tacaswell |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| oscargus:rubberband | https://github.com/oscargus/matplotlib/tree/rubberband |
| Conversation | https://github.com/matplotlib/matplotlib/pull/23985 |
| Commits3 (3) | https://github.com/matplotlib/matplotlib/pull/23985/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/23985/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/23985/files |
| Improve rubberband rendering in wx and tk | https://github.com/matplotlib/matplotlib/pull/23985#top |
| tacaswell | https://github.com/tacaswell |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| oscargus:rubberband | https://github.com/oscargus/matplotlib/tree/rubberband |
|
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| Sep 22, 2022 | https://github.com/matplotlib/matplotlib/pull/23985#issue-1382617042 |
| #23969 | https://github.com/matplotlib/matplotlib/issues/23969 |
| #23777 | https://github.com/matplotlib/matplotlib/issues/23777 |
| Flake 8 | https://flake8.pycqa.org/en/latest/ |
| build | https://matplotlib.org/devel/documenting_mpl.html#building-the-docs |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23985 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
|
GUI: wx
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20wx%22 |
|
GUI: tk
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20tk%22 |
| Sep 22, 2022 | https://github.com/matplotlib/matplotlib/pull/23985#event-7440615278 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| v3.6.1 | https://github.com/matplotlib/matplotlib/milestone/73 |
| Sep 22, 2022 | https://github.com/matplotlib/matplotlib/pull/23985#event-7440615288 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/da1ae8a8f9a31560cb1f88a44f238a542d46d658..d85b6ee3c81c78de4e8a137bf0141d6037d3d51a |
| da1ae8a | https://github.com/matplotlib/matplotlib/commit/da1ae8a8f9a31560cb1f88a44f238a542d46d658 |
| d85b6ee | https://github.com/matplotlib/matplotlib/commit/d85b6ee3c81c78de4e8a137bf0141d6037d3d51a |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/da1ae8a8f9a31560cb1f88a44f238a542d46d658..d85b6ee3c81c78de4e8a137bf0141d6037d3d51a |
| September 23, 2022 07:04 | https://github.com/matplotlib/matplotlib/pull/23985#event-7444924113 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| v3.6.1 | https://github.com/matplotlib/matplotlib/milestone/73 |
| v3.6.2 | https://github.com/matplotlib/matplotlib/milestone/75 |
| Oct 6, 2022 | https://github.com/matplotlib/matplotlib/pull/23985#event-7538200498 |
|
| https://github.com/oscargus |
| Fix rubberband visibility for wx backend | https://github.com/matplotlib/matplotlib/pull/23985/commits/f751fb025f3b2abbce707e4574538a13d9b11819 |
| f751fb0 | https://github.com/matplotlib/matplotlib/pull/23985/commits/f751fb025f3b2abbce707e4574538a13d9b11819 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/d85b6ee3c81c78de4e8a137bf0141d6037d3d51a..0f9b73dedc32754765f23226e25c129284e6cec1 |
| d85b6ee | https://github.com/matplotlib/matplotlib/commit/d85b6ee3c81c78de4e8a137bf0141d6037d3d51a |
| 0f9b73d | https://github.com/matplotlib/matplotlib/commit/0f9b73dedc32754765f23226e25c129284e6cec1 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/d85b6ee3c81c78de4e8a137bf0141d6037d3d51a..0f9b73dedc32754765f23226e25c129284e6cec1 |
| October 15, 2022 10:44 | https://github.com/matplotlib/matplotlib/pull/23985#event-7594797173 |
|
| https://github.com/oscargus |
| Fix rubberband visibility for tk backend | https://github.com/matplotlib/matplotlib/pull/23985/commits/1e278c7e3296bce4fffb85ecf156a388d9a3268e |
| 1e278c7 | https://github.com/matplotlib/matplotlib/pull/23985/commits/1e278c7e3296bce4fffb85ecf156a388d9a3268e |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
|
Oct 15, 2022
| https://github.com/matplotlib/matplotlib/pull/23985#pullrequestreview-1143172593 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/23985/files/0f9b73dedc32754765f23226e25c129284e6cec1 |
| lib/matplotlib/backends/backend_wx.py | https://github.com/matplotlib/matplotlib/pull/23985/files/0f9b73dedc32754765f23226e25c129284e6cec1#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523 |
| oscargus | https://github.com/oscargus |
| Oct 15, 2022 | https://github.com/matplotlib/matplotlib/pull/23985#discussion_r996288654 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23985 |
|
| https://github.com/oscargus |
| Improve bounds of wx rubberband | https://github.com/matplotlib/matplotlib/pull/23985/commits/0f9b73dedc32754765f23226e25c129284e6cec1 |
| 0f9b73d | https://github.com/matplotlib/matplotlib/pull/23985/commits/0f9b73dedc32754765f23226e25c129284e6cec1 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Oct 15, 2022
| https://github.com/matplotlib/matplotlib/pull/23985#pullrequestreview-1143191626 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/23985/files/0f9b73dedc32754765f23226e25c129284e6cec1 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| d099170 | https://github.com/matplotlib/matplotlib/commit/d099170f5f877816efbfe4a9cffd6d26be643c19 |
| Oct 20, 2022 | https://github.com/matplotlib/matplotlib/pull/23985#event-7635316599 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Oct 20, 2022 | https://github.com/matplotlib/matplotlib/pull/23985#issuecomment-1286201233 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23985 |
| https://github.com/meeseeksmachine |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Oct 20, 2022
| https://github.com/matplotlib/matplotlib/pull/23985#ref-pullrequest-1417354818 |
|
Backport PR #23985 on branch v3.6.x (Improve rubberband rendering in wx and tk)
#24233
| https://github.com/matplotlib/matplotlib/pull/24233 |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Oct 20, 2022
| https://github.com/matplotlib/matplotlib/pull/23985#ref-commit-abe4054 |
|
| https://github.com/tacaswell |
|
| https://github.com/meeseeksmachine |
| Backport PR | https://github.com/meeseeksmachine/matplotlib/commit/abe4054a4f64a300231432e91f4057be286312b4 |
| matplotlib#23985 | https://github.com/matplotlib/matplotlib/pull/23985 |
| : Improve rubberband rendering in wx and tk | https://github.com/meeseeksmachine/matplotlib/commit/abe4054a4f64a300231432e91f4057be286312b4 |
| abe4054 | https://github.com/meeseeksmachine/matplotlib/commit/abe4054a4f64a300231432e91f4057be286312b4 |
| QuLogic | https://github.com/QuLogic |
|
Oct 21, 2022
| https://github.com/matplotlib/matplotlib/pull/23985#ref-commit-03f2f77 |
|
| https://github.com/QuLogic |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/03f2f771ebada7f24c87f88bce2423daae84f129 |
| #24233 | https://github.com/matplotlib/matplotlib/pull/24233 |
| from meeseeksmachine/auto-backport-of-pr-23… | https://github.com/matplotlib/matplotlib/commit/03f2f771ebada7f24c87f88bce2423daae84f129 |
| 03f2f77 | https://github.com/matplotlib/matplotlib/commit/03f2f771ebada7f24c87f88bce2423daae84f129 |
| #23985 | https://github.com/matplotlib/matplotlib/pull/23985 |
| https://github.com/oscargus |
| oscargus | https://github.com/oscargus |
| October 22, 2022 05:51 | https://github.com/matplotlib/matplotlib/pull/23985#event-7645036862 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
|
Feb 20, 2023
| https://github.com/matplotlib/matplotlib/pull/23985#ref-pullrequest-1592305660 |
|
merge up 3.7.0
#25270
| https://github.com/matplotlib/matplotlib/pull/25270 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23985 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/23985/files/0f9b73dedc32754765f23226e25c129284e6cec1 |
|
GUI: tk
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20tk%22 |
|
GUI: wx
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20wx%22 |
|
v3.6.2
| https://github.com/matplotlib/matplotlib/milestone/75 |
|
[ENH]: Make rubber band more visible
| https://github.com/matplotlib/matplotlib/issues/23969 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23985 |
|
| https://github.com/oscargus |
|
| https://github.com/tacaswell |
|
| https://github.com/timhoffm |
|
| https://github.com/QuLogic |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |