| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:55cf610b-782e-d39a-f53d-4833c3909b7c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E912:1AE5DF:35157:4589A:6A515A6E |
| html-safe-nonce | 03694492de0d5a952c46c9afb1e9bf6138f3dbb3903f6b0f5ea8a1968bc87d3c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTEyOjFBRTVERjozNTE1Nzo0NTg5QTo2QTUxNUE2RSIsInZpc2l0b3JfaWQiOiIxNzA1MzI1MDIxNTg3NjU5Mzc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | cbb8e4b2a1b8a73288581894a86da34db6997262c79760794ab5ad19ccc2afa1 |
| hovercard-subject-tag | pull_request:1059958664 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/23947/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/eaf17d2a77723c9812d36c16347a87b00a4b8b410265e6c19cf921e67cb3618a/matplotlib/matplotlib/pull/23947 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/eaf17d2a77723c9812d36c16347a87b00a4b8b410265e6c19cf921e67cb3618a/matplotlib/matplotlib/pull/23947 |
| og:image:alt | PR Summary
Fix building matplotlib on MINGW. Recent changes in e1fcc90 broke it.
Fixes #23943
PR Checklist
Tests and Styling
Has pytest style unit tests (and pytest passes).
Is Flake 8 compliant... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MehdiChinoune |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6f17634ed2af1d116850bcea6c63a70a4d72970f33ade1dd3eef3764b7e16994 |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2d32229a0a79708ee9a4f132f630b36d58b4495a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/23947#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23947 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23947 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/23947 |
| Reload | https://github.com/matplotlib/matplotlib/pull/23947 |
| Reload | https://github.com/matplotlib/matplotlib/pull/23947 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23947 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23947 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| QuLogic | https://github.com/QuLogic |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| Conversation | https://github.com/matplotlib/matplotlib/pull/23947 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/23947/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/23947/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/23947/files |
| Fix building on MINGW | https://github.com/matplotlib/matplotlib/pull/23947#top |
| QuLogic | https://github.com/QuLogic |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
|
| https://github.com/MehdiChinoune |
| MehdiChinoune | https://github.com/MehdiChinoune |
| Sep 19, 2022 | https://github.com/matplotlib/matplotlib/pull/23947#issue-1377559772 |
| e1fcc90 | https://github.com/matplotlib/matplotlib/commit/e1fcc90c13b037da1501aa53b3491d27081598ca |
| #23943 | https://github.com/matplotlib/matplotlib/issues/23943 |
| Flake 8 | https://flake8.pycqa.org/en/latest/ |
| build | https://matplotlib.org/devel/documenting_mpl.html#building-the-docs |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23947 |
|
| https://github.com/MehdiChinoune |
| Fix building on MINGW | https://github.com/matplotlib/matplotlib/pull/23947/commits/023d0c6af0f461b6c93aee29638b36a5b28dd69a |
| 023d0c6 | https://github.com/matplotlib/matplotlib/pull/23947/commits/023d0c6af0f461b6c93aee29638b36a5b28dd69a |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Sep 19, 2022
| https://github.com/matplotlib/matplotlib/pull/23947#pullrequestreview-1111858122 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/23947/files/023d0c6af0f461b6c93aee29638b36a5b28dd69a |
| github-actions | https://github.com/apps/github-actions |
| https://github.com/matplotlib/matplotlib/pull/23947#pullrequestreview-1111858122 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| on gitter | https://gitter.im/matplotlib/matplotlib |
| the developer guide | https://matplotlib.org/devdocs/devel/index.html |
| Code of Conduct | https://github.com/matplotlib/matplotlib/blob/main/CODE_OF_CONDUCT.md |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23947 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Sep 19, 2022
| https://github.com/matplotlib/matplotlib/pull/23947#pullrequestreview-1111900352 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/23947/files/023d0c6af0f461b6c93aee29638b36a5b28dd69a |
| src/_tkagg.cpp | https://github.com/matplotlib/matplotlib/pull/23947/files/023d0c6af0f461b6c93aee29638b36a5b28dd69a#diff-3738bd01dcd1fd4455918f1845644a116249a0c94b2f8663e905a7ea909460d3 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23947 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Sep 19, 2022 | https://github.com/matplotlib/matplotlib/pull/23947#issuecomment-1250737124 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23947 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| v3.6.1 | https://github.com/matplotlib/matplotlib/milestone/73 |
| Sep 19, 2022 | https://github.com/matplotlib/matplotlib/pull/23947#event-7411667680 |
|
| https://github.com/MehdiChinoune |
| Fix typo | https://github.com/matplotlib/matplotlib/pull/23947/commits/62058a47afff68f76a89d8905ed931fcf4779165 |
| 62058a4 | https://github.com/matplotlib/matplotlib/pull/23947/commits/62058a47afff68f76a89d8905ed931fcf4779165 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Sep 19, 2022
| https://github.com/matplotlib/matplotlib/pull/23947#pullrequestreview-1112044675 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/23947/files/62058a47afff68f76a89d8905ed931fcf4779165 |
| anntzer | https://github.com/anntzer |
| https://github.com/matplotlib/matplotlib/pull/23947#pullrequestreview-1112044675 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23947 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Sep 19, 2022
| https://github.com/matplotlib/matplotlib/pull/23947#pullrequestreview-1112858105 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/23947/files/62058a47afff68f76a89d8905ed931fcf4779165 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| 68e5ff9 | https://github.com/matplotlib/matplotlib/commit/68e5ff9bd63901f1385da4fad5cafbc62455380f |
| Sep 19, 2022 | https://github.com/matplotlib/matplotlib/pull/23947#event-7416850294 |
| https://github.com/meeseeksmachine |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Sep 19, 2022
| https://github.com/matplotlib/matplotlib/pull/23947#ref-pullrequest-1378500492 |
|
Backport PR #23947 on branch v3.6.x (Fix building on MINGW)
#23960
| https://github.com/matplotlib/matplotlib/pull/23960 |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Sep 19, 2022
| https://github.com/matplotlib/matplotlib/pull/23947#ref-commit-eac65ff |
|
| https://github.com/QuLogic |
|
| https://github.com/meeseeksmachine |
| Backport PR | https://github.com/meeseeksmachine/matplotlib/commit/eac65ff9cbdc29034246c4d5200f329b0191a1e3 |
| matplotlib#23947 | https://github.com/matplotlib/matplotlib/pull/23947 |
| : Fix building on MINGW | https://github.com/meeseeksmachine/matplotlib/commit/eac65ff9cbdc29034246c4d5200f329b0191a1e3 |
| eac65ff | https://github.com/meeseeksmachine/matplotlib/commit/eac65ff9cbdc29034246c4d5200f329b0191a1e3 |
| https://github.com/MehdiChinoune |
| MehdiChinoune | https://github.com/MehdiChinoune |
| September 19, 2022 20:44 | https://github.com/matplotlib/matplotlib/pull/23947#event-7416856391 |
| QuLogic | https://github.com/QuLogic |
|
Sep 20, 2022
| https://github.com/matplotlib/matplotlib/pull/23947#ref-commit-cf37b76 |
|
| https://github.com/QuLogic |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/cf37b763d116bc71902533bb9fe64cb7058cb60f |
| #23960 | https://github.com/matplotlib/matplotlib/pull/23960 |
| from meeseeksmachine/auto-backport-of-pr-23… | https://github.com/matplotlib/matplotlib/commit/cf37b763d116bc71902533bb9fe64cb7058cb60f |
| cf37b76 | https://github.com/matplotlib/matplotlib/commit/cf37b763d116bc71902533bb9fe64cb7058cb60f |
| #23947 | https://github.com/matplotlib/matplotlib/pull/23947 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Sep 20, 2022 | https://github.com/matplotlib/matplotlib/pull/23947#issuecomment-1252509138 |
| @MehdiChinoune | https://github.com/MehdiChinoune |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23947 |
| https://github.com/ksunden |
| ksunden | https://github.com/ksunden |
|
Feb 20, 2023
| https://github.com/matplotlib/matplotlib/pull/23947#ref-pullrequest-1592305660 |
|
merge up 3.7.0
#25270
| https://github.com/matplotlib/matplotlib/pull/25270 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23947 |
|
| https://github.com/apps/github-actions |
|
github-actions[bot]
| https://github.com/apps/github-actions |
|
| https://github.com/matplotlib/matplotlib/pull/23947/files/023d0c6af0f461b6c93aee29638b36a5b28dd69a |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/23947/files/62058a47afff68f76a89d8905ed931fcf4779165 |
|
| https://github.com/anntzer |
|
anntzer
| https://github.com/anntzer |
|
| https://github.com/matplotlib/matplotlib/pull/23947/files/62058a47afff68f76a89d8905ed931fcf4779165 |
|
v3.6.1
| https://github.com/matplotlib/matplotlib/milestone/73 |
|
[Bug]: Couldn't build matplotlib 3.6.0 with both Clang-15 and GCC-12
| https://github.com/matplotlib/matplotlib/issues/23943 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23947 |
|
| https://github.com/MehdiChinoune |
|
| https://github.com/anntzer |
|
| https://github.com/tacaswell |
|
| https://github.com/QuLogic |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |