René's URL Explorer Experiment


Title: FIX: correctly handle generic font families in svg text-as-text mode by tacaswell · Pull Request #23638 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: correctly handle generic font families in svg text-as-text mode by tacaswell · Pull Request #23638 · matplotlib/matplotlib

X Title: FIX: correctly handle generic font families in svg text-as-text mode by tacaswell · Pull Request #23638 · matplotlib/matplotlib

Description: PR Summary This: expands the generic fonts families to the user configured specific fonts in the svg output ensures that each font family only appears once per text element in the svg output ensures that generic families are unquoted and specific families are closes #22528 closes #23492 I still need to write a test for this, but interactively this gives things like There are 几个汉字 in between! PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Open Graph Description: PR Summary This: expands the generic fonts families to the user configured specific fonts in the svg output ensures that each font family only appears once per text element in the svg output ensur...

X Description: PR Summary This: expands the generic fonts families to the user configured specific fonts in the svg output ensures that each font family only appears once per text element in the svg output ensur...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/23638

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c7f0e5c0-71e9-d8f8-e8f6-b560352903be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD450:9F062:27639A7:37F8D74:6A510000
html-safe-nonce6ac7ad4b2a965145dc14dea238a1dceff5444848cfad9d34cdea235dde480fdd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDUwOjlGMDYyOjI3NjM5QTc6MzdGOEQ3NDo2QTUxMDAwMCIsInZpc2l0b3JfaWQiOiIxMzQ5NDMxODQxMTk3MjYwODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf1492a3dcb52625ef8ad2949609ec3ddb5cac54e8ce199705d302a3b19d8a592
hovercard-subject-tagpull_request:1027796809
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/23638/files
twitter:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
og:image:altPR Summary This: expands the generic fonts families to the user configured specific fonts in the svg output ensures that each font family only appears once per text element in the svg output ensur...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/23638/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23638%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23638%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/23638/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/23638/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/23638/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/23638/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/23638/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
tacaswellhttps://github.com/tacaswell
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
tacaswell:svg_generic_fontshttps://github.com/tacaswell/matplotlib/tree/svg_generic_fonts
Conversation 14 https://github.com/matplotlib/matplotlib/pull/23638
Commits 3 https://github.com/matplotlib/matplotlib/pull/23638/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/23638/checks
Files changed https://github.com/matplotlib/matplotlib/pull/23638/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/23638/files
FIX: correctly handle generic font families in svg text-as-text mode https://github.com/matplotlib/matplotlib/pull/23638/files#top
Show all changes 3 commits https://github.com/matplotlib/matplotlib/pull/23638/files
a6f15f2 TST: add a test of font families in svg text-as-text mode tacaswell Aug 17, 2022 https://github.com/matplotlib/matplotlib/pull/23638/commits/a6f15f26dd6c1e2c6a385846aaac48aa30574988
a0fcf79 FIX: correctly handle generic font families in svg text-as-text mode tacaswell Aug 16, 2022 https://github.com/matplotlib/matplotlib/pull/23638/commits/a0fcf79db9306352e084b734519e30390d40f9a5
6e99a52 FIX: do not raise in lru_cached function tacaswell Sep 1, 2022 https://github.com/matplotlib/matplotlib/pull/23638/commits/6e99a524ac5c31498308b3d2675303aa1acdb5b0
Clear filters https://github.com/matplotlib/matplotlib/pull/23638/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/23638/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/23638/files
backend_svg.py https://github.com/matplotlib/matplotlib/pull/23638/files#diff-3f7115dd582045209a3ca182f43c29176d759914b187efec3991883c2487009e
font_manager.py https://github.com/matplotlib/matplotlib/pull/23638/files#diff-aca801331b4c856bff720af0575b9ad63f402c893abd7d939e5547ba961ee324
test_backend_svg.py https://github.com/matplotlib/matplotlib/pull/23638/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
lib/matplotlib/backends/backend_svg.pyhttps://github.com/matplotlib/matplotlib/pull/23638/files#diff-3f7115dd582045209a3ca182f43c29176d759914b187efec3991883c2487009e
View file https://github.com/tacaswell/matplotlib/blob/6e99a524ac5c31498308b3d2675303aa1acdb5b0/lib/matplotlib/backends/backend_svg.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/23638/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/23638/files#diff-3f7115dd582045209a3ca182f43c29176d759914b187efec3991883c2487009e
https://github.com/matplotlib/matplotlib/pull/23638/files#diff-3f7115dd582045209a3ca182f43c29176d759914b187efec3991883c2487009e
lib/matplotlib/font_manager.pyhttps://github.com/matplotlib/matplotlib/pull/23638/files#diff-aca801331b4c856bff720af0575b9ad63f402c893abd7d939e5547ba961ee324
View file https://github.com/tacaswell/matplotlib/blob/6e99a524ac5c31498308b3d2675303aa1acdb5b0/lib/matplotlib/font_manager.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/23638/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/23638/files#diff-aca801331b4c856bff720af0575b9ad63f402c893abd7d939e5547ba961ee324
https://github.com/matplotlib/matplotlib/pull/23638/files#diff-aca801331b4c856bff720af0575b9ad63f402c893abd7d939e5547ba961ee324
https://github.com/matplotlib/matplotlib/pull/23638/files#diff-aca801331b4c856bff720af0575b9ad63f402c893abd7d939e5547ba961ee324
https://github.com/matplotlib/matplotlib/pull/23638/files#diff-aca801331b4c856bff720af0575b9ad63f402c893abd7d939e5547ba961ee324
https://github.com/matplotlib/matplotlib/pull/23638/files#diff-aca801331b4c856bff720af0575b9ad63f402c893abd7d939e5547ba961ee324
lib/matplotlib/tests/test_backend_svg.pyhttps://github.com/matplotlib/matplotlib/pull/23638/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
View file https://github.com/tacaswell/matplotlib/blob/6e99a524ac5c31498308b3d2675303aa1acdb5b0/lib/matplotlib/tests/test_backend_svg.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/23638/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/23638/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.