Title: [bug correction] trirefine is now independant of triangulation numbering by GBillotey · Pull Request #2363 · matplotlib/matplotlib · GitHub
Open Graph Title: [bug correction] trirefine is now independant of triangulation numbering by GBillotey · Pull Request #2363 · matplotlib/matplotlib
X Title: [bug correction] trirefine is now independant of triangulation numbering by GBillotey · Pull Request #2363 · matplotlib/matplotlib
Description: Correction in cubic interpolation function: the interpolated values on refined triangular grids should be the same regardless of the triangles ordering. As of today, this was not the case for the cubic interpolation, as discovered by @ianthomas23 (refer to the new test enclosed in this PR, which was failing and should now pass). The differences were small but I consider this was a bug (at least highly unexpected). The solution is a new choice for the Gauss quadrature points. I added a new (non-image) test and updated the 2 baseline images involving this kind of cubic interpolation (one was failing as a result of this PR ; I also updated the 2nd to get a fresh start). Note: As changing the Gauss points was not my first guess (unfortunately...) I also made a double-check of the various shape functions used in _ReducedHCT_Element For this I found that it was more convenient to arrange them by columns, even if it this is not strictly pep8. If this is considered bad practise, please tell me ; I would be happy to revert.
Open Graph Description: Correction in cubic interpolation function: the interpolated values on refined triangular grids should be the same regardless of the triangles ordering. As of today, this was not the case for the c...
X Description: Correction in cubic interpolation function: the interpolated values on refined triangular grids should be the same regardless of the triangles ordering. As of today, this was not the case for the c...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/2363
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:419ee7e1-42b5-6748-2afe-794224288bd4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8DCA:368878:3D5E1:50CCC:6A545FE3 |
| html-safe-nonce | 2db2eee94e18095fb4504dcd3f2e4de329ebebb0e11f4f2ca7bc2bc95ac8efc9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RENBOjM2ODg3ODozRDVFMTo1MENDQzo2QTU0NUZFMyIsInZpc2l0b3JfaWQiOiIxODE0Njc0MDE3MDY1NjU2MjkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 79b38649bbb28d27a05f9a5ba56c1d2ddc21de5e7e736db3a3ca9a4b83782575 |
| hovercard-subject-tag | pull_request:8009487 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/2363/files |
| twitter:image | https://avatars.githubusercontent.com/u/2669128?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2669128?s=400&v=4 |
| og:image:alt | Correction in cubic interpolation function: the interpolated values on refined triangular grids should be the same regardless of the triangles ordering. As of today, this was not the case for the c... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6d28624802c2f7d9500239dd6870ed7031b7353b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width
