René's URL Explorer Experiment


Title: Annotation refactor by tacaswell · Pull Request #2351 · matplotlib/matplotlib · GitHub

Open Graph Title: Annotation refactor by tacaswell · Pull Request #2351 · matplotlib/matplotlib

X Title: Annotation refactor by tacaswell · Pull Request #2351 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: Addresses issue #2329 The xyann and anncoords properties (if people think that is a good thing to rename them to) should probably be pushed up to the _AnnotationBase level.

X Description: Addresses issue #2329 The xyann and anncoords properties (if people think that is a good thing to rename them to) should probably be pushed up to the _AnnotationBase level.

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/2351

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:837a2514-91c9-48a3-309a-b9cd9a0989a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C24:3A796C:1E1C8D:272DFA:6A52E80A
html-safe-noncea62aa016da2df9abb553261a63d61b89e3873874163f879dd3f83b9c349e7b7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzI0OjNBNzk2QzoxRTFDOEQ6MjcyREZBOjZBNTJFODBBIiwidmlzaXRvcl9pZCI6IjYxMzg5MDc0OTgyNjc4NzMzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5e25c79a2f5fdd110564862882fd9b33943db2e617b0809adb59a77e500febb3
hovercard-subject-tagpull_request:7904464
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/2351/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9906cf5fc875735a880a42c54239907223025c98c11702ee8df06c18a2067f6b/matplotlib/matplotlib/pull/2351
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9906cf5fc875735a880a42c54239907223025c98c11702ee8df06c18a2067f6b/matplotlib/matplotlib/pull/2351
og:image:altAddresses issue #2329 The xyann and anncoords properties (if people think that is a good thing to rename them to) should probably be pushed up to the _AnnotationBase level.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametacaswell
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/2351#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F2351
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F2351
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/2351
Reloadhttps://github.com/matplotlib/matplotlib/pull/2351
Reloadhttps://github.com/matplotlib/matplotlib/pull/2351
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
mdboomhttps://github.com/mdboom
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tacaswell:annotation_refactorhttps://github.com/tacaswell/matplotlib/tree/annotation_refactor
Conversationhttps://github.com/matplotlib/matplotlib/pull/2351
Commits4 (4)https://github.com/matplotlib/matplotlib/pull/2351/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/2351/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/2351/files
Annotation refactorhttps://github.com/matplotlib/matplotlib/pull/2351#top
mdboomhttps://github.com/mdboom
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tacaswell:annotation_refactorhttps://github.com/tacaswell/matplotlib/tree/annotation_refactor
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Aug 27, 2013https://github.com/matplotlib/matplotlib/pull/2351#issue-18638189
#2329https://github.com/matplotlib/matplotlib/issues/2329
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Aug 29, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-23526216
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Sep 4, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-23802583
@mdboomhttps://github.com/mdboom
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
mdboomhttps://github.com/mdboom
Sep 4, 2013 https://github.com/matplotlib/matplotlib/pull/2351#discussion-diff-6159038
View reviewed changes https://github.com/matplotlib/matplotlib/pull/2351/files/27c35461ba78a9381a20383347e976297667fee2#diff-c0f3394227ee94f97502e7cfb9b128bb8249d8f68ea51c9e0552ed885bcd81a7
lib/matplotlib/offsetbox.pyhttps://github.com/matplotlib/matplotlib/pull/2351/files#diff-c0f3394227ee94f97502e7cfb9b128bb8249d8f68ea51c9e0552ed885bcd81a7
mdboomhttps://github.com/mdboom
Sep 4, 2013https://github.com/matplotlib/matplotlib/pull/2351#discussion_r6159038
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
tacaswellhttps://github.com/tacaswell
Sep 5, 2013https://github.com/matplotlib/matplotlib/pull/2351#discussion_r6172956
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/mdboom
mdboomhttps://github.com/mdboom
Sep 4, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-23804736
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Sep 5, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-23841750
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/mdboom
mdboomhttps://github.com/mdboom
Sep 5, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-23864405
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Sep 7, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-23998303
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Sep 7, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-23999009
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Sep 10, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-24194193
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/mdboom
mdboomhttps://github.com/mdboom
Sep 10, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-24198239
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
tacaswellhttps://github.com/tacaswell
September 10, 2013 17:19https://github.com/matplotlib/matplotlib/pull/2351#commits-pushed-a65151b
https://github.com/tacaswell
removed un-needed legacy code (_AnnotationBase._get_xy_legacy)https://github.com/matplotlib/matplotlib/pull/2351/commits/a65151be33b7b50fd9f40c72c5b3e965685cc13b
a65151bhttps://github.com/matplotlib/matplotlib/pull/2351/commits/a65151be33b7b50fd9f40c72c5b3e965685cc13b
https://github.com/tacaswell
re factored _AnnoationBase to push keeping track of there thehttps://github.com/matplotlib/matplotlib/pull/2351/commits/3363b125715724ad89d4b33cbddb23e31e7277d5
3363b12https://github.com/matplotlib/matplotlib/pull/2351/commits/3363b125715724ad89d4b33cbddb23e31e7277d5
https://github.com/tacaswell
pep8 fixeshttps://github.com/matplotlib/matplotlib/pull/2351/commits/38b938573666490de5d09b0fbb43a1a7b84c73b3
38b9385https://github.com/matplotlib/matplotlib/pull/2351/commits/38b938573666490de5d09b0fbb43a1a7b84c73b3
https://github.com/tacaswell
added test for Annotation.set_positionhttps://github.com/matplotlib/matplotlib/pull/2351/commits/f6e3edc1bc574069b6f79e8b40af6ae5e539095d
f6e3edchttps://github.com/matplotlib/matplotlib/pull/2351/commits/f6e3edc1bc574069b6f79e8b40af6ae5e539095d
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Sep 10, 2013https://github.com/matplotlib/matplotlib/pull/2351#issuecomment-24199611
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
mdboomhttps://github.com/mdboom
Sep 10, 2013 https://github.com/matplotlib/matplotlib/pull/2351#ref-commit-da6c6b5
https://github.com/mdboom
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/da6c6b5f801ed4fc683e69d37ee8a0a3e8096f37
#2351https://github.com/matplotlib/matplotlib/pull/2351
from tacaswell/annotation_refactorhttps://github.com/matplotlib/matplotlib/commit/da6c6b5f801ed4fc683e69d37ee8a0a3e8096f37
da6c6b5https://github.com/matplotlib/matplotlib/commit/da6c6b5f801ed4fc683e69d37ee8a0a3e8096f37
https://github.com/mdboom
mdboomhttps://github.com/mdboom
da6c6b5https://github.com/matplotlib/matplotlib/commit/da6c6b5f801ed4fc683e69d37ee8a0a3e8096f37
Sep 10, 2013https://github.com/matplotlib/matplotlib/pull/2351#event-64823462
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
September 11, 2013 15:16https://github.com/matplotlib/matplotlib/pull/2351#event-64940482
tacaswellhttps://github.com/tacaswell
Jan 10, 2015 https://github.com/matplotlib/matplotlib/pull/2351#ref-commit-9ea9159
https://github.com/tacaswell
MNT : remove deprecated code from Annocationhttps://github.com/tacaswell/matplotlib/commit/9ea9159c9bb41219a5ed0b5b7b9aba55bfa2f077
9ea9159https://github.com/tacaswell/matplotlib/commit/9ea9159c9bb41219a5ed0b5b7b9aba55bfa2f077
matplotlib#2351https://github.com/matplotlib/matplotlib/pull/2351
da6c6b5https://github.com/tacaswell/matplotlib/commit/da6c6b5f801ed4fc683e69d37ee8a0a3e8096f37
tacaswellhttps://github.com/tacaswell
Jan 10, 2015 https://github.com/matplotlib/matplotlib/pull/2351#ref-commit-402580b
https://github.com/tacaswell
MNT : remove deprecated code from Annotationhttps://github.com/tacaswell/matplotlib/commit/402580b85dcbd105bbf4cc8890e585a70dcb1f9a
402580bhttps://github.com/tacaswell/matplotlib/commit/402580b85dcbd105bbf4cc8890e585a70dcb1f9a
matplotlib#2351https://github.com/matplotlib/matplotlib/pull/2351
da6c6b5https://github.com/tacaswell/matplotlib/commit/da6c6b5f801ed4fc683e69d37ee8a0a3e8096f37
tacaswellhttps://github.com/tacaswell
Jan 22, 2015 https://github.com/matplotlib/matplotlib/pull/2351#ref-commit-310cab1
https://github.com/tacaswell
MNT : remove deprecated code from Annotationhttps://github.com/tacaswell/matplotlib/commit/310cab1f50fa534c4adefbf174fa74b7eccc8bf9
310cab1https://github.com/tacaswell/matplotlib/commit/310cab1f50fa534c4adefbf174fa74b7eccc8bf9
matplotlib#2351https://github.com/matplotlib/matplotlib/pull/2351
da6c6b5https://github.com/tacaswell/matplotlib/commit/da6c6b5f801ed4fc683e69d37ee8a0a3e8096f37
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
May 18, 2015 https://github.com/matplotlib/matplotlib/pull/2351#ref-issue-77396836
MatplotlibDeprecationWarning: Use xyann instead #4440 https://github.com/matplotlib/matplotlib/issues/4440
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jul 22, 2015 https://github.com/matplotlib/matplotlib/pull/2351#ref-issue-64999461
Annotation with negative axes fraction coordinate placed incorrectly with v1.4.3 #4292 https://github.com/matplotlib/matplotlib/issues/4292
tacaswellhttps://github.com/tacaswell
Jul 31, 2015 https://github.com/matplotlib/matplotlib/pull/2351#ref-commit-7b71257
https://github.com/tacaswell
Revert " Merge pull requesthttps://github.com/tacaswell/matplotlib/commit/7b712579fbb6f9300bee18228ba4b567ab4f9045
matplotlib#4019https://github.com/matplotlib/matplotlib/pull/4019
from myshen/annot_neg_coo…https://github.com/tacaswell/matplotlib/commit/7b712579fbb6f9300bee18228ba4b567ab4f9045
7b71257https://github.com/tacaswell/matplotlib/commit/7b712579fbb6f9300bee18228ba4b567ab4f9045
d6e1577https://github.com/tacaswell/matplotlib/commit/d6e15779e9588d8d2f58864d7ba435f666cb0326
b280f7dhttps://github.com/tacaswell/matplotlib/commit/b280f7d98714e2eaa60bec5f0b332a425bb94e39
matplotlib#2351https://github.com/matplotlib/matplotlib/pull/2351
matplotlib#4012https://github.com/matplotlib/matplotlib/issues/4012
matplotlib#4019https://github.com/matplotlib/matplotlib/pull/4019
matplotlib#4292https://github.com/matplotlib/matplotlib/issues/4292
tacaswellhttps://github.com/tacaswell
Jul 31, 2015 https://github.com/matplotlib/matplotlib/pull/2351#ref-commit-0f7b217
https://github.com/tacaswell
TST: add tests for not wrapping annotation coordshttps://github.com/tacaswell/matplotlib/commit/0f7b217cddc1e7d81064d0bf3b7902aee2f35788
0f7b217https://github.com/tacaswell/matplotlib/commit/0f7b217cddc1e7d81064d0bf3b7902aee2f35788
matplotlib#2351https://github.com/matplotlib/matplotlib/pull/2351
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Sep 17, 2018 https://github.com/matplotlib/matplotlib/pull/2351#ref-pullrequest-360950105
Add explicit getters and setters for Annotation.anncoords. #12144 https://github.com/matplotlib/matplotlib/pull/12144
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F2351
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/2351
https://github.com/tacaswell
https://github.com/mdboom
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.