Title: Fix displayed 3d coordinates showing gibberish by scottshambaugh · Pull Request #23485 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix displayed 3d coordinates showing gibberish by scottshambaugh · Pull Request #23485 · matplotlib/matplotlib
X Title: Fix displayed 3d coordinates showing gibberish by scottshambaugh · Pull Request #23485 · matplotlib/matplotlib
Description: PR Summary Closes #22775 and closes #4334. Also gets rid of the annoying helper function at cause in #23430. Some previous discussion in #22624. As the first issue shows, the displayed coordinates under the mouse cursor are currently meaningless. The calculation in this PR shows the x, y, z point on the displayed plane at the mouse location. For example, ignoring the broken Z coordinate for now, the mouse here is at the circled location and the coordinates displayed are on the x-z plane (the y coordinate is fixed at any point on this plane). TODO: Coordinates for x and y are working, z is not. Need to figure out why, likely not passing in the right z view coordinates. This page might help https://github.com/matplotlib/matplotlib/pull/23449/files replaces self.vvec with self._view_w, need to switch that over depending on which is merged first. The signs are flipped between those two variables but we multiply twice so it cancels out and can be directly replaced. Tests PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
Open Graph Description: PR Summary Closes #22775 and closes #4334. Also gets rid of the annoying helper function at cause in #23430. Some previous discussion in #22624. As the first issue shows, the displayed coordinates ...
X Description: PR Summary Closes #22775 and closes #4334. Also gets rid of the annoying helper function at cause in #23430. Some previous discussion in #22624. As the first issue shows, the displayed coordinates ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/23485
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3e4a3f6f-3be7-46ad-6caf-50744646041d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9AA:1BD726:2E81B70:3F15B43:6A549499 |
| html-safe-nonce | a0d546ee3bce0b5741960d5d5628da3ec823385301ced15643a94c045951b9e3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUFBOjFCRDcyNjoyRTgxQjcwOjNGMTVCNDM6NkE1NDk0OTkiLCJ2aXNpdG9yX2lkIjoiNDQ4ODgxMjgxNjk2MzUwNzM1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bff334961284b4793fb80b065f6c54e2be61dfddc311aacdad92bceb5bd20e32 |
| hovercard-subject-tag | pull_request:1006814462 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/23485/files |
| twitter:image | https://avatars.githubusercontent.com/u/14363975?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/14363975?s=400&v=4 |
| og:image:alt | PR Summary Closes #22775 and closes #4334. Also gets rid of the annoying helper function at cause in #23430. Some previous discussion in #22624. As the first issue shows, the displayed coordinates ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8cfff6384f62259baea531c7f58bc7040f8dd92 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width
