Title: Remove custom backend_nbagg.show(), putting logic in manager show. by anntzer · Pull Request #23100 · matplotlib/matplotlib · GitHub
Open Graph Title: Remove custom backend_nbagg.show(), putting logic in manager show. by anntzer · Pull Request #23100 · matplotlib/matplotlib
X Title: Remove custom backend_nbagg.show(), putting logic in manager show. by anntzer · Pull Request #23100 · matplotlib/matplotlib
Description: The _Backend class machinery can autogenerate a backend_module.show() function, which (in short) calls manager.show() on all managers and then calls the optionally-provided mainloop() function. backend_nbagg currently completely bypasses this autogeneration because it wants to additionally fiddle with callbacks and Gcf (it doesn't need any mainloop()), but that logic can just as well go to FigureManagerNbAgg.show() instead. This way it benefits from the default-generated show; moreover, it seems a bit strange that figures shown with manager.show() (instead of plt.show()) do indeed get displayed, but just don't have their callbacks/Gcf-ness adjusted. This is also related to the move towards putting show()-generating information on the canvas class for inheritability (#23090). PR Summary PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).
Open Graph Description: The _Backend class machinery can autogenerate a backend_module.show() function, which (in short) calls manager.show() on all managers and then calls the optionally-provided mainloop() function. bac...
X Description: The _Backend class machinery can autogenerate a backend_module.show() function, which (in short) calls manager.show() on all managers and then calls the optionally-provided mainloop() function. bac...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/23100
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f313dde9-05d4-7cae-ffb3-fa9029e3dd94 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF4C:3C2C9:D9E115:13DDEA2:6A54BFD5 |
| html-safe-nonce | de7c400235534cf077dfad8490fb0f4bf1e5b0cbc3763442f0b5e08a36ac3f8d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjRDOjNDMkM5OkQ5RTExNToxM0RERUEyOjZBNTRCRkQ1IiwidmlzaXRvcl9pZCI6Ijg4MjE0Mjg4MTI3MzI3NDM2MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b88068267caabfe48ba9821a586f61dddc7e71301588a208646d1c4391b02454 |
| hovercard-subject-tag | pull_request:943708734 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/23100/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | The _Backend class machinery can autogenerate a backend_module.show() function, which (in short) calls manager.show() on all managers and then calls the optionally-provided mainloop() function. bac... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 69f9664dd5e7a82ba8ab1b4cb7f5a2f09333ab38 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width