| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b84eb3b0-c5eb-3e8d-5601-fe303ce15b88 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8132:1B23D3:4E62A:6A67A:6A51AB98 |
| html-safe-nonce | bf8df9eeb50dfc24933acabdf37b73807e8fbcd958713f2005f5b04f13acbdce |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTMyOjFCMjNEMzo0RTYyQTo2QTY3QTo2QTUxQUI5OCIsInZpc2l0b3JfaWQiOiI5MjE2OTEyMTk3MzcxOTMxNTQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d321ce2e0dd3202162e0c3556c5af7dc8f052d5229b8de7c9b47dd788afb0d54 |
| hovercard-subject-tag | pull_request:939920729 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/23066/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d2377af0f9243413bca67a53d0eb8596ffbb7c6c20423eac2641a16f1da2f659/matplotlib/matplotlib/pull/23066 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d2377af0f9243413bca67a53d0eb8596ffbb7c6c20423eac2641a16f1da2f659/matplotlib/matplotlib/pull/23066 |
| og:image:alt | PR Summary
Define PyErr_SetFromWindowsErr on Cygwin. This function is defined on Windows, not Cygwin.
Closes #22997.
PR Checklist
Tests and Styling
Has pytest style unit tests (and pytest passe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DWesl |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/23066#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23066 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23066 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/23066 |
| Reload | https://github.com/matplotlib/matplotlib/pull/23066 |
| Reload | https://github.com/matplotlib/matplotlib/pull/23066 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| anntzer | https://github.com/anntzer |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| DWesl:cygwin-define-pyerr-setfromwindowserr | https://github.com/DWesl/matplotlib/tree/cygwin-define-pyerr-setfromwindowserr |
| Conversation | https://github.com/matplotlib/matplotlib/pull/23066 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/23066/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/23066/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/23066/files |
| BLD: Define PyErr_SetFromWindowsErr on Cygwin. | https://github.com/matplotlib/matplotlib/pull/23066#top |
| anntzer | https://github.com/anntzer |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| DWesl:cygwin-define-pyerr-setfromwindowserr | https://github.com/DWesl/matplotlib/tree/cygwin-define-pyerr-setfromwindowserr |
|
| https://github.com/DWesl |
| DWesl | https://github.com/DWesl |
| May 18, 2022 | https://github.com/matplotlib/matplotlib/pull/23066#issue-1239905215 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
| #22997 | https://github.com/matplotlib/matplotlib/issues/22997 |
| Flake 8 | https://flake8.pycqa.org/en/latest/ |
| build | https://matplotlib.org/devel/documenting_mpl.html#building-the-docs |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
|
| https://github.com/DWesl |
| BLD: Define an error function on Cygwin. | https://github.com/matplotlib/matplotlib/pull/23066/commits/2bea21b2b86275d8a0bf70b7ff881e0e73735c67 |
| 2bea21b | https://github.com/matplotlib/matplotlib/pull/23066/commits/2bea21b2b86275d8a0bf70b7ff881e0e73735c67 |
| https://github.com/DWesl |
| DWesl | https://github.com/DWesl |
|
May 18, 2022
| https://github.com/matplotlib/matplotlib/pull/23066#ref-issue-1228423124 |
|
[Bug]: Cygwin build fails due to use of Windows-only functions in _tkagg.cpp
#22997
| https://github.com/matplotlib/matplotlib/issues/22997 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
May 18, 2022
| https://github.com/matplotlib/matplotlib/pull/23066#pullrequestreview-977225816 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/23066/files/2bea21b2b86275d8a0bf70b7ff881e0e73735c67 |
| src/_tkagg.cpp | https://github.com/matplotlib/matplotlib/pull/23066/files/2bea21b2b86275d8a0bf70b7ff881e0e73735c67#diff-3738bd01dcd1fd4455918f1845644a116249a0c94b2f8663e905a7ea909460d3 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| May 18, 2022 | https://github.com/matplotlib/matplotlib/pull/23066#issuecomment-1130231271 |
| @DWesl | https://github.com/DWesl |
| https://github.com/python/cpython/blob/39a54ba63850e081a4a5551a773df5b4d5b1d3cd/Include/pyerrors.h#L188 | https://github.com/python/cpython/blob/39a54ba63850e081a4a5551a773df5b4d5b1d3cd/Include/pyerrors.h#L188 |
| https://github.com/python/cpython/blob/a4460f2eb8b9db46a9bce3c450c8b038038a7c93/Python/errors.c#L867 | https://github.com/python/cpython/blob/a4460f2eb8b9db46a9bce3c450c8b038038a7c93/Python/errors.c#L867 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
|
| https://github.com/DWesl |
| BUG: Fix the returned value for PyErr_SetFromWindowsErr | https://github.com/matplotlib/matplotlib/pull/23066/commits/89249134fef32302328e50776072229a00633b6e |
| 8924913 | https://github.com/matplotlib/matplotlib/pull/23066/commits/89249134fef32302328e50776072229a00633b6e |
| https://github.com/DWesl |
| DWesl | https://github.com/DWesl |
| May 18, 2022 | https://github.com/matplotlib/matplotlib/pull/23066#event-6633994063 |
| https://github.com/DWesl |
| DWesl | https://github.com/DWesl |
| May 18, 2022 | https://github.com/matplotlib/matplotlib/pull/23066#issuecomment-1130253636 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| May 18, 2022 | https://github.com/matplotlib/matplotlib/pull/23066#issuecomment-1130290017 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| v3.5.3 | https://github.com/matplotlib/matplotlib/milestone/71 |
| May 18, 2022 | https://github.com/matplotlib/matplotlib/pull/23066#event-6635117900 |
| https://github.com/DWesl |
| DWesl | https://github.com/DWesl |
| May 30, 2022 | https://github.com/matplotlib/matplotlib/pull/23066#issuecomment-1141332636 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Jun 30, 2022 | https://github.com/matplotlib/matplotlib/pull/23066#issuecomment-1170966943 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| June 30, 2022 09:10 | https://github.com/matplotlib/matplotlib/pull/23066#event-6909015159 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Jul 26, 2022
| https://github.com/matplotlib/matplotlib/pull/23066#pullrequestreview-1050337924 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/23066/files/89249134fef32302328e50776072229a00633b6e |
| QuLogic | https://github.com/QuLogic |
| https://github.com/matplotlib/matplotlib/pull/23066#pullrequestreview-1050337924 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| July 26, 2022 04:05 | https://github.com/matplotlib/matplotlib/pull/23066#event-7061449792 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Jul 26, 2022
| https://github.com/matplotlib/matplotlib/pull/23066#ref-pullrequest-1228468475 |
|
CI: Add a Cygwin run to GHA CI.
#22999
| https://github.com/matplotlib/matplotlib/pull/22999 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Jul 26, 2022
| https://github.com/matplotlib/matplotlib/pull/23066#pullrequestreview-1050436038 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/23066/files/89249134fef32302328e50776072229a00633b6e |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| 446de7b | https://github.com/matplotlib/matplotlib/commit/446de7bbb6514cb41a8ac3c6e2ecaab7d1bd29ac |
| Jul 26, 2022 | https://github.com/matplotlib/matplotlib/pull/23066#event-7062045358 |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Jul 26, 2022
| https://github.com/matplotlib/matplotlib/pull/23066#ref-commit-a372bb3 |
|
| https://github.com/anntzer |
|
| https://github.com/meeseeksmachine |
| Backport PR | https://github.com/meeseeksmachine/matplotlib/commit/a372bb30b18db061edaaab53c7229d75e623687f |
| matplotlib#23066 | https://github.com/matplotlib/matplotlib/pull/23066 |
| : BLD: Define PyErr_SetFromWindowsErr on … | https://github.com/meeseeksmachine/matplotlib/commit/a372bb30b18db061edaaab53c7229d75e623687f |
| a372bb3 | https://github.com/meeseeksmachine/matplotlib/commit/a372bb30b18db061edaaab53c7229d75e623687f |
| https://github.com/meeseeksmachine |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Jul 26, 2022
| https://github.com/matplotlib/matplotlib/pull/23066#ref-pullrequest-1317769767 |
|
Backport PR #23066 on branch v3.5.x (BLD: Define PyErr_SetFromWindowsErr on Cygwin.)
#23488
| https://github.com/matplotlib/matplotlib/pull/23488 |
| QuLogic | https://github.com/QuLogic |
|
Jul 26, 2022
| https://github.com/matplotlib/matplotlib/pull/23066#ref-commit-4ee298b |
|
| https://github.com/QuLogic |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/4ee298be6b719b011c12e56b09758d9a5b28fa6c |
| #23488 | https://github.com/matplotlib/matplotlib/pull/23488 |
| from meeseeksmachine/auto-backport-of-pr-23… | https://github.com/matplotlib/matplotlib/commit/4ee298be6b719b011c12e56b09758d9a5b28fa6c |
| 4ee298b | https://github.com/matplotlib/matplotlib/commit/4ee298be6b719b011c12e56b09758d9a5b28fa6c |
| #23066 | https://github.com/matplotlib/matplotlib/pull/23066 |
| https://github.com/DWesl |
| DWesl | https://github.com/DWesl |
| February 25, 2024 11:30 | https://github.com/matplotlib/matplotlib/pull/23066#event-11912785699 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F23066 |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/23066/files/89249134fef32302328e50776072229a00633b6e |
|
| https://github.com/anntzer |
|
anntzer
| https://github.com/anntzer |
|
| https://github.com/matplotlib/matplotlib/pull/23066/files/89249134fef32302328e50776072229a00633b6e |
|
v3.5.3
| https://github.com/matplotlib/matplotlib/milestone/71 |
|
[Bug]: Cygwin build fails due to use of Windows-only functions in _tkagg.cpp
| https://github.com/matplotlib/matplotlib/issues/22997 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/23066 |
|
| https://github.com/DWesl |
|
| https://github.com/anntzer |
|
| https://github.com/jklymak |
|
| https://github.com/QuLogic |
|
| https://github.com/tacaswell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |