René's URL Explorer Experiment


Title: Fix RangeSlider for same init values #22686 by AnnaMastori · Pull Request #22926 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix RangeSlider for same init values #22686 by AnnaMastori · Pull Request #22926 · matplotlib/matplotlib

X Title: Fix RangeSlider for same init values #22686 by AnnaMastori · Pull Request #22926 · matplotlib/matplotlib

Description: PR Summary Change the way that polygon is initilized to cover edge case of same init values. The method axhspan is no longer used and the polygon is created manually. (closes #22686 ) PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).

Open Graph Description: PR Summary Change the way that polygon is initilized to cover edge case of same init values. The method axhspan is no longer used and the polygon is created manually. (closes #22686 ) PR Checklist ...

X Description: PR Summary Change the way that polygon is initilized to cover edge case of same init values. The method axhspan is no longer used and the polygon is created manually. (closes #22686 ) PR Checklist ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/22926

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3623eaff-bcaf-be81-4088-55985432af83
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE68C:25BA60:10690F5:15DDE09:6A533B75
html-safe-nonce6a85a2c71b81204ff9a1609bb3a940a0993cbb76359fbdc825ea95445b528071
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjhDOjI1QkE2MDoxMDY5MEY1OjE1RERFMDk6NkE1MzNCNzUiLCJ2aXNpdG9yX2lkIjoiNjAyOTE0Mjc1OTY3MTI4MjU0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb534e7c3621226b72e621a59cc3f987ea6a1d41c99eb0b422985cd56f66d9803
hovercard-subject-tagpull_request:921864623
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/22926/files
twitter:imagehttps://avatars.githubusercontent.com/u/72812754?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/72812754?s=400&v=4
og:image:altPR Summary Change the way that polygon is initilized to cover edge case of same init values. The method axhspan is no longer used and the polygon is created manually. (closes #22686 ) PR Checklist ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/22926/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22926%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22926%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/22926/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/22926/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/22926/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22926/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22926/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
timhoffmhttps://github.com/timhoffm
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
NickolasGiannatos:fix-range-sliderhttps://github.com/NickolasGiannatos/matplotlib/tree/fix-range-slider
Conversation 28 https://github.com/matplotlib/matplotlib/pull/22926
Commits 18 https://github.com/matplotlib/matplotlib/pull/22926/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/22926/checks
Files changed https://github.com/matplotlib/matplotlib/pull/22926/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22926/files
Fix RangeSlider for same init values #22686 https://github.com/matplotlib/matplotlib/pull/22926/files#top
Show all changes 18 commits https://github.com/matplotlib/matplotlib/pull/22926/files
4ec62cb Change creation of vertical polygon for rangeSlider widget NickolasGiannatos Apr 28, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/4ec62cb44253f60ae7f930bf4c8b0d4ca556a06d
0024a67 Change creation of horizontal polygon for RangeSlider widget AnnaMastori Apr 28, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/0024a674b0b8f44927c21dab7a6812ac52719ae6
9aa50bf Fix spaces NickolasGiannatos Apr 28, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/9aa50bfb5bab28ddba915fb197dc74075f771d40
b667cca Change method that transforms vertical polygon NickolasGiannatos Apr 29, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/b667cca780728c7f6287ff1aa1bd0e33abe08344
4d75927 Refactor RangeSlider __init__ method NickolasGiannatos May 3, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/4d75927cb23e2e30a2f8f1caf1f836f6f374afcb
88e846a Create method _fill_verts AnnaMastori May 3, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/88e846a6a5a937c71c1ccbdad985c80c92fd5a16
e1c23d5 Refactor init method of RangeSlider AnnaMastori May 4, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/e1c23d5f0bdf98223ced1d327b4f237ba8a347ff
0c59df8 Change documentation of method _fill_verts NickolasGiannatos May 4, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/0c59df8087686e6e99906bf69be5a625b60be7b8
7172144 Fix docstring in method _fill_verts NickolasGiannatos May 4, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/71721444adb9db51efc9bd613471a2ee96869e41
2fa1304 Fix docstring indentation in _fill_verts method NickolasGiannatos May 5, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/2fa1304b1d5ddecbd44c7ca4d7b802b349b572ab
a830b29 Refactor method set_val NickolasGiannatos May 5, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/a830b29e20fb5aa4a71ec529e4f374bed80483c8
bf1346c Refactor method set_val in RangeSlider AnnaMastori May 5, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/bf1346c5134f22d9a0033ce10dbcade016b54ba3
3285c5c Change method _fill_verts to _update_selection_poly in RangeSlider AnnaMastori May 6, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/3285c5ce8cbe7da67154ee08297302d4d24618bd
1130948 Refactor method set_val in RangeSlider NickolasGiannatos May 6, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/1130948f704e8d83db5e319fb749d3d1e2937bdc
8774b1b Add case of same init values in test_range_slider NickolasGiannatos May 6, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/8774b1ba59fe7b46a692d2a344ab367bd6e65e00
306237c Fix indentation NickolasGiannatos May 6, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/306237c8b591af6c0afbfe6693ef284e9cad4d52
382aed2 Remove test case for same init values from test_range_slider method AnnaMastori May 7, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/382aed2de637489aafea596befdf8570c1bcc72a
4cc82f1 Add test method test_range_slider_same_init_values AnnaMastori May 7, 2022 https://github.com/matplotlib/matplotlib/pull/22926/commits/4cc82f1975d5230a9d4bc40e1954b34928346c6e
Clear filters https://github.com/matplotlib/matplotlib/pull/22926/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22926/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22926/files
test_widgets.py https://github.com/matplotlib/matplotlib/pull/22926/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
widgets.py https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
lib/matplotlib/tests/test_widgets.pyhttps://github.com/matplotlib/matplotlib/pull/22926/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
View file https://github.com/NickolasGiannatos/matplotlib/blob/4cc82f1975d5230a9d4bc40e1954b34928346c6e/lib/matplotlib/tests/test_widgets.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/22926/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
lib/matplotlib/widgets.pyhttps://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
View file https://github.com/NickolasGiannatos/matplotlib/blob/4cc82f1975d5230a9d4bc40e1954b34928346c6e/lib/matplotlib/widgets.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/22926/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
https://github.com/matplotlib/matplotlib/pull/22926/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.