Title: Alternative approach to organizing uniform manager creation by timhoffm · Pull Request #22895 · matplotlib/matplotlib · GitHub
Open Graph Title: Alternative approach to organizing uniform manager creation by timhoffm · Pull Request #22895 · matplotlib/matplotlib
X Title: Alternative approach to organizing uniform manager creation by timhoffm · Pull Request #22895 · matplotlib/matplotlib
Description: Alternative to #18854. Basic idea: The canvas feels like it should be a relatively simple widget class and not have to care about the logic of creating a manager. Still we want canvas.new_manager() for convenience. So let's move the responsibility of wiring everything up to the Manager class and let the Canvas class only know which manager class to ask for creating a manager. For easier understanding of the differences, this builds on top of #18854, but commits may be squashed. This still needs reorganization/tweaking as the Manager classes are currently defined after the Canvas classes in the backends, so setting a Canvas class variable to a manager does not work out of the box (either change the definition order or make manager_class a class property to delay lookup).
Open Graph Description: Alternative to #18854. Basic idea: The canvas feels like it should be a relatively simple widget class and not have to care about the logic of creating a manager. Still we want canvas.new_manager(...
X Description: Alternative to #18854. Basic idea: The canvas feels like it should be a relatively simple widget class and not have to care about the logic of creating a manager. Still we want canvas.new_manager(...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/22895
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:814d3f2d-4591-c418-4310-545991fdb062 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D78E:9AB14:43E4F9:5C987A:6A553F2F |
| html-safe-nonce | a31277b13e7c8b28fe054dbff6862e71b609f78b54694d42e0daefbdcd4d971a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzhFOjlBQjE0OjQzRTRGOTo1Qzk4N0E6NkE1NTNGMkYiLCJ2aXNpdG9yX2lkIjoiODQxMTk1ODQxNjEyMjM5NjQ2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3e1738a32525a3719e0b86b53de2c27d070002e3d927a001149672a2fb56a6a0 |
| hovercard-subject-tag | pull_request:918635544 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/22895/files |
| twitter:image | https://avatars.githubusercontent.com/u/2836374?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2836374?s=400&v=4 |
| og:image:alt | Alternative to #18854. Basic idea: The canvas feels like it should be a relatively simple widget class and not have to care about the logic of creating a manager. Still we want canvas.new_manager(... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fbd8fce4d63ac394c5405faa20aa50d5c9e56b979ac43ee1b26f8e7c47c4cd89 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 811f50b757204c6a1b4da0ea780075b3e1cc9e57 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width