| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e4d6d548-f254-7ac7-acb4-7770473132be |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB46:F8982:FB4E54:153AFB9:6A533377 |
| html-safe-nonce | 653672174202950f98f32e7382b2e5811e164041c47f8c5b056f1caa67b0db11 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjQ2OkY4OTgyOkZCNEU1NDoxNTNBRkI5OjZBNTMzMzc3IiwidmlzaXRvcl9pZCI6IjIxMjE2OTE2MTUyNTcxMTM0NjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 740a5038569a5fb16fc97e22b605f3388a8754ed565454490b95a7b7bea698c9 |
| hovercard-subject-tag | pull_request:918635544 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/22895/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3075c2e94c156a4febf5fa7f51680c992795105d2ff83b452b085967f3f8b372/matplotlib/matplotlib/pull/22895 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3075c2e94c156a4febf5fa7f51680c992795105d2ff83b452b085967f3f8b372/matplotlib/matplotlib/pull/22895 |
| og:image:alt | Alternative to #18854.
Basic idea:
The canvas feels like it should be a relatively simple widget class and not have to care about the logic of creating a manager.
Still we want canvas.new_manager(... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | timhoffm |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/22895#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22895 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22895 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/22895 |
| Reload | https://github.com/matplotlib/matplotlib/pull/22895 |
| Reload | https://github.com/matplotlib/matplotlib/pull/22895 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| timhoffm | https://github.com/timhoffm |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| timhoffm:uniform-manager-creation-thof | https://github.com/timhoffm/matplotlib/tree/uniform-manager-creation-thof |
| Conversation | https://github.com/matplotlib/matplotlib/pull/22895 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/22895/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/22895/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/22895/files |
| Alternative approach to organizing uniform manager creation | https://github.com/matplotlib/matplotlib/pull/22895#top |
| timhoffm | https://github.com/timhoffm |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| timhoffm:uniform-manager-creation-thof | https://github.com/timhoffm/matplotlib/tree/uniform-manager-creation-thof |
|
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| Apr 25, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issue-1215052031 |
| #18854 | https://github.com/matplotlib/matplotlib/pull/18854 |
| #18854 | https://github.com/matplotlib/matplotlib/pull/18854 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
|
| https://github.com/anntzer |
| Standardize creation of FigureManager from a given FigureCanvas class. | https://github.com/matplotlib/matplotlib/pull/22895/commits/8bb2bb145de6d57d3c9da9a2fbf72c02d91df498 |
| 8bb2bb1 | https://github.com/matplotlib/matplotlib/pull/22895/commits/8bb2bb145de6d57d3c9da9a2fbf72c02d91df498 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| April 25, 2022 21:14 | https://github.com/matplotlib/matplotlib/pull/22895#event-6493658648 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Apr 25, 2022
| https://github.com/matplotlib/matplotlib/pull/22895#ref-pullrequest-733709505 |
|
Standardize creation of FigureManager from a given FigureCanvas class.
#18854
| https://github.com/matplotlib/matplotlib/pull/18854 |
|
| https://github.com/timhoffm |
| Rewrite manager creation [skip ci] | https://github.com/matplotlib/matplotlib/pull/22895/commits/645204f9c8e1d4fc2b563ae5c0b646d2ce38ad41 |
| 645204f | https://github.com/matplotlib/matplotlib/pull/22895/commits/645204f9c8e1d4fc2b563ae5c0b646d2ce38ad41 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/9288a0cea372c9961107b29b9a7fd6b0b3e9da9d..645204f9c8e1d4fc2b563ae5c0b646d2ce38ad41 |
| 9288a0c | https://github.com/matplotlib/matplotlib/commit/9288a0cea372c9961107b29b9a7fd6b0b3e9da9d |
| 645204f | https://github.com/matplotlib/matplotlib/commit/645204f9c8e1d4fc2b563ae5c0b646d2ce38ad41 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/9288a0cea372c9961107b29b9a7fd6b0b3e9da9d..645204f9c8e1d4fc2b563ae5c0b646d2ce38ad41 |
| April 25, 2022 21:16 | https://github.com/matplotlib/matplotlib/pull/22895#event-6493672122 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Apr 26, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1110122240 |
| #18854 | https://github.com/matplotlib/matplotlib/pull/18854 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| Apr 26, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1110236796 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Apr 27, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1111000533 |
| @tacaswell | https://github.com/tacaswell |
| #18854 | https://github.com/matplotlib/matplotlib/pull/18854 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Apr 28, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1111727138 |
| @anntzer | https://github.com/anntzer |
| ouroborus | https://en.wikipedia.org/wiki/Ouroboros |
| #18854 | https://github.com/matplotlib/matplotlib/pull/18854 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Apr 28, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1111870307 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Apr 28, 2022
| https://github.com/matplotlib/matplotlib/pull/22895#ref-pullrequest-1218392902 |
|
Standardize creation of FigureManager from a given FigureCanvas class.
#22925
| https://github.com/matplotlib/matplotlib/pull/22925 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Apr 28, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1112272278 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| Apr 28, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1112351148 |
| @tacaswell | https://github.com/tacaswell |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Apr 28, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1112713228 |
| @tacaswell | https://github.com/tacaswell |
| #18854 (comment) | https://github.com/matplotlib/matplotlib/pull/18854#issuecomment-1101830468 |
| matplotlib/ipympl#305 | https://github.com/matplotlib/ipympl/pull/305 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Apr 28, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1112715859 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Apr 28, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1112720980 |
| #18854 (comment) | https://github.com/matplotlib/matplotlib/pull/18854#issuecomment-1029470655 |
| #18854 (comment) | https://github.com/matplotlib/matplotlib/pull/18854#issuecomment-1101784955 |
| #22895 (comment) | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1111727138 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Apr 29, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1112856818 |
| https://user-images.githubusercontent.com/199813/165883603-93313339-6303-4cf2-bfe7-975787368e3e.svg |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| May 1, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#issuecomment-1114282930 |
| #22925 | https://github.com/matplotlib/matplotlib/pull/22925 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| May 1, 2022 | https://github.com/matplotlib/matplotlib/pull/22895#event-6529785219 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| July 19, 2024 11:34 | https://github.com/matplotlib/matplotlib/pull/22895#event-13572924976 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22895 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22895 |
|
| https://github.com/timhoffm |
|
| https://github.com/anntzer |
|
| https://github.com/tacaswell |
|
| https://github.com/jklymak |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |