René's URL Explorer Experiment


Title: Tweak argument checking in tripcolor(). by anntzer · Pull Request #22883 · matplotlib/matplotlib · GitHub

Open Graph Title: Tweak argument checking in tripcolor(). by anntzer · Pull Request #22883 · matplotlib/matplotlib

X Title: Tweak argument checking in tripcolor(). by anntzer · Pull Request #22883 · matplotlib/matplotlib

Description: For incorrect number of parameters, switch to raising a (standard) TypeError and use a standard-ish signature mismatch error message. Note that exception type stability was already broken in 3.6 because it was previously an IndexError (that was triggered later) and 703b574 changed that to a ValueError. Also deprecate support for passing extra parameters (as we now tend to do for all such overly accepting APIs). Note that the changelog entry states that such parameters were previously silently ignored, even though the patch replaces a warn_external() by a warn_deprecated(); this is simply because the warn_external() wasn't present yet in the last released version. Also closes #22882. PR Summary PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).

Open Graph Description: For incorrect number of parameters, switch to raising a (standard) TypeError and use a standard-ish signature mismatch error message. Note that exception type stability was already broken in 3.6 b...

X Description: For incorrect number of parameters, switch to raising a (standard) TypeError and use a standard-ish signature mismatch error message. Note that exception type stability was already broken in 3.6 b...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/22883

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:415c82d2-068d-3173-f1a4-3da6472129de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A08:C7E79:5303668:7486A40:6A5711EF
html-safe-nonce3ddd24856238c7c49c18cfb4dae62f21b7dad125a0153fc6f2c1637e2846a50b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTA4OkM3RTc5OjUzMDM2Njg6NzQ4NkE0MDo2QTU3MTFFRiIsInZpc2l0b3JfaWQiOiIzNzY5NDMzNDYzMDYyOTkxMzQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9e43c0867c6d9b02f8e83e2f6eb9cb954b31f928328af63c578e7cae418f906a
hovercard-subject-tagpull_request:917314404
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/22883/files
twitter:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
og:image:altFor incorrect number of parameters, switch to raising a (standard) TypeError and use a standard-ish signature mismatch error message. Note that exception type stability was already broken in 3.6 b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2576d1f0198cf1588faf2edf27f1ed120903be10
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/22883/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22883%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22883%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/22883/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/22883/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/22883/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22883/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22883/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
oscargushttps://github.com/oscargus
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
anntzer:tcahttps://github.com/anntzer/matplotlib/tree/tca
Conversation 3 https://github.com/matplotlib/matplotlib/pull/22883
Commits 1 https://github.com/matplotlib/matplotlib/pull/22883/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/22883/checks
Files changed https://github.com/matplotlib/matplotlib/pull/22883/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22883/files
Tweak argument checking in tripcolor(). https://github.com/matplotlib/matplotlib/pull/22883/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/22883/files
7db1913 Tweak argument checking in tripcolor(). anntzer Apr 23, 2022 https://github.com/matplotlib/matplotlib/pull/22883/commits/7db1913a9c37dc4497ffa8d807a6f6591193432a
Clear filters https://github.com/matplotlib/matplotlib/pull/22883/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22883/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22883/files
22883-AL.rst https://github.com/matplotlib/matplotlib/pull/22883/files#diff-715753917ab7fc0fcbd915609275c97d5072a974aef70bbdc595c7239121ec14
test_triangulation.py https://github.com/matplotlib/matplotlib/pull/22883/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
tripcolor.py https://github.com/matplotlib/matplotlib/pull/22883/files#diff-3b9b38ac80e18a0a6aee5f2a7d6a9a75b1ec24554193edd537af3167e8a18bf5
doc/api/next_api_changes/deprecations/22883-AL.rsthttps://github.com/matplotlib/matplotlib/pull/22883/files#diff-715753917ab7fc0fcbd915609275c97d5072a974aef70bbdc595c7239121ec14
View file https://github.com/anntzer/matplotlib/blob/7db1913a9c37dc4497ffa8d807a6f6591193432a/doc/api/next_api_changes/deprecations/22883-AL.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/22883/{{ revealButtonHref }}
lib/matplotlib/tests/test_triangulation.pyhttps://github.com/matplotlib/matplotlib/pull/22883/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
View file https://github.com/anntzer/matplotlib/blob/7db1913a9c37dc4497ffa8d807a6f6591193432a/lib/matplotlib/tests/test_triangulation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/22883/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/22883/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
https://github.com/matplotlib/matplotlib/pull/22883/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
https://github.com/matplotlib/matplotlib/pull/22883/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
https://github.com/matplotlib/matplotlib/pull/22883/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
lib/matplotlib/tri/tripcolor.pyhttps://github.com/matplotlib/matplotlib/pull/22883/files#diff-3b9b38ac80e18a0a6aee5f2a7d6a9a75b1ec24554193edd537af3167e8a18bf5
View file https://github.com/anntzer/matplotlib/blob/7db1913a9c37dc4497ffa8d807a6f6591193432a/lib/matplotlib/tri/tripcolor.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/22883/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/22883/files#diff-3b9b38ac80e18a0a6aee5f2a7d6a9a75b1ec24554193edd537af3167e8a18bf5
https://github.com/matplotlib/matplotlib/pull/22883/files#diff-3b9b38ac80e18a0a6aee5f2a7d6a9a75b1ec24554193edd537af3167e8a18bf5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.