Title: bugfix: scaling of windows with negative coefficients by lucasisonline · Pull Request #22828 · matplotlib/matplotlib · GitHub
Open Graph Title: bugfix: scaling of windows with negative coefficients by lucasisonline · Pull Request #22828 · matplotlib/matplotlib
X Title: bugfix: scaling of windows with negative coefficients by lucasisonline · Pull Request #22828 · matplotlib/matplotlib
Description: PR Summary The magnitude scaling is incorrect for windows with negative coefficients. For proper scaling of the magnitude a division by the sum of all window elements is needed. To be able to handle complex window coefficients an abs() was introduced in 76c4d84 which falsifies the scaling for windows with negative coefficients. Most prominently the flattop window. A proper type check is introduced to handle both cases correctly. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).
Open Graph Description: PR Summary The magnitude scaling is incorrect for windows with negative coefficients. For proper scaling of the magnitude a division by the sum of all window elements is needed. To be able to handl...
X Description: PR Summary The magnitude scaling is incorrect for windows with negative coefficients. For proper scaling of the magnitude a division by the sum of all window elements is needed. To be able to handl...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/22828
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1eae3b2d-80d5-401b-94a9-7ff91d54ee81 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D352:13BA54:AE2A814:B1856A1:6A50B836 |
| html-safe-nonce | 17eca63e26b6394b8375b021ca0a0edb9c989a5e5fd9974a978418e104c3c2f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzUyOjEzQkE1NDpBRTJBODE0OkIxODU2QTE6NkE1MEI4MzYiLCJ2aXNpdG9yX2lkIjoiNzA1NjIzMDQ5MjgyODM4MzI4NiIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9 |
| visitor-hmac | 459330453578fa4df81fca5dd7b7bb07d27ec5b89374344bea65ac8eedb5cce3 |
| hovercard-subject-tag | pull_request:906461645 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/22828/files |
| twitter:image | https://avatars.githubusercontent.com/u/79363158?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/79363158?s=400&v=4 |
| og:image:alt | PR Summary The magnitude scaling is incorrect for windows with negative coefficients. For proper scaling of the magnitude a division by the sum of all window elements is needed. To be able to handl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 63772747707af4093f0d5fc7aa1bb3bb55f412a9865207c4f421aa34c64cc404 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ded53fe94e3ff1bb4dbf8cc77e285396c92580fb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width