Title: Fix configure_subplots with tool manager by QuLogic · Pull Request #22743 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix configure_subplots with tool manager by QuLogic · Pull Request #22743 · matplotlib/matplotlib
X Title: Fix configure_subplots with tool manager by QuLogic · Pull Request #22743 · matplotlib/matplotlib
Description: PR Summary configure_subplots requires a) an object from which it can get the canvas property, and b) somewhere it can store its handle for re-use. The pseudo-toolbar that is used for most Tool classes is temporary and does not provide the latter. However, tools inherit from ToolBase which contains a canvas property and they exist for the lifetime of the toolbar, so can be used instead. Fixes #22088 PR Checklist Tests and Styling [n/a] Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation [n/a] New features are documented, with examples if plot related. [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).
Open Graph Description: PR Summary configure_subplots requires a) an object from which it can get the canvas property, and b) somewhere it can store its handle for re-use. The pseudo-toolbar that is used for most Tool cla...
X Description: PR Summary configure_subplots requires a) an object from which it can get the canvas property, and b) somewhere it can store its handle for re-use. The pseudo-toolbar that is used for most Tool cla...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/22743
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9d349a9b-1852-74ed-890a-cec12dbe1ea4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B044:29B0B8:CB4EA5:1247767:6A5891B2 |
| html-safe-nonce | 840188571e15d2e07f45ecfd186f0bb9962c1d72ab8e9513aeb1041fb848d324 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDQ0OjI5QjBCODpDQjRFQTU6MTI0Nzc2Nzo2QTU4OTFCMiIsInZpc2l0b3JfaWQiOiIyMjI3MjkyNjExODE5Mzc3MDc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 59de8290b09667431dc9d80d4919426ff89dcdf8ab05d4d79cfaca6517443d8b |
| hovercard-subject-tag | pull_request:895481971 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/22743/files |
| twitter:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| og:image:alt | PR Summary configure_subplots requires a) an object from which it can get the canvas property, and b) somewhere it can store its handle for re-use. The pseudo-toolbar that is used for most Tool cla... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width