Title: Fix Path/str-discrepancy in FontManager.addpath and improve documentation by oscargus · Pull Request #22591 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix Path/str-discrepancy in FontManager.addpath and improve documentation by oscargus · Pull Request #22591 · matplotlib/matplotlib
X Title: Fix Path/str-discrepancy in FontManager.addpath and improve documentation by oscargus · Pull Request #22591 · matplotlib/matplotlib
Description: PR Summary Closes #22582 Closes #22586 Always convert input to str first. Also update the documentation a bit. Cannot really see how this can be tested as I do not know of any ttf-font locations on the CI... Edit: I found a ttf-font in the test data, so at least it should be possible to test passing a Path without errors. Edit 2: Test added. Also added a validation function for font.stretch, so now rcParam-values can also be ints. Kept it as four separate commits, but can of course merge to a single. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).
Open Graph Description: PR Summary Closes #22582 Closes #22586 Always convert input to str first. Also update the documentation a bit. Cannot really see how this can be tested as I do not know of any ttf-font locations on...
X Description: PR Summary Closes #22582 Closes #22586 Always convert input to str first. Also update the documentation a bit. Cannot really see how this can be tested as I do not know of any ttf-font locations on...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/22591
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:07253603-1b61-015a-e63c-a98466d12aba |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA6C:29BECE:198D51F:21C81F3:6A51D62D |
| html-safe-nonce | 3e421d3a01f185a6ac943a2ebd756e7d4f45972ca35bd6db603621b4c414abc2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTZDOjI5QkVDRToxOThENTFGOjIxQzgxRjM6NkE1MUQ2MkQiLCJ2aXNpdG9yX2lkIjoiMjUwNDg5NzIyMTcwMDQ3NDQxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a4fa6dea034d11673bdc9a53138d9ae6dec7abe6b794f481c1def1e5a8a5726c |
| hovercard-subject-tag | pull_request:870880405 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/22591/files |
| twitter:image | https://avatars.githubusercontent.com/u/8114497?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8114497?s=400&v=4 |
| og:image:alt | PR Summary Closes #22582 Closes #22586 Always convert input to str first. Also update the documentation a bit. Cannot really see how this can be tested as I do not know of any ttf-font locations on... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width