René's URL Explorer Experiment


Title: Cleanup tripcolor() by timhoffm · Pull Request #22356 · matplotlib/matplotlib · GitHub

Open Graph Title: Cleanup tripcolor() by timhoffm · Pull Request #22356 · matplotlib/matplotlib

X Title: Cleanup tripcolor() by timhoffm · Pull Request #22356 · matplotlib/matplotlib

Description: PR Summary Commits: Rewrite Triangulation.get_from_args_and_kwargs to make parameter parsing testable; and add tests. Warn when passing triangles or mask alongside a Triangulation to tripcolor() Cleanup logic and documentation of tripcolor() This issues additional warnings and more precise error messages but does not change behavior. The only "semantic" change is that I have discouraged passing triangles positionally: tripcolor(x, y, triangles, C) is a bit odd and IMHO has too many positional arguments. Closes #22303. Follows up on #10148.

Open Graph Description: PR Summary Commits: Rewrite Triangulation.get_from_args_and_kwargs to make parameter parsing testable; and add tests. Warn when passing triangles or mask alongside a Triangulation to tripcolor() C...

X Description: PR Summary Commits: Rewrite Triangulation.get_from_args_and_kwargs to make parameter parsing testable; and add tests. Warn when passing triangles or mask alongside a Triangulation to tripcolor() C...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/22356

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3f01ce0c-afb8-5de9-9144-31b079e289c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9532:19D388:45C0ED8:625D886:6A56E598
html-safe-noncebb383b7afdb88b68acd7f67ce59635c8d3a1550dc7fefd5c890a4cb5243bd6b6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTMyOjE5RDM4ODo0NUMwRUQ4OjYyNUQ4ODY6NkE1NkU1OTgiLCJ2aXNpdG9yX2lkIjoiNTI3OTg4MDgzODk3MzI5MDQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac756b0f844bd1eb862dcef933bc0039a4f259c6eb4f1f46d6e5a7a787e3c97931
hovercard-subject-tagpull_request:835228351
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/22356/files
twitter:imagehttps://avatars.githubusercontent.com/u/2836374?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2836374?s=400&v=4
og:image:altPR Summary Commits: Rewrite Triangulation.get_from_args_and_kwargs to make parameter parsing testable; and add tests. Warn when passing triangles or mask alongside a Triangulation to tripcolor() C...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5220a278731283038daf0ed00b41f06ef7ff9539020ecc806c5c5a0fb6bda25a
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8684ae1a81cd3e4ef219b241179982bbda1a5b1f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/22356/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22356%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22356%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/22356/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/22356/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/22356/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22356/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22356/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
QuLogichttps://github.com/QuLogic
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
timhoffm:triplothttps://github.com/timhoffm/matplotlib/tree/triplot
Conversation 12 https://github.com/matplotlib/matplotlib/pull/22356
Commits 3 https://github.com/matplotlib/matplotlib/pull/22356/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/22356/checks
Files changed https://github.com/matplotlib/matplotlib/pull/22356/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22356/files
Cleanup tripcolor() https://github.com/matplotlib/matplotlib/pull/22356/files#top
Show all changes 3 commits https://github.com/matplotlib/matplotlib/pull/22356/files
aef5bd6 Rewrite Triangulation.get_from_args_and_kwargs to make parameter pars… timhoffm Jan 29, 2022 https://github.com/matplotlib/matplotlib/pull/22356/commits/aef5bd66f1583f24ae18c8c2e3ac1290aff9ab48
39cfe2b Warn when passing triangles or mask alongside a Triangulation timhoffm Jan 29, 2022 https://github.com/matplotlib/matplotlib/pull/22356/commits/39cfe2b94eb46db86507d68771d832034667dfd7
703b574 Cleanup logic and documentation of tripcolor timhoffm Jan 29, 2022 https://github.com/matplotlib/matplotlib/pull/22356/commits/703b57495891702441e5da0326473f76909f5df8
Clear filters https://github.com/matplotlib/matplotlib/pull/22356/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22356/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22356/files
test_triangulation.py https://github.com/matplotlib/matplotlib/pull/22356/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
triangulation.py https://github.com/matplotlib/matplotlib/pull/22356/files#diff-32a240e1e015c706cbe28492bc047caf648c6fa107c26d10e9a49bdd1cf58c38
tripcolor.py https://github.com/matplotlib/matplotlib/pull/22356/files#diff-3b9b38ac80e18a0a6aee5f2a7d6a9a75b1ec24554193edd537af3167e8a18bf5
lib/matplotlib/tests/test_triangulation.pyhttps://github.com/matplotlib/matplotlib/pull/22356/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
View file https://github.com/timhoffm/matplotlib/blob/703b57495891702441e5da0326473f76909f5df8/lib/matplotlib/tests/test_triangulation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/22356/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-15c9ff255d83cac014750485807a651e878fd405ad6bc945abebfea0514bff6a
lib/matplotlib/tri/triangulation.pyhttps://github.com/matplotlib/matplotlib/pull/22356/files#diff-32a240e1e015c706cbe28492bc047caf648c6fa107c26d10e9a49bdd1cf58c38
View file https://github.com/timhoffm/matplotlib/blob/703b57495891702441e5da0326473f76909f5df8/lib/matplotlib/tri/triangulation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/22356/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-32a240e1e015c706cbe28492bc047caf648c6fa107c26d10e9a49bdd1cf58c38
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-32a240e1e015c706cbe28492bc047caf648c6fa107c26d10e9a49bdd1cf58c38
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-32a240e1e015c706cbe28492bc047caf648c6fa107c26d10e9a49bdd1cf58c38
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-32a240e1e015c706cbe28492bc047caf648c6fa107c26d10e9a49bdd1cf58c38
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-32a240e1e015c706cbe28492bc047caf648c6fa107c26d10e9a49bdd1cf58c38
https://github.com/matplotlib/matplotlib/pull/22356/files#diff-32a240e1e015c706cbe28492bc047caf648c6fa107c26d10e9a49bdd1cf58c38
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/22356/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.