Title: FIX: ensure that used sub-packages are actually imported by tacaswell · Pull Request #22306 · matplotlib/matplotlib · GitHub
Open Graph Title: FIX: ensure that used sub-packages are actually imported by tacaswell · Pull Request #22306 · matplotlib/matplotlib
X Title: FIX: ensure that used sub-packages are actually imported by tacaswell · Pull Request #22306 · matplotlib/matplotlib
Description: PR Summary closes #22305 We were relying on an implicit import of a sub-module. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). We could test this by adding a sub-process test, but I am not sure that it is worth it. That said, if someone wants a test on this I will add it.
Open Graph Description: PR Summary closes #22305 We were relying on an implicit import of a sub-module. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install fla...
X Description: PR Summary closes #22305 We were relying on an implicit import of a sub-module. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install fla...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/22306
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a481ddc7-ae5f-7a62-7143-bc88ea8e19d2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9752:2CAF25:AD819:E3F49:6A52BE2F |
| html-safe-nonce | 23ef6de0e01f7c6f073ed4252bef8d0742d9983eec81ac325f123b677f91e039 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzUyOjJDQUYyNTpBRDgxOTpFM0Y0OTo2QTUyQkUyRiIsInZpc2l0b3JfaWQiOiI3ODM0MTY1MDYzMTkwMjc3NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1c45d4b4f7089382b404f0f0f1b06473f584491b1568bc40ce0f63a907b2b12e |
| hovercard-subject-tag | pull_request:830792237 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/22306/files |
| twitter:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| og:image:alt | PR Summary closes #22305 We were relying on an implicit import of a sub-module. PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install fla... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width