| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1573f994-6a5f-bc81-f09d-7a2b49d52b88 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A848:36BF0F:30916B:44C512:6A50F647 |
| html-safe-nonce | d6611c5a0f02eabb7a24fd91a47727a87702a60d3233971664cad5a872033d77 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODQ4OjM2QkYwRjozMDkxNkI6NDRDNTEyOjZBNTBGNjQ3IiwidmlzaXRvcl9pZCI6Ijg1OTg0NzQwMzY3NDAxNTkwNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f4ad108af6454af7727c462933476f1bbf9afd116b7e90b052a9c950a70f5756 |
| hovercard-subject-tag | pull_request:817229069 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/22180/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/40a83cd462ae1c8e718f76e83257fe6b8cd1b17dbfbdcf0f875ae6f4b9ba5c25/matplotlib/matplotlib/pull/22180 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/40a83cd462ae1c8e718f76e83257fe6b8cd1b17dbfbdcf0f875ae6f4b9ba5c25/matplotlib/matplotlib/pull/22180 |
| og:image:alt | PR Summary
This adds the rcParams savefig.directory option into the macosx
backend for the savefig dialog window.
Additionally cleans up some of the UTF8 string allocations in this code block.
Clos... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | greglucas |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838 |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8d836581d020676cc0ef4a83cd2fe17e4af02c3d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/22180#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22180 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22180 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/22180 |
| Reload | https://github.com/matplotlib/matplotlib/pull/22180 |
| Reload | https://github.com/matplotlib/matplotlib/pull/22180 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
410
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| jklymak | https://github.com/jklymak |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| greglucas:macosx-savefig | https://github.com/greglucas/matplotlib/tree/macosx-savefig |
| Conversation | https://github.com/matplotlib/matplotlib/pull/22180 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/22180/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/22180/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/22180/files |
| ENH: Use rcParams savefig.directory on macosx backend | https://github.com/matplotlib/matplotlib/pull/22180#top |
| jklymak | https://github.com/jklymak |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| greglucas:macosx-savefig | https://github.com/greglucas/matplotlib/tree/macosx-savefig |
|
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| Jan 10, 2022 | https://github.com/matplotlib/matplotlib/pull/22180#issue-1097444424 |
| #21710 | https://github.com/matplotlib/matplotlib/issues/21710 |
| Flake 8 | https://flake8.pycqa.org/en/latest/ |
| build | https://matplotlib.org/devel/documenting_mpl.html#building-the-docs |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
|
GUI: MacOSX
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20MacOSX%22 |
| Jan 10, 2022 | https://github.com/matplotlib/matplotlib/pull/22180#event-5863416824 |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| v3.6.0 | https://github.com/matplotlib/matplotlib/milestone/65 |
| Jan 10, 2022 | https://github.com/matplotlib/matplotlib/pull/22180#event-5863416826 |
| https://github.com/dstansby |
| dstansby | https://github.com/dstansby |
|
Jan 10, 2022
| https://github.com/matplotlib/matplotlib/pull/22180#pullrequestreview-847591033 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/22180/files |
| lib/matplotlib/backends/backend_macosx.py | https://github.com/matplotlib/matplotlib/pull/22180/files#diff-fa0b9840f8945ba1ad40628be14617bd8d2f06a3e8c1e2791e5d8e60799488e0 |
| dstansby | https://github.com/dstansby |
| Jan 10, 2022 | https://github.com/matplotlib/matplotlib/pull/22180#discussion_r781039981 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
| greglucas | https://github.com/greglucas |
| Jan 10, 2022 | https://github.com/matplotlib/matplotlib/pull/22180#discussion_r781241230 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
| greglucas | https://github.com/greglucas |
| Jan 10, 2022 | https://github.com/matplotlib/matplotlib/pull/22180#discussion_r781286483 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/647451d6f9b547fddbc2e1144523453341fe3adf..bd7d627e18928facb5bc0b2671c4e08219069508 |
| 647451d | https://github.com/matplotlib/matplotlib/commit/647451d6f9b547fddbc2e1144523453341fe3adf |
| bd7d627 | https://github.com/matplotlib/matplotlib/commit/bd7d627e18928facb5bc0b2671c4e08219069508 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/647451d6f9b547fddbc2e1144523453341fe3adf..bd7d627e18928facb5bc0b2671c4e08219069508 |
| January 10, 2022 16:25 | https://github.com/matplotlib/matplotlib/pull/22180#event-5867205230 |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| dstansby | https://github.com/dstansby |
| March 5, 2022 18:17 | https://github.com/matplotlib/matplotlib/pull/22180#event-6189727024 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Mar 8, 2022
| https://github.com/matplotlib/matplotlib/pull/22180#pullrequestreview-902755467 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/22180/files |
| lib/matplotlib/tests/test_backend_macosx.py | https://github.com/matplotlib/matplotlib/pull/22180/files#diff-d995c2455fc40d708d905f0ecaba3e207a377a38bac0d8883e2474825f14af9f |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
|
| https://github.com/greglucas |
| ENH: Use rcParams savefig.directory on macosx backend | https://github.com/matplotlib/matplotlib/pull/22180/commits/326ea1a82fc5a528c42e7df8050ffb61df79a586 |
| 326ea1a | https://github.com/matplotlib/matplotlib/pull/22180/commits/326ea1a82fc5a528c42e7df8050ffb61df79a586 |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/bd7d627e18928facb5bc0b2671c4e08219069508..9ed0a309b953455691982e9dabeaca33e830f075 |
| bd7d627 | https://github.com/matplotlib/matplotlib/commit/bd7d627e18928facb5bc0b2671c4e08219069508 |
| 9ed0a30 | https://github.com/matplotlib/matplotlib/commit/9ed0a309b953455691982e9dabeaca33e830f075 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/bd7d627e18928facb5bc0b2671c4e08219069508..9ed0a309b953455691982e9dabeaca33e830f075 |
| March 8, 2022 14:19 | https://github.com/matplotlib/matplotlib/pull/22180#event-6202827274 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Mar 9, 2022
| https://github.com/matplotlib/matplotlib/pull/22180#pullrequestreview-905062728 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/22180/files |
| lib/matplotlib/tests/test_backend_macosx.py | https://github.com/matplotlib/matplotlib/pull/22180/files#diff-d995c2455fc40d708d905f0ecaba3e207a377a38bac0d8883e2474825f14af9f |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
|
| https://github.com/greglucas |
| TST: macosx savefig respects rcParam setting | https://github.com/matplotlib/matplotlib/pull/22180/commits/15afb443460fcc1ef1de672622ca8b02377ac08f |
| 15afb44 | https://github.com/matplotlib/matplotlib/pull/22180/commits/15afb443460fcc1ef1de672622ca8b02377ac08f |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/9ed0a309b953455691982e9dabeaca33e830f075..15afb443460fcc1ef1de672622ca8b02377ac08f |
| 9ed0a30 | https://github.com/matplotlib/matplotlib/commit/9ed0a309b953455691982e9dabeaca33e830f075 |
| 15afb44 | https://github.com/matplotlib/matplotlib/commit/15afb443460fcc1ef1de672622ca8b02377ac08f |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/9ed0a309b953455691982e9dabeaca33e830f075..15afb443460fcc1ef1de672622ca8b02377ac08f |
| March 9, 2022 23:00 | https://github.com/matplotlib/matplotlib/pull/22180#event-6213596690 |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| Apr 10, 2022 | https://github.com/matplotlib/matplotlib/pull/22180#issuecomment-1094289455 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Apr 11, 2022
| https://github.com/matplotlib/matplotlib/pull/22180#pullrequestreview-938684352 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/22180/files/15afb443460fcc1ef1de672622ca8b02377ac08f |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
| May 15, 2022 | https://github.com/matplotlib/matplotlib/pull/22180#issuecomment-1126946645 |
| @dstansby | https://github.com/dstansby |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
May 18, 2022
| https://github.com/matplotlib/matplotlib/pull/22180#pullrequestreview-976447794 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/22180/files/15afb443460fcc1ef1de672622ca8b02377ac08f |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| dd001ed | https://github.com/matplotlib/matplotlib/commit/dd001edbbaccc45d0e2b0671321a1e8c69115565 |
| May 18, 2022 | https://github.com/matplotlib/matplotlib/pull/22180#event-6629706281 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Sep 9, 2022
| https://github.com/matplotlib/matplotlib/pull/22180#ref-pullrequest-1364203791 |
|
Consolidate release notes for 3.6
#23814
| https://github.com/matplotlib/matplotlib/pull/23814 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22180 |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/22180/files/9ed0a309b953455691982e9dabeaca33e830f075 |
|
| https://github.com/tacaswell |
|
tacaswell
| https://github.com/tacaswell |
|
| https://github.com/matplotlib/matplotlib/pull/22180/files/15afb443460fcc1ef1de672622ca8b02377ac08f |
|
| https://github.com/jklymak |
|
jklymak
| https://github.com/jklymak |
|
| https://github.com/matplotlib/matplotlib/pull/22180/files/15afb443460fcc1ef1de672622ca8b02377ac08f |
|
| https://github.com/dstansby |
|
dstansby
| https://github.com/dstansby |
|
GUI: MacOSX
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20MacOSX%22 |
|
v3.6.0
| https://github.com/matplotlib/matplotlib/milestone/65 |
|
[ENH]: macosx backend does not respect rcParams["savefig.directory"]
| https://github.com/matplotlib/matplotlib/issues/21710 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22180 |
|
| https://github.com/greglucas |
|
| https://github.com/tacaswell |
|
| https://github.com/QuLogic |
|
| https://github.com/jklymak |
|
| https://github.com/dstansby |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |