| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e7a70f31-4c68-aae0-9553-9641456257f9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A488:22A933:75CB2:A0EE1:6A52755A |
| html-safe-nonce | d832c603da6e322d4eb46760046685a8b126c1bf9dcdcafbf17f29597bc0933e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDg4OjIyQTkzMzo3NUNCMjpBMEVFMTo2QTUyNzU1QSIsInZpc2l0b3JfaWQiOiIxNzY2NDAwMjgwMDQ0ODAzNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d77af00429a8a6a7a22c281fe2bac54e37b89344fd278aa77d1c0955867c73f6 |
| hovercard-subject-tag | pull_request:813068804 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/22089/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/edcd3579bb7827f4ca6f590fa3f00a766c7acfdd5dc36deb23c7c0ef84bb91a6/matplotlib/matplotlib/pull/22089 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/edcd3579bb7827f4ca6f590fa3f00a766c7acfdd5dc36deb23c7c0ef84bb91a6/matplotlib/matplotlib/pull/22089 |
| og:image:alt | PR Summary
Closes #22085
I guess I'm not 100% sure why the old code breaks, but this new code does not leak memory.
Tested via
import matplotlib.pyplot as plt
from matplotlib import colorbar
im... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jklymak |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/22089#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22089 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22089 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/22089 |
| Reload | https://github.com/matplotlib/matplotlib/pull/22089 |
| Reload | https://github.com/matplotlib/matplotlib/pull/22089 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22089 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22089 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| tacaswell | https://github.com/tacaswell |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| jklymak:fix-memleak-make-colorbar | https://github.com/jklymak/matplotlib/tree/fix-memleak-make-colorbar |
| Conversation | https://github.com/matplotlib/matplotlib/pull/22089 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/22089/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/22089/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/22089/files |
| FIX: squash memory leak in colorbar | https://github.com/matplotlib/matplotlib/pull/22089#top |
| tacaswell | https://github.com/tacaswell |
| matplotlib:main | https://github.com/matplotlib/matplotlib/tree/main |
| jklymak:fix-memleak-make-colorbar | https://github.com/jklymak/matplotlib/tree/fix-memleak-make-colorbar |
|
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Jan 3, 2022 | https://github.com/matplotlib/matplotlib/pull/22089#issue-1092420802 |
| #22085 | https://github.com/matplotlib/matplotlib/issues/22085 |
| Flake 8 | https://flake8.pycqa.org/en/latest/ |
| build | https://matplotlib.org/devel/documenting_mpl.html#building-the-docs |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22089 |
|
| https://github.com/jklymak |
| FIX: squash memory leak in colorbar | https://github.com/matplotlib/matplotlib/pull/22089/commits/c20ce5322a0150aa59160513ba55039734cd60a9 |
| c20ce53 | https://github.com/matplotlib/matplotlib/pull/22089/commits/c20ce5322a0150aa59160513ba55039734cd60a9 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
topic: color/colorbar
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20color%2Fcolorbar%22 |
| Jan 3, 2022 | https://github.com/matplotlib/matplotlib/pull/22089#event-5834758003 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| v3.5.2 | https://github.com/matplotlib/matplotlib/milestone/69 |
| Jan 3, 2022 | https://github.com/matplotlib/matplotlib/pull/22089#event-5834758396 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Jan 3, 2022
| https://github.com/matplotlib/matplotlib/pull/22089#pullrequestreview-843047032 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/22089/files/c20ce5322a0150aa59160513ba55039734cd60a9 |
| lib/matplotlib/colorbar.py | https://github.com/matplotlib/matplotlib/pull/22089/files/c20ce5322a0150aa59160513ba55039734cd60a9#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22089 |
|
| https://github.com/jklymak |
|
| https://github.com/timhoffm |
| Fix list creation | https://github.com/matplotlib/matplotlib/pull/22089/commits/c151e71d39d718035e3629b13f652008f54f7971 |
| c151e71 | https://github.com/matplotlib/matplotlib/pull/22089/commits/c151e71d39d718035e3629b13f652008f54f7971 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Jan 4, 2022
| https://github.com/matplotlib/matplotlib/pull/22089#pullrequestreview-843874259 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/22089/files/c151e71d39d718035e3629b13f652008f54f7971 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| 61fa334 | https://github.com/matplotlib/matplotlib/commit/61fa334ea234d665f63c4689b782fddb3c0353a1 |
| Jan 4, 2022 | https://github.com/matplotlib/matplotlib/pull/22089#event-5842631118 |
| https://github.com/apps/lumberbot-app |
| lumberbot-app | https://github.com/apps/lumberbot-app |
| Jan 4, 2022 | https://github.com/matplotlib/matplotlib/pull/22089#issuecomment-1005136112 |
| #22089 | https://github.com/matplotlib/matplotlib/pull/22089 |
| suggest an improvement | https://github.com/MeeseeksBox/MeeseeksDev |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22089 |
| https://github.com/apps/lumberbot-app |
| lumberbot-app | https://github.com/apps/lumberbot-app |
|
Still Needs Manual Backport
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22 |
| Jan 4, 2022 | https://github.com/matplotlib/matplotlib/pull/22089#event-5842631718 |
| tacaswell | https://github.com/tacaswell |
|
Jan 4, 2022
| https://github.com/matplotlib/matplotlib/pull/22089#ref-commit-a093725 |
|
| https://github.com/tacaswell |
| Backport PR | https://github.com/tacaswell/matplotlib/commit/a0937256bd5399be8b3a54171c309ba25ad2eaca |
| matplotlib#22089 | https://github.com/matplotlib/matplotlib/pull/22089 |
| : FIX: squash memory leak in colorbar | https://github.com/tacaswell/matplotlib/commit/a0937256bd5399be8b3a54171c309ba25ad2eaca |
| a093725 | https://github.com/tacaswell/matplotlib/commit/a0937256bd5399be8b3a54171c309ba25ad2eaca |
| matplotlib#22089 | https://github.com/matplotlib/matplotlib/pull/22089 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Jan 4, 2022
| https://github.com/matplotlib/matplotlib/pull/22089#ref-pullrequest-1093795765 |
|
Backport PR #22089: FIX: squash memory leak in colorbar
#22106
| https://github.com/matplotlib/matplotlib/pull/22106 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Still Needs Manual Backport
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22 |
| Jan 4, 2022 | https://github.com/matplotlib/matplotlib/pull/22089#event-5843121183 |
| QuLogic | https://github.com/QuLogic |
|
Jan 4, 2022
| https://github.com/matplotlib/matplotlib/pull/22089#ref-commit-3466dd7 |
|
| https://github.com/QuLogic |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/3466dd7b89908e956a15d61b18f0eb5a64ba14f6 |
| #22106 | https://github.com/matplotlib/matplotlib/pull/22106 |
| from tacaswell/auto-backport-of-pr-22089-on… | https://github.com/matplotlib/matplotlib/commit/3466dd7b89908e956a15d61b18f0eb5a64ba14f6 |
| 3466dd7 | https://github.com/matplotlib/matplotlib/commit/3466dd7b89908e956a15d61b18f0eb5a64ba14f6 |
| #22089 | https://github.com/matplotlib/matplotlib/pull/22089 |
| https://github.com/PiotrStrzelczykX |
| PiotrStrzelczykX | https://github.com/PiotrStrzelczykX |
|
Nov 9, 2022
| https://github.com/matplotlib/matplotlib/pull/22089#ref-pullrequest-1442037809 |
|
Fix: restore make_axes to accept a tuple of axes
#24408
| https://github.com/matplotlib/matplotlib/pull/24408 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| November 9, 2022 19:06 | https://github.com/matplotlib/matplotlib/pull/22089#event-7776482222 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F22089 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/22089/files/c151e71d39d718035e3629b13f652008f54f7971 |
|
topic: color/colorbar
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20color%2Fcolorbar%22 |
|
v3.5.2
| https://github.com/matplotlib/matplotlib/milestone/69 |
|
[Bug]: Memory leak with colorbar.make_axes
| https://github.com/matplotlib/matplotlib/issues/22085 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/22089 |
|
| https://github.com/jklymak |
|
| https://github.com/timhoffm |
|
| https://github.com/tacaswell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |