René's URL Explorer Experiment


Title: Clean up RectangleSelector move code by dstansby · Pull Request #21921 · matplotlib/matplotlib · GitHub

Open Graph Title: Clean up RectangleSelector move code by dstansby · Pull Request #21921 · matplotlib/matplotlib

X Title: Clean up RectangleSelector move code by dstansby · Pull Request #21921 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary I am working towards improving RectangleSelector to allow rotation past +/- 45 degrees. This PR cleans up some of the movement code to: Add a short docstring Add the xy and xy_press var...

X Description: PR Summary I am working towards improving RectangleSelector to allow rotation past +/- 45 degrees. This PR cleans up some of the movement code to: Add a short docstring Add the xy and xy_press var...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/21921

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:11537dca-7bd9-cab5-d65e-ec4ccda34c06
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB56:32DA4C:8DC0CA:BD0F46:6A52AF26
html-safe-noncecdf79a73f2ae18f1a26327df4eac60d63ab1a51be7d01fc49046133bd90b1180
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjU2OjMyREE0Qzo4REMwQ0E6QkQwRjQ2OjZBNTJBRjI2IiwidmlzaXRvcl9pZCI6IjYwNTYxMzk0NDEyMDQ1NDk1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1a41c4362bdaa6dc6d8baf5acb24d1a87dd9537265278affa0b4781354e1e714
hovercard-subject-tagpull_request:800188073
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/21921/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fa2425ebbba78dd6d9fe6b99cc70d150c9339568e4f6e9fa692d3a2acfe16e08/matplotlib/matplotlib/pull/21921
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fa2425ebbba78dd6d9fe6b99cc70d150c9339568e4f6e9fa692d3a2acfe16e08/matplotlib/matplotlib/pull/21921
og:image:altPR Summary I am working towards improving RectangleSelector to allow rotation past +/- 45 degrees. This PR cleans up some of the movement code to: Add a short docstring Add the xy and xy_press var...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedstansby
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/21921#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F21921
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F21921
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/21921
Reloadhttps://github.com/matplotlib/matplotlib/pull/21921
Reloadhttps://github.com/matplotlib/matplotlib/pull/21921
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
timhoffmhttps://github.com/timhoffm
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
dstansby:rect-sel-cleanhttps://github.com/dstansby/matplotlib/tree/rect-sel-clean
Conversationhttps://github.com/matplotlib/matplotlib/pull/21921
Commits2 (2)https://github.com/matplotlib/matplotlib/pull/21921/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/21921/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/21921/files
Clean up RectangleSelector move codehttps://github.com/matplotlib/matplotlib/pull/21921#top
timhoffmhttps://github.com/timhoffm
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
dstansby:rect-sel-cleanhttps://github.com/dstansby/matplotlib/tree/rect-sel-clean
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Dec 10, 2021https://github.com/matplotlib/matplotlib/pull/21921#issue-1077164184
Flake 8https://flake8.pycqa.org/en/latest/
buildhttps://matplotlib.org/devel/documenting_mpl.html#building-the-docs
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
https://github.com/dstansby
Remove un-used variableshttps://github.com/matplotlib/matplotlib/pull/21921/commits/ff8195e131c41275ea7708e1d18297e0f3a43de3
ff8195ehttps://github.com/matplotlib/matplotlib/pull/21921/commits/ff8195e131c41275ea7708e1d18297e0f3a43de3
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
topic: widgets/UI https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20widgets%2FUI%22
Dec 10, 2021https://github.com/matplotlib/matplotlib/pull/21921#event-5749714460
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
ericprehttps://github.com/ericpre
December 10, 2021 19:29https://github.com/matplotlib/matplotlib/pull/21921#event-5749714686
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
v3.6.0https://github.com/matplotlib/matplotlib/milestone/65
Dec 10, 2021https://github.com/matplotlib/matplotlib/pull/21921#event-5749915122
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Dec 10, 2021 https://github.com/matplotlib/matplotlib/pull/21921#pullrequestreview-829323856
View reviewed changes https://github.com/matplotlib/matplotlib/pull/21921/files
lib/matplotlib/widgets.pyhttps://github.com/matplotlib/matplotlib/pull/21921/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
lib/matplotlib/widgets.pyhttps://github.com/matplotlib/matplotlib/pull/21921/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
timhoffmhttps://github.com/timhoffm
Dec 10, 2021https://github.com/matplotlib/matplotlib/pull/21921#discussion_r766979480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
lib/matplotlib/widgets.pyhttps://github.com/matplotlib/matplotlib/pull/21921/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
timhoffmhttps://github.com/timhoffm
Dec 10, 2021https://github.com/matplotlib/matplotlib/pull/21921#discussion_r766983175
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
https://github.com/ericpre
ericprehttps://github.com/ericpre
Dec 11, 2021 https://github.com/matplotlib/matplotlib/pull/21921#pullrequestreview-829521017
View reviewed changes https://github.com/matplotlib/matplotlib/pull/21921/files
ericprehttps://github.com/ericpre
https://github.com/matplotlib/matplotlib/pull/21921#pullrequestreview-829521017
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@timhoffmhttps://github.com/timhoffm
its commentshttps://github.com/matplotlib/matplotlib/pull/21921/files#r766983175
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
https://github.com/dstansby
Cleaner logic in _onmovehttps://github.com/matplotlib/matplotlib/pull/21921/commits/6b3ea86a44c02d4c61348c43b9033d7d1b2e5f90
6b3ea86https://github.com/matplotlib/matplotlib/pull/21921/commits/6b3ea86a44c02d4c61348c43b9033d7d1b2e5f90
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
force-pushedhttps://github.com/matplotlib/matplotlib/compare/ba685b593bb7455dd875942a6d315ca6acc33eaf..6b3ea86a44c02d4c61348c43b9033d7d1b2e5f90
ba685b5https://github.com/matplotlib/matplotlib/commit/ba685b593bb7455dd875942a6d315ca6acc33eaf
6b3ea86https://github.com/matplotlib/matplotlib/commit/6b3ea86a44c02d4c61348c43b9033d7d1b2e5f90
Compare https://github.com/matplotlib/matplotlib/compare/ba685b593bb7455dd875942a6d315ca6acc33eaf..6b3ea86a44c02d4c61348c43b9033d7d1b2e5f90
December 11, 2021 11:09https://github.com/matplotlib/matplotlib/pull/21921#event-5751511636
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Dec 11, 2021https://github.com/matplotlib/matplotlib/pull/21921#issuecomment-991602408
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
https://github.com/ericpre
ericprehttps://github.com/ericpre
Dec 11, 2021 https://github.com/matplotlib/matplotlib/pull/21921#pullrequestreview-829525078
View reviewed changes https://github.com/matplotlib/matplotlib/pull/21921/files/6b3ea86a44c02d4c61348c43b9033d7d1b2e5f90
ericprehttps://github.com/ericpre
https://github.com/matplotlib/matplotlib/pull/21921#pullrequestreview-829525078
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Dec 12, 2021 https://github.com/matplotlib/matplotlib/pull/21921#pullrequestreview-829678968
View reviewed changes https://github.com/matplotlib/matplotlib/pull/21921/files/6b3ea86a44c02d4c61348c43b9033d7d1b2e5f90
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
6e15597https://github.com/matplotlib/matplotlib/commit/6e155972ecb5839c687896b69b4fda6ebf63aa0b
Dec 12, 2021https://github.com/matplotlib/matplotlib/pull/21921#event-5753391416
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
December 13, 2021 11:21https://github.com/matplotlib/matplotlib/pull/21921#event-5756054945
https://github.com/dhomeier
dhomeierhttps://github.com/dhomeier
Dec 13, 2021 https://github.com/matplotlib/matplotlib/pull/21921#ref-pullrequest-1074916844
Fix rotation selector for aspect ratio of the axes values different from 1 #21886 https://github.com/matplotlib/matplotlib/pull/21886
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F21921
https://github.com/timhoffm
timhoffm https://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/21921/files/6b3ea86a44c02d4c61348c43b9033d7d1b2e5f90
https://github.com/ericpre
ericpre https://github.com/ericpre
https://github.com/matplotlib/matplotlib/pull/21921/files/6b3ea86a44c02d4c61348c43b9033d7d1b2e5f90
topic: widgets/UI https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20widgets%2FUI%22
v3.6.0 https://github.com/matplotlib/matplotlib/milestone/65
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21921
https://github.com/dstansby
https://github.com/timhoffm
https://github.com/ericpre
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.