René's URL Explorer Experiment


Title: Fix missing return value in closeButtonPressed. by anntzer · Pull Request #21792 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix missing return value in closeButtonPressed. by anntzer · Pull Request #21792 · matplotlib/matplotlib

X Title: Fix missing return value in closeButtonPressed. by anntzer · Pull Request #21792 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: Accidentally removed in f7a432a. Closes f7a432a#r61013322. Would be nice if we could run with -Werror instead, which would have caught this, but I assume @dopplershift had a good reason to only us...

X Description: Accidentally removed in f7a432a. Closes f7a432a#r61013322. Would be nice if we could run with -Werror instead, which would have caught this, but I assume @dopplershift had a good reason to only us...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/21792

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:56216aec-134f-a0df-8c6b-05934a71228b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECB8:ECF3D:1109D75:18B8465:6A577422
html-safe-nonce8799e94f228ee545a4da8376e72e87d5dd4bf080321e6dc0860891ea068b2ed5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0I4OkVDRjNEOjExMDlENzU6MThCODQ2NTo2QTU3NzQyMiIsInZpc2l0b3JfaWQiOiI2NzYzMzk4NDkxODg4MzIyOTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace129c8fb089ae102e3949c60e202a97c049140e0224ab70d07e906f37eaa94ca
hovercard-subject-tagpull_request:790353722
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/21792/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f55f38b825eccf76f242e33683f12b1da51f1a554937896d9126e712d87e3032/matplotlib/matplotlib/pull/21792
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f55f38b825eccf76f242e33683f12b1da51f1a554937896d9126e712d87e3032/matplotlib/matplotlib/pull/21792
og:image:altAccidentally removed in f7a432a. Closes f7a432a#r61013322. Would be nice if we could run with -Werror instead, which would have caught this, but I assume @dopplershift had a good reason to only us...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanntzer
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec0ca805e53f128ba1f966be1d3ccd81d0d1959c7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/21792#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F21792
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F21792
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/21792
Reloadhttps://github.com/matplotlib/matplotlib/pull/21792
Reloadhttps://github.com/matplotlib/matplotlib/pull/21792
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21792
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21792
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
QuLogichttps://github.com/QuLogic
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
anntzer:cbphttps://github.com/anntzer/matplotlib/tree/cbp
Conversationhttps://github.com/matplotlib/matplotlib/pull/21792
Commits1 (1)https://github.com/matplotlib/matplotlib/pull/21792/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/21792/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/21792/files
Fix missing return value in closeButtonPressed.https://github.com/matplotlib/matplotlib/pull/21792#top
QuLogichttps://github.com/QuLogic
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
anntzer:cbphttps://github.com/anntzer/matplotlib/tree/cbp
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Nov 29, 2021https://github.com/matplotlib/matplotlib/pull/21792#issue-1065656537
f7a432ahttps://github.com/matplotlib/matplotlib/commit/f7a432a7523d4c99b19f0cd56b17e0310fcb3c20
f7a432a#r61013322https://github.com/matplotlib/matplotlib/commit/f7a432a7523d4c99b19f0cd56b17e0310fcb3c20#r61013322
@dopplershifthttps://github.com/dopplershift
#17956https://github.com/matplotlib/matplotlib/pull/17956
Flake 8https://flake8.pycqa.org/en/latest/
buildhttps://matplotlib.org/devel/documenting_mpl.html#building-the-docs
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21792
https://github.com/anntzer
Fix missing return value in closeButtonPressed.https://github.com/matplotlib/matplotlib/pull/21792/commits/57e320eb591f02bdecc49374305ace1bb401e969
57e320ehttps://github.com/matplotlib/matplotlib/pull/21792/commits/57e320eb591f02bdecc49374305ace1bb401e969
f7a432ahttps://github.com/anntzer/matplotlib/commit/f7a432a7523d4c99b19f0cd56b17e0310fcb3c20
https://github.com/anntzer
anntzerhttps://github.com/anntzer
GUI: MacOSX https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20MacOSX%22
Nov 29, 2021https://github.com/matplotlib/matplotlib/pull/21792#event-5682695581
anntzerhttps://github.com/anntzer
Nov 29, 2021 https://github.com/matplotlib/matplotlib/pull/21792#ref-commit-f7a432a
https://github.com/anntzer
Factor out some macosx gil handling for py-method calls from callbacks.https://github.com/matplotlib/matplotlib/commit/f7a432a7523d4c99b19f0cd56b17e0310fcb3c20
https://github.com/matplotlib/matplotlib/commit/f7a432a7523d4c99b19f0cd56b17e0310fcb3c20#comments
f7a432ahttps://github.com/matplotlib/matplotlib/commit/f7a432a7523d4c99b19f0cd56b17e0310fcb3c20
https://github.com/greglucas
greglucashttps://github.com/greglucas
Nov 29, 2021 https://github.com/matplotlib/matplotlib/pull/21792#pullrequestreview-818025514
View reviewed changes https://github.com/matplotlib/matplotlib/pull/21792/files/57e320eb591f02bdecc49374305ace1bb401e969
greglucashttps://github.com/greglucas
https://github.com/matplotlib/matplotlib/pull/21792#pullrequestreview-818025514
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21792
https://github.com/dopplershift
dopplershifthttps://github.com/dopplershift
Nov 29, 2021https://github.com/matplotlib/matplotlib/pull/21792#issuecomment-981836102
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21792
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Nov 29, 2021 https://github.com/matplotlib/matplotlib/pull/21792#pullrequestreview-818323288
View reviewed changes https://github.com/matplotlib/matplotlib/pull/21792/files/57e320eb591f02bdecc49374305ace1bb401e969
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v3.6.0https://github.com/matplotlib/matplotlib/milestone/65
Nov 29, 2021https://github.com/matplotlib/matplotlib/pull/21792#event-5687777788
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
f6122dchttps://github.com/matplotlib/matplotlib/commit/f6122dcafef38636b1fcb242ee695ec9b6f73a2c
Nov 29, 2021https://github.com/matplotlib/matplotlib/pull/21792#event-5687778024
https://github.com/anntzer
anntzerhttps://github.com/anntzer
November 29, 2021 21:57https://github.com/matplotlib/matplotlib/pull/21792#event-5687942861
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F21792
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/21792/files/57e320eb591f02bdecc49374305ace1bb401e969
https://github.com/greglucas
greglucas https://github.com/greglucas
https://github.com/matplotlib/matplotlib/pull/21792/files/57e320eb591f02bdecc49374305ace1bb401e969
GUI: MacOSX https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20MacOSX%22
v3.6.0 https://github.com/matplotlib/matplotlib/milestone/65
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/21792
https://github.com/anntzer
https://github.com/dopplershift
https://github.com/QuLogic
https://github.com/greglucas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.