Title: Bind subplot_tool more closely to target figure. by anntzer · Pull Request #21681 · matplotlib/matplotlib · GitHub
Open Graph Title: Bind subplot_tool more closely to target figure. by anntzer · Pull Request #21681 · matplotlib/matplotlib
X Title: Bind subplot_tool more closely to target figure. by anntzer · Pull Request #21681 · matplotlib/matplotlib
Description: More the implementation to backend_bases and have pyplot read it, rather than having backend_bases fetch it from pyplot, which was a bit weird. Attach the subplot_tool to the toolbar, which avoids having to keep a reference to it (when calling plt.subplot_tool), and prevents opening two subplot_tools for the same figure. On most backends, closing the subplot_tool deletes the reference, because reopening a closed figure seems not guaranteed to work; on Qt, which has its own subplot_tool, reopening the closed QDialog does work, so just reuse it. Ensure that closing the main figure also closes the subplot_tool. (#21679, the main motivation for this PR.) PR Summary PR Checklist Tests and Styling Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all). Documentation New features are documented, with examples if plot related. New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there). Documentation is sphinx and numpydoc compliant (the docs should build without error).
Open Graph Description: More the implementation to backend_bases and have pyplot read it, rather than having backend_bases fetch it from pyplot, which was a bit weird. Attach the subplot_tool to the toolbar, which avoids ...
X Description: More the implementation to backend_bases and have pyplot read it, rather than having backend_bases fetch it from pyplot, which was a bit weird. Attach the subplot_tool to the toolbar, which avoids ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/21681
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d1276fe0-805d-bea3-1e64-d191774052ea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9512:204EAE:13042F0:1BC14EB:6A57686D |
| html-safe-nonce | c6c4cb151af0d906aa2b35794945c1ca0b042684b63e1a5547762121e8c21e58 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTEyOjIwNEVBRToxMzA0MkYwOjFCQzE0RUI6NkE1NzY4NkQiLCJ2aXNpdG9yX2lkIjoiNTM2MzQxNjc2ODU5MjcwMTU0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 96a128f26924fb489c33b1b3bd60fbc8584e81fceb219524c31038ca41b075a0 |
| hovercard-subject-tag | pull_request:784979180 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/21681/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | More the implementation to backend_bases and have pyplot read it, rather than having backend_bases fetch it from pyplot, which was a bit weird. Attach the subplot_tool to the toolbar, which avoids ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1b5a9c55f39dd27607a574cdc272552f20236b44 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width