| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4d8cca88-184c-773e-e7cc-2c5c359dbcd2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B00E:371C7C:BB8C6B:10E724F:6A54A4E2 |
| html-safe-nonce | 4c590a76806769530fa6843a78bd31810ae48d56f10292bad1e57e220b0a87a2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDBFOjM3MUM3QzpCQjhDNkI6MTBFNzI0Rjo2QTU0QTRFMiIsInZpc2l0b3JfaWQiOiI4NDEyMjUzOTYwMjg3NDQ5MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d9a1793875d12ccaf8fdd70d4a771891e673448448cbe592fd84db3d21dd77f8 |
| hovercard-subject-tag | pull_request:737796217 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/21142/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/857ce62876a7da7c840a65659bc465077a8a1e5c92bc411e0e8d1112c4e93093/matplotlib/matplotlib/pull/21142 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/857ce62876a7da7c840a65659bc465077a8a1e5c92bc411e0e8d1112c4e93093/matplotlib/matplotlib/pull/21142 |
| og:image:alt | PR Summary
closes #21110
This fixes the QT tests to pass on OSX and tries to enable running them on GHA.
PR Checklist
Has pytest style unit tests (and pytest passes).
Is Flake 8 compliant (run ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tacaswell |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8cfff6384f62259baea531c7f58bc7040f8dd92 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/21142#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F21142 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F21142 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/21142 |
| Reload | https://github.com/matplotlib/matplotlib/pull/21142 |
| Reload | https://github.com/matplotlib/matplotlib/pull/21142 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| timhoffm | https://github.com/timhoffm |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| tacaswell:mac_qt_ctrl | https://github.com/tacaswell/matplotlib/tree/mac_qt_ctrl |
| Conversation | https://github.com/matplotlib/matplotlib/pull/21142 |
| Commits3 (3) | https://github.com/matplotlib/matplotlib/pull/21142/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/21142/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/21142/files |
| Mac qt ctrl | https://github.com/matplotlib/matplotlib/pull/21142#top |
| timhoffm | https://github.com/timhoffm |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| tacaswell:mac_qt_ctrl | https://github.com/tacaswell/matplotlib/tree/mac_qt_ctrl |
|
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Sep 20, 2021 | https://github.com/matplotlib/matplotlib/pull/21142#issue-1001232691 |
| #21110 | https://github.com/matplotlib/matplotlib/issues/21110 |
| Flake 8 | https://flake8.pycqa.org/en/latest/ |
| build | https://matplotlib.org/devel/documenting_mpl.html#building-the-docs |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
|
| https://github.com/tacaswell |
| TST: signal alias does not exist on OSX | https://github.com/matplotlib/matplotlib/pull/21142/commits/774b8115f4022cd5c9f71a49ae5ea6cedb38803c |
| 774b811 | https://github.com/matplotlib/matplotlib/pull/21142/commits/774b8115f4022cd5c9f71a49ae5ea6cedb38803c |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| v3.5.0 | https://github.com/matplotlib/matplotlib/milestone/59 |
| Sep 20, 2021 | https://github.com/matplotlib/matplotlib/pull/21142#event-5329958843 |
| https://github.com/greglucas |
| greglucas | https://github.com/greglucas |
|
Sep 20, 2021
| https://github.com/matplotlib/matplotlib/pull/21142#pullrequestreview-759146837 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/21142/files |
| greglucas | https://github.com/greglucas |
| https://github.com/matplotlib/matplotlib/pull/21142#pullrequestreview-759146837 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
| lib/matplotlib/tests/test_backend_qt.py | https://github.com/matplotlib/matplotlib/pull/21142/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371 |
| greglucas | https://github.com/greglucas |
| Sep 20, 2021 | https://github.com/matplotlib/matplotlib/pull/21142#discussion_r712554077 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
| tacaswell | https://github.com/tacaswell |
| Sep 20, 2021 | https://github.com/matplotlib/matplotlib/pull/21142#discussion_r712591530 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
| lib/matplotlib/tests/test_backend_qt.py | https://github.com/matplotlib/matplotlib/pull/21142/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371 |
| greglucas | https://github.com/greglucas |
| Sep 20, 2021 | https://github.com/matplotlib/matplotlib/pull/21142#discussion_r712554752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
| tacaswell | https://github.com/tacaswell |
| Sep 21, 2021 | https://github.com/matplotlib/matplotlib/pull/21142#discussion_r713181074 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Sep 21, 2021
| https://github.com/matplotlib/matplotlib/pull/21142#pullrequestreview-759341265 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/21142/files |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Sep 21, 2021
| https://github.com/matplotlib/matplotlib/pull/21142#pullrequestreview-759342856 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/21142/files |
| timhoffm | https://github.com/timhoffm |
| https://github.com/matplotlib/matplotlib/pull/21142#pullrequestreview-759342856 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
| tacaswell | https://github.com/tacaswell |
| September 21, 2021 11:43 | https://github.com/matplotlib/matplotlib/pull/21142#commits-pushed-27fa740 |
|
| https://github.com/tacaswell |
| TST: enable GUI framework testing on OSX on GHA | https://github.com/matplotlib/matplotlib/pull/21142/commits/27fa74061d08c8193d6f9c5f76d329e1536569da |
| 27fa740 | https://github.com/matplotlib/matplotlib/pull/21142/commits/27fa74061d08c8193d6f9c5f76d329e1536569da |
|
| https://github.com/tacaswell |
| TST: make the qt key tests match what OSX does | https://github.com/matplotlib/matplotlib/pull/21142/commits/2b3c39f40ec9d21967d8efe371a5c2324d16747a |
| 2b3c39f | https://github.com/matplotlib/matplotlib/pull/21142/commits/2b3c39f40ec9d21967d8efe371a5c2324d16747a |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/f6ef5922e782f3f0cc55095c2baf87d2f855d65b..2b3c39f40ec9d21967d8efe371a5c2324d16747a |
| f6ef592 | https://github.com/matplotlib/matplotlib/commit/f6ef5922e782f3f0cc55095c2baf87d2f855d65b |
| 2b3c39f | https://github.com/matplotlib/matplotlib/commit/2b3c39f40ec9d21967d8efe371a5c2324d16747a |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/f6ef5922e782f3f0cc55095c2baf87d2f855d65b..2b3c39f40ec9d21967d8efe371a5c2324d16747a |
| September 21, 2021 15:44 | https://github.com/matplotlib/matplotlib/pull/21142#event-5336680619 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| 98d6a30 | https://github.com/matplotlib/matplotlib/commit/98d6a30bd2ea37d07171deb032206c7a7b771825 |
| Sep 22, 2021 | https://github.com/matplotlib/matplotlib/pull/21142#event-5339526516 |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Sep 22, 2021
| https://github.com/matplotlib/matplotlib/pull/21142#ref-commit-871a1f2 |
|
| https://github.com/timhoffm |
|
| https://github.com/meeseeksmachine |
| Backport PR | https://github.com/meeseeksmachine/matplotlib/commit/871a1f2a39982b1fa24bd7b778a563008817d350 |
| matplotlib#21142 | https://github.com/matplotlib/matplotlib/pull/21142 |
| : Mac qt ctrl | https://github.com/meeseeksmachine/matplotlib/commit/871a1f2a39982b1fa24bd7b778a563008817d350 |
| 871a1f2 | https://github.com/meeseeksmachine/matplotlib/commit/871a1f2a39982b1fa24bd7b778a563008817d350 |
| https://github.com/meeseeksmachine |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Sep 22, 2021
| https://github.com/matplotlib/matplotlib/pull/21142#ref-pullrequest-1003531656 |
|
Backport PR #21142 on branch v3.5.x (Mac qt ctrl)
#21148
| https://github.com/matplotlib/matplotlib/pull/21148 |
| QuLogic | https://github.com/QuLogic |
|
Sep 22, 2021
| https://github.com/matplotlib/matplotlib/pull/21142#ref-commit-286d0d4 |
|
| https://github.com/QuLogic |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/286d0d4a1fe27ae7ac6f8d010450dbba2dc2834b |
| #21148 | https://github.com/matplotlib/matplotlib/pull/21148 |
| from meeseeksmachine/auto-backport-of-pr-21… | https://github.com/matplotlib/matplotlib/commit/286d0d4a1fe27ae7ac6f8d010450dbba2dc2834b |
| 286d0d4 | https://github.com/matplotlib/matplotlib/commit/286d0d4a1fe27ae7ac6f8d010450dbba2dc2834b |
| #21142 | https://github.com/matplotlib/matplotlib/pull/21142 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| September 22, 2021 14:59 | https://github.com/matplotlib/matplotlib/pull/21142#event-5343859676 |
| tacaswell | https://github.com/tacaswell |
|
Oct 12, 2021
| https://github.com/matplotlib/matplotlib/pull/21142#ref-commit-b07f278 |
|
| https://github.com/timhoffm |
| Merge pull request | https://github.com/tacaswell/matplotlib/commit/b07f2780328b88e9cd4f01aa38f29d7e8b483bbb |
| matplotlib#21142 | https://github.com/matplotlib/matplotlib/pull/21142 |
| from tacaswell/mac_qt_ctrl | https://github.com/tacaswell/matplotlib/commit/b07f2780328b88e9cd4f01aa38f29d7e8b483bbb |
| b07f278 | https://github.com/tacaswell/matplotlib/commit/b07f2780328b88e9cd4f01aa38f29d7e8b483bbb |
| tacaswell | https://github.com/tacaswell |
|
Oct 20, 2021
| https://github.com/matplotlib/matplotlib/pull/21142#ref-commit-7c1dec8 |
|
| https://github.com/timhoffm |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/7c1dec8125528f77ea93ba9b99b6f4c67aa5e515 |
| #21142 | https://github.com/matplotlib/matplotlib/pull/21142 |
| from tacaswell/mac_qt_ctrl | https://github.com/matplotlib/matplotlib/commit/7c1dec8125528f77ea93ba9b99b6f4c67aa5e515 |
| 7c1dec8 | https://github.com/matplotlib/matplotlib/commit/7c1dec8125528f77ea93ba9b99b6f4c67aa5e515 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F21142 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/21142/files/f6ef5922e782f3f0cc55095c2baf87d2f855d65b |
|
| https://github.com/greglucas |
|
greglucas
| https://github.com/greglucas |
|
| https://github.com/matplotlib/matplotlib/pull/21142/files/5d8e293e00d643e5757042c9ce768df7941cce12 |
|
v3.5.0
| https://github.com/matplotlib/matplotlib/milestone/59 |
|
Qt swapping ctrl and cmd on OSX
| https://github.com/matplotlib/matplotlib/issues/21110 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/21142 |
|
| https://github.com/tacaswell |
|
| https://github.com/timhoffm |
|
| https://github.com/greglucas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |