René's URL Explorer Experiment


Title: Move sigint tests into subprocesses by QuLogic · Pull Request #20907 · matplotlib/matplotlib · GitHub

Open Graph Title: Move sigint tests into subprocesses by QuLogic · Pull Request #20907 · matplotlib/matplotlib

X Title: Move sigint tests into subprocesses by QuLogic · Pull Request #20907 · matplotlib/matplotlib

Description: PR Summary This prevents them accidentally breaking the test runner itself, depending on platform. Also, enable Qt tests on AppVeyor. A followup to #20883. I haven't converted test_fig_sigint_override yet, as I want to see if this works on Windows. test_fig_sigint_override doesn't actually fire any signals, but I modified it to ensure it doesn't leave broken global state. PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). [n/a] New features are documented, with examples if plot related. Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Open Graph Description: PR Summary This prevents them accidentally breaking the test runner itself, depending on platform. Also, enable Qt tests on AppVeyor. A followup to #20883. I haven't converted test_fig_sigint_o...

X Description: PR Summary This prevents them accidentally breaking the test runner itself, depending on platform. Also, enable Qt tests on AppVeyor. A followup to #20883. I haven't converted test_fig_sigi...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20907

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a1d7553e-b2ed-1808-4a62-1220b6a0b6dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB42E:14A013:2B0AB08:3A240E3:6A53B37D
html-safe-noncefa15f14252abd66d1c07d5903a265fe7da778315b8634fd124c55f751dc2d767
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDJFOjE0QTAxMzoyQjBBQjA4OjNBMjQwRTM6NkE1M0IzN0QiLCJ2aXNpdG9yX2lkIjoiNTMzNjQwODc5ODc1OTQ2NTg1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace9808ae12457c171a21466faf9d5a7ebea12b001ece312db019f1e7c9eec83e5
hovercard-subject-tagpull_request:720094334
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/20907/files
twitter:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
og:image:altPR Summary This prevents them accidentally breaking the test runner itself, depending on platform. Also, enable Qt tests on AppVeyor. A followup to #20883. I haven't converted test_fig_sigint_o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/20907/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20907%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20907%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/20907/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/20907/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/20907/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20907/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20907/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
QuLogic:qt-interrupt-popenhttps://github.com/QuLogic/matplotlib/tree/qt-interrupt-popen
Conversation 5 https://github.com/matplotlib/matplotlib/pull/20907
Commits 6 https://github.com/matplotlib/matplotlib/pull/20907/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/20907/checks
Files changed https://github.com/matplotlib/matplotlib/pull/20907/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20907/files
Move sigint tests into subprocesses https://github.com/matplotlib/matplotlib/pull/20907/files#top
Show all changes 6 commits https://github.com/matplotlib/matplotlib/pull/20907/files
886157f TST: add pyqt on appveyor tacaswell Aug 24, 2021 https://github.com/matplotlib/matplotlib/pull/20907/commits/886157f157dc95690b459708311f8c609b0572fc
2974f3c Move sigint tests into subprocesses. QuLogic Aug 26, 2021 https://github.com/matplotlib/matplotlib/pull/20907/commits/2974f3ca9c86fcae57cc477f2e725e8147d85d0e
df09043 Ensure test_fig_sigint_override cleans up global state. QuLogic Aug 26, 2021 https://github.com/matplotlib/matplotlib/pull/20907/commits/df090437c1dc8cce9e46305d0ea55ad31b1f83e9
9e84366 FIX: try @vdrhtc to fix ctrl-c on windows tacaswell Sep 15, 2021 https://github.com/matplotlib/matplotlib/pull/20907/commits/9e84366c0debd78906f888dc2cce2248c4a41e4d
9d13e7d TST: fix ctrl-c tests on windows tacaswell Sep 16, 2021 https://github.com/matplotlib/matplotlib/pull/20907/commits/9d13e7d14f864dbb3b5ea35f74d02f649596ac0d
e13caa4 DOC: add note about why reading the socket is complicated tacaswell Sep 30, 2021 https://github.com/matplotlib/matplotlib/pull/20907/commits/e13caa4805dc320a774e945122256a071f3be0b5
Clear filters https://github.com/matplotlib/matplotlib/pull/20907/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20907/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20907/files
.appveyor.yml https://github.com/matplotlib/matplotlib/pull/20907/files#diff-e1ab4c3cec24f841948eb867754d4ad0b9b6d11eaa6b5bfbe0357aceb0a49eff
qt_compat.py https://github.com/matplotlib/matplotlib/pull/20907/files#diff-1d841020f609631b01840aa0a48acaf3a90b9e0b06e4d868f02fed652291eabb
test_backend_qt.py https://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
.appveyor.ymlhttps://github.com/matplotlib/matplotlib/pull/20907/files#diff-e1ab4c3cec24f841948eb867754d4ad0b9b6d11eaa6b5bfbe0357aceb0a49eff
View file https://github.com/QuLogic/matplotlib/blob/e13caa4805dc320a774e945122256a071f3be0b5/.appveyor.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20907/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-e1ab4c3cec24f841948eb867754d4ad0b9b6d11eaa6b5bfbe0357aceb0a49eff
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-e1ab4c3cec24f841948eb867754d4ad0b9b6d11eaa6b5bfbe0357aceb0a49eff
lib/matplotlib/backends/qt_compat.pyhttps://github.com/matplotlib/matplotlib/pull/20907/files#diff-1d841020f609631b01840aa0a48acaf3a90b9e0b06e4d868f02fed652291eabb
View file https://github.com/QuLogic/matplotlib/blob/e13caa4805dc320a774e945122256a071f3be0b5/lib/matplotlib/backends/qt_compat.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20907/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-1d841020f609631b01840aa0a48acaf3a90b9e0b06e4d868f02fed652291eabb
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-1d841020f609631b01840aa0a48acaf3a90b9e0b06e4d868f02fed652291eabb
lib/matplotlib/tests/test_backend_qt.pyhttps://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
View file https://github.com/QuLogic/matplotlib/blob/e13caa4805dc320a774e945122256a071f3be0b5/lib/matplotlib/tests/test_backend_qt.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20907/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
jklymakhttps://github.com/jklymak
Sep 23, 2021https://github.com/matplotlib/matplotlib/pull/20907/files#r714560162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20907/files
QuLogichttps://github.com/QuLogic
Sep 23, 2021https://github.com/matplotlib/matplotlib/pull/20907/files#r715115568
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20907/files
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
https://github.com/matplotlib/matplotlib/pull/20907/files#diff-ee95644f45380b6c0cf91171c8c048ed673628bd67f14876ddd60abe0a3e0371
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.