Title: Fix qt key mods by tacaswell · Pull Request #20868 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix qt key mods by tacaswell · Pull Request #20868 · matplotlib/matplotlib
X Title: Fix qt key mods by tacaswell · Pull Request #20868 · matplotlib/matplotlib
Description: PR Summary Fixes a Qt test. It looks like we had a test that never actually worked (the assert happened in a callback so the failure was ignored) which meant that the parameterized tests always passed. When the test was fixed to raise on error this brought to light a miss-match between the computed and expected results which is also fixed. PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). [N/A] New features are documented, with examples if plot related. [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
Open Graph Description: PR Summary Fixes a Qt test. It looks like we had a test that never actually worked (the assert happened in a callback so the failure was ignored) which meant that the parameterized tests always pa...
X Description: PR Summary Fixes a Qt test. It looks like we had a test that never actually worked (the assert happened in a callback so the failure was ignored) which meant that the parameterized tests always pa...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20868
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cf6b58aa-c525-59dc-9305-0f7817ebd027 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D456:2BEEEA:3EBB1A:551B79:6A553E48 |
| html-safe-nonce | a359131037796ea98bf52185295813ab22c3e9d1b75cdabc93a44762f0fdc4e4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDU2OjJCRUVFQTozRUJCMUE6NTUxQjc5OjZBNTUzRTQ4IiwidmlzaXRvcl9pZCI6IjQxNzg0NzQ5NTEzNTQxNzA5NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c533e7f3ded3ba21c10326ed139f0b9fe16eb89ef6f33ea9e19549e829a526a5 |
| hovercard-subject-tag | pull_request:716934222 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/20868/files |
| twitter:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| og:image:alt | PR Summary Fixes a Qt test. It looks like we had a test that never actually worked (the assert happened in a callback so the failure was ignored) which meant that the parameterized tests always pa... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fbd8fce4d63ac394c5405faa20aa50d5c9e56b979ac43ee1b26f8e7c47c4cd89 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 811f50b757204c6a1b4da0ea780075b3e1cc9e57 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width