Title: Propose a less error-prone helper for module-level getattrs. by anntzer · Pull Request #20857 · matplotlib/matplotlib · GitHub
Open Graph Title: Propose a less error-prone helper for module-level getattrs. by anntzer · Pull Request #20857 · matplotlib/matplotlib
X Title: Propose a less error-prone helper for module-level getattrs. by anntzer · Pull Request #20857 · matplotlib/matplotlib
Description: Apparently we always forget to generate the fallback AttributeError (#20822, #20855), so introduce a helper to do so instead. (I'm not wedded to the exact API...) The changes in deprecation.py are (a) so that one can correctly suppress the inferred type when deprecating properties (the new check is coherent with the if isinstance(obj, type) and other cases) and (b) to make single-argument __get__ work on deprecated properties (consistently with standard properties). Would replace #20856. PR Summary PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). New features are documented, with examples if plot related. Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
Open Graph Description: Apparently we always forget to generate the fallback AttributeError (#20822, #20855), so introduce a helper to do so instead. (I'm not wedded to the exact API...) The changes in deprecation.py...
X Description: Apparently we always forget to generate the fallback AttributeError (#20822, #20855), so introduce a helper to do so instead. (I'm not wedded to the exact API...) The changes in deprecatio...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20857
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bb383e87-a1dd-40d6-ba08-686032353775 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B8E8:20B327:156D69D:1C579E7:6A51BD9A |
| html-safe-nonce | 9540e9ec8e8b1f53ed35917dbecfdd734d180e8c5396901dba7ba018e5042f43 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEU4OjIwQjMyNzoxNTZENjlEOjFDNTc5RTc6NkE1MUJEOUEiLCJ2aXNpdG9yX2lkIjoiOTA5ODEzODc5ODEwNjE5NzQwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 98309268ecbd210ee26b0b29110f010559d81f0e9c3bf01b5586140204dd8b92 |
| hovercard-subject-tag | pull_request:715239997 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/20857/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | Apparently we always forget to generate the fallback AttributeError (#20822, #20855), so introduce a helper to do so instead. (I'm not wedded to the exact API...) The changes in deprecation.py... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width