René's URL Explorer Experiment


Title: BUG: __getattr__ must raise AttributeError if name not found by lpsinger · Pull Request #20822 · matplotlib/matplotlib · GitHub

Open Graph Title: BUG: __getattr__ must raise AttributeError if name not found by lpsinger · Pull Request #20822 · matplotlib/matplotlib

X Title: BUG: __getattr__ must raise AttributeError if name not found by lpsinger · Pull Request #20822 · matplotlib/matplotlib

Description: PR Summary PR #20733 added module-level __getattr__ functions to several modules. All of the functions with the exception of the one in matplotlib.style.core had a terminal raise AttributeError to handle unmatched attributes. The omission in matplotlib.style.core was probably unintentional; it results in confusing and buggy behavior such as: >>> import matplotlib.style.core >>> if hasattr(matplotlib.style.core, '__warningregistry__'): ... del matplotlib.style.core.__warningregistry__ ... Traceback (most recent call last): File "", line 2, in AttributeError: __warningregistry__ This causes problems in the unit tests for astropy affiliated packages. See astropy/astropy#12038. PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). New features are documented, with examples if plot related. Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Open Graph Description: PR Summary PR #20733 added module-level __getattr__ functions to several modules. All of the functions with the exception of the one in matplotlib.style.core had a terminal raise AttributeError to ...

X Description: PR Summary PR #20733 added module-level __getattr__ functions to several modules. All of the functions with the exception of the one in matplotlib.style.core had a terminal raise AttributeError to ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20822

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:324b6488-6d91-9ce6-b549-81e2489a62aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DB6:1DB7B5:7E445B:A87339:6A51A9AF
html-safe-nonceba98e63638854f2680329e0c03dcd08b7a981f483601753e5ce1174635c3a5d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REI2OjFEQjdCNTo3RTQ0NUI6QTg3MzM5OjZBNTFBOUFGIiwidmlzaXRvcl9pZCI6IjQ1MjU0MTYwNDQzODMyODM2MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac49f9fff02ae26dd8cc3fd81a0bf758b19c41c4b58cb32f153da60617b5a064aa
hovercard-subject-tagpull_request:707715366
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/20822/files
twitter:imagehttps://avatars.githubusercontent.com/u/728407?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/728407?s=400&v=4
og:image:altPR Summary PR #20733 added module-level __getattr__ functions to several modules. All of the functions with the exception of the one in matplotlib.style.core had a terminal raise AttributeError to ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/20822/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20822%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20822%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/20822/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/20822/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/20822/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20822/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20822/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
lpsinger:getattr-raise-attributerrorhttps://github.com/lpsinger/matplotlib/tree/getattr-raise-attributerror
Conversation 0 https://github.com/matplotlib/matplotlib/pull/20822
Commits 1 https://github.com/matplotlib/matplotlib/pull/20822/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/20822/checks
Files changed https://github.com/matplotlib/matplotlib/pull/20822/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20822/files
BUG: __getattr__ must raise AttributeError if name not found https://github.com/matplotlib/matplotlib/pull/20822/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/20822/files
f4d9e9c BUG: __getattr__ must raise AttributeError if name not found lpsinger Aug 10, 2021 https://github.com/matplotlib/matplotlib/pull/20822/commits/f4d9e9cb7b47fff4cd01352266fd45d11dc7b48f
Clear filters https://github.com/matplotlib/matplotlib/pull/20822/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20822/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20822/files
lib/matplotlib/style/core.pyhttps://github.com/matplotlib/matplotlib/pull/20822/files#diff-becc3462360d02198415578c91804e5b6306ad005f6d9a5fb34bef5a2c29331d
View file https://github.com/lpsinger/matplotlib/blob/f4d9e9cb7b47fff4cd01352266fd45d11dc7b48f/lib/matplotlib/style/core.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20822/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/20822/files#diff-becc3462360d02198415578c91804e5b6306ad005f6d9a5fb34bef5a2c29331d
https://github.com/matplotlib/matplotlib/pull/20822/files#diff-becc3462360d02198415578c91804e5b6306ad005f6d9a5fb34bef5a2c29331d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.