René's URL Explorer Experiment


Title: Deprecate globals using module-level `__getattr__`. by anntzer · Pull Request #20733 · matplotlib/matplotlib · GitHub

Open Graph Title: Deprecate globals using module-level `__getattr__`. by anntzer · Pull Request #20733 · matplotlib/matplotlib

X Title: Deprecate globals using module-level `__getattr__`. by anntzer · Pull Request #20733 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: This PR is mostly just to propose a pattern for defining module-level __getattr__s for deprecating globals. Relying on lru_cache rather than defining variables as global (see change in __init__.py)...

X Description: This PR is mostly just to propose a pattern for defining module-level __getattr__s for deprecating globals. Relying on lru_cache rather than defining variables as global (see change in __init__.py)...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20733

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4f2bdc7d-9cc6-ab11-e8e6-9a5be0042758
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD94A:1525EF:94322B:C49AEB:6A5182E6
html-safe-nonce78d161f51dac1fcff76a146971d4f179ab1f670f007e517cfa55cf341c240d21
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTRBOjE1MjVFRjo5NDMyMkI6QzQ5QUVCOjZBNTE4MkU2IiwidmlzaXRvcl9pZCI6IjEwMTI4OTkxNDcyNjk4OTg5ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca0a5e79a4bc0f4cdb6bc7bc52e15c84a83bdd53c137f15ef8a6c7a459da73e68
hovercard-subject-tagpull_request:696353939
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/20733/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b5ff10509172d47582c02cf78c7f502ce3243a07dfe42eaa64c965a8993c3693/matplotlib/matplotlib/pull/20733
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5ff10509172d47582c02cf78c7f502ce3243a07dfe42eaa64c965a8993c3693/matplotlib/matplotlib/pull/20733
og:image:altThis PR is mostly just to propose a pattern for defining module-level __getattr__s for deprecating globals. Relying on lru_cache rather than defining variables as global (see change in __init__.py)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanntzer
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released01c62704ef24df49056c63892a149b775e1353d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/20733#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20733
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20733
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/20733
Reloadhttps://github.com/matplotlib/matplotlib/pull/20733
Reloadhttps://github.com/matplotlib/matplotlib/pull/20733
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20733
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20733
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
anntzer:dghttps://github.com/anntzer/matplotlib/tree/dg
Conversationhttps://github.com/matplotlib/matplotlib/pull/20733
Commits1 (1)https://github.com/matplotlib/matplotlib/pull/20733/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/20733/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/20733/files
Deprecate globals using module-level __getattr__.https://github.com/matplotlib/matplotlib/pull/20733#top
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
anntzer:dghttps://github.com/anntzer/matplotlib/tree/dg
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jul 24, 2021https://github.com/matplotlib/matplotlib/pull/20733#issue-952079026
#20620 (comment)https://github.com/matplotlib/matplotlib/pull/20620#issuecomment-878609537
#10735https://github.com/matplotlib/matplotlib/pull/10735
Flake 8https://flake8.pycqa.org/en/latest/
buildhttps://matplotlib.org/devel/documenting_mpl.html#building-the-docs
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20733
https://github.com/anntzer
anntzerhttps://github.com/anntzer
v3.5.0https://github.com/matplotlib/matplotlib/milestone/59
Jul 24, 2021https://github.com/matplotlib/matplotlib/pull/20733#event-5064071956
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Maintenance https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3AMaintenance
Jul 24, 2021https://github.com/matplotlib/matplotlib/pull/20733#event-5064072092
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Jul 25, 2021 https://github.com/matplotlib/matplotlib/pull/20733#pullrequestreview-714305941
View reviewed changes https://github.com/matplotlib/matplotlib/pull/20733/files
lib/matplotlib/backends/backend_gtk3.pyhttps://github.com/matplotlib/matplotlib/pull/20733/files#diff-b82974fdd131ae34e8637914da0f13f02f0ea4b5c57b7a8a5789a6faad7ebb5a
timhoffmhttps://github.com/timhoffm
Jul 25, 2021https://github.com/matplotlib/matplotlib/pull/20733#discussion_r676129719
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20733
anntzerhttps://github.com/anntzer
Jul 25, 2021https://github.com/matplotlib/matplotlib/pull/20733#discussion_r676185886
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20733
timhoffmhttps://github.com/timhoffm
Jul 25, 2021https://github.com/matplotlib/matplotlib/pull/20733#discussion_r676207132
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20733
anntzerhttps://github.com/anntzer
Jul 25, 2021https://github.com/matplotlib/matplotlib/pull/20733#discussion_r676213458
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20733
https://github.com/anntzer
anntzerhttps://github.com/anntzer
force-pushedhttps://github.com/matplotlib/matplotlib/compare/ef70f4075958bf22f1068b0d87c39b0c4e838a9f..c8a6dae5f3f1656f61ac92cfbf93c0fc383871c0
ef70f40https://github.com/matplotlib/matplotlib/commit/ef70f4075958bf22f1068b0d87c39b0c4e838a9f
c8a6daehttps://github.com/matplotlib/matplotlib/commit/c8a6dae5f3f1656f61ac92cfbf93c0fc383871c0
Compare https://github.com/matplotlib/matplotlib/compare/ef70f4075958bf22f1068b0d87c39b0c4e838a9f..c8a6dae5f3f1656f61ac92cfbf93c0fc383871c0
July 25, 2021 22:53https://github.com/matplotlib/matplotlib/pull/20733#event-5065397011
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Jul 26, 2021 https://github.com/matplotlib/matplotlib/pull/20733#pullrequestreview-715015133
View reviewed changes https://github.com/matplotlib/matplotlib/pull/20733/files
https://github.com/anntzer
Deprecate globals using module-level __getattr__.https://github.com/matplotlib/matplotlib/pull/20733/commits/014df7f0eb3139f19641e4f92d49876f7dc2b371
014df7fhttps://github.com/matplotlib/matplotlib/pull/20733/commits/014df7f0eb3139f19641e4f92d49876f7dc2b371
https://github.com/anntzer
anntzerhttps://github.com/anntzer
force-pushedhttps://github.com/matplotlib/matplotlib/compare/c8a6dae5f3f1656f61ac92cfbf93c0fc383871c0..014df7f0eb3139f19641e4f92d49876f7dc2b371
c8a6daehttps://github.com/matplotlib/matplotlib/commit/c8a6dae5f3f1656f61ac92cfbf93c0fc383871c0
014df7fhttps://github.com/matplotlib/matplotlib/commit/014df7f0eb3139f19641e4f92d49876f7dc2b371
Compare https://github.com/matplotlib/matplotlib/compare/c8a6dae5f3f1656f61ac92cfbf93c0fc383871c0..014df7f0eb3139f19641e4f92d49876f7dc2b371
July 31, 2021 22:27https://github.com/matplotlib/matplotlib/pull/20733#event-5094762909
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
3e32cc7https://github.com/matplotlib/matplotlib/commit/3e32cc7e88d6d583942335dff4c83b4b7dd13ae9
Aug 6, 2021https://github.com/matplotlib/matplotlib/pull/20733#event-5123877580
https://github.com/anntzer
anntzerhttps://github.com/anntzer
August 6, 2021 16:51https://github.com/matplotlib/matplotlib/pull/20733#event-5123893750
https://github.com/lpsinger
lpsingerhttps://github.com/lpsinger
Aug 10, 2021 https://github.com/matplotlib/matplotlib/pull/20733#ref-pullrequest-965286941
MAINT: guard __warningregistry__ deletion with try/except astropy/astropy#12038 https://github.com/astropy/astropy/pull/12038
lpsingerhttps://github.com/lpsinger
Aug 10, 2021 https://github.com/matplotlib/matplotlib/pull/20733#ref-commit-f4d9e9c
https://github.com/lpsinger
BUG: __getattr__ must raise AttributeError if name not foundhttps://github.com/lpsinger/matplotlib/commit/f4d9e9cb7b47fff4cd01352266fd45d11dc7b48f
f4d9e9chttps://github.com/lpsinger/matplotlib/commit/f4d9e9cb7b47fff4cd01352266fd45d11dc7b48f
matplotlib#20733https://github.com/matplotlib/matplotlib/pull/20733
astropy/astropy#12038https://github.com/astropy/astropy/pull/12038
https://github.com/lpsinger
lpsingerhttps://github.com/lpsinger
Aug 10, 2021 https://github.com/matplotlib/matplotlib/pull/20733#ref-pullrequest-965399456
BUG: __getattr__ must raise AttributeError if name not found #20822 https://github.com/matplotlib/matplotlib/pull/20822
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20733
https://github.com/timhoffm
timhoffm https://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/20733/files/c8a6dae5f3f1656f61ac92cfbf93c0fc383871c0
Maintenance https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3AMaintenance
v3.5.0 https://github.com/matplotlib/matplotlib/milestone/59
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20733
https://github.com/anntzer
https://github.com/timhoffm
https://github.com/tacaswell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.