Title: Add colour vision deficiency simulation by QuLogic · Pull Request #20649 · matplotlib/matplotlib · GitHub
Open Graph Title: Add colour vision deficiency simulation by QuLogic · Pull Request #20649 · matplotlib/matplotlib
X Title: Add colour vision deficiency simulation by QuLogic · Pull Request #20649 · matplotlib/matplotlib
Description: PR Summary This is a spiritual, if not implementation-wise, resurrection of #3279. Unlike that PR though, I do not want to get in the business of implementing such transforms. So this reaches out to colorspacious to do the actual simulation (which looks entirely different for tritanopia, so that PR might not have implemented it correctly.) While colorspacious does support simulating partial colour blindness, I did not implement that here as I think it's overkill. I'm also aware that colorspacious may be lacking maintainers, but this does not directly expose details, so we can swap that out as necessary later. This PR should be good enough to review the API to get the filters working. Currently, I have implemented a UI for this in Qt and GTK, and can do the rest if this all seems good. I don't quite like that every backend needs to re-create the list of filters, but the way that NavigationToolbar.toolitems is defined does not give much flexibility here. In any case, everything UI-wise is self-contained in the backends right now, so if we refactor to simplify things, we won't be breaking API, and can do that in followup PRs. This is a thing we said I'd get done for the CZI grant, and though it's not fully complete, I'm opening the PR now so I can show it off at SciPy. PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). New features are documented, with examples if plot related. Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
Open Graph Description: PR Summary This is a spiritual, if not implementation-wise, resurrection of #3279. Unlike that PR though, I do not want to get in the business of implementing such transforms. So this reaches out ...
X Description: PR Summary This is a spiritual, if not implementation-wise, resurrection of #3279. Unlike that PR though, I do not want to get in the business of implementing such transforms. So this reaches out ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20649
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:be0a1291-9a35-6f8f-fd7c-7a998b5e04e1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CDC0:1F7C65:647A2A:87B7EE:6A5413D7 |
| html-safe-nonce | 00dbb34408cbb719ec7795d84983c4b34dcb20ae36dccabc778c369c5f1ec2c4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREMwOjFGN0M2NTo2NDdBMkE6ODdCN0VFOjZBNTQxM0Q3IiwidmlzaXRvcl9pZCI6Ijc3MDg4MzQ4ODIwNzY4MDgxNTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5f3d812cefaf1b710b4889e35d81775e1e394d0001387ac43ed7bed7ab3a53ee |
| hovercard-subject-tag | pull_request:690354663 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/20649/files |
| twitter:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| og:image:alt | PR Summary This is a spiritual, if not implementation-wise, resurrection of #3279. Unlike that PR though, I do not want to get in the business of implementing such transforms. So this reaches out ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width
