René's URL Explorer Experiment


Title: Rename parameter selectors by ericpre · Pull Request #20585 · matplotlib/matplotlib · GitHub

Open Graph Title: Rename parameter selectors by ericpre · Pull Request #20585 · matplotlib/matplotlib

X Title: Rename parameter selectors by ericpre · Pull Request #20585 · matplotlib/matplotlib

Description: PR Summary Follow up of #20558. Rename parameters (maxdist, markers_props, etc.) to make them consistent between the different selectors. PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). [n/a] New features are documented, with examples if plot related. [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Open Graph Description: PR Summary Follow up of #20558. Rename parameters (maxdist, markers_props, etc.) to make them consistent between the different selectors. PR Checklist Has pytest style unit tests (and pytest pas...

X Description: PR Summary Follow up of #20558. Rename parameters (maxdist, markers_props, etc.) to make them consistent between the different selectors. PR Checklist Has pytest style unit tests (and pytest pas...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20585

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:46d3d952-8579-514c-30d8-1de36dca153d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA16:2CBC5E:1CD4B08:29DBDBB:6A563B10
html-safe-noncee94a4c4d6f40388f936471077bc2faa59c97f38aa6a6b35861b01eb154a5918e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTE2OjJDQkM1RToxQ0Q0QjA4OjI5REJEQkI6NkE1NjNCMTAiLCJ2aXNpdG9yX2lkIjoiODU2MjQ1MzMxODU1NTAyNDE0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac37fcbd3a74bacef683a469a9085de9c2904e7197867adb0834b0ce264d408c0f
hovercard-subject-tagpull_request:684664490
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/20585/files
twitter:imagehttps://avatars.githubusercontent.com/u/11851990?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11851990?s=400&v=4
og:image:altPR Summary Follow up of #20558. Rename parameters (maxdist, markers_props, etc.) to make them consistent between the different selectors. PR Checklist Has pytest style unit tests (and pytest pas...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None96d96c6ad1e3234907759a5e634942d2ca0aded8a6ec1693a59d0f2c59c0dac9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseec50befe6b611eee09bfe878347d87b8d5d2443f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/20585/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20585%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20585%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/20585/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/20585/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/20585/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20585/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20585/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
timhoffmhttps://github.com/timhoffm
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
ericpre:rename_parameter_selectorshttps://github.com/ericpre/matplotlib/tree/rename_parameter_selectors
Conversation 54 https://github.com/matplotlib/matplotlib/pull/20585
Commits 18 https://github.com/matplotlib/matplotlib/pull/20585/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/20585/checks
Files changed 4 https://github.com/matplotlib/matplotlib/pull/20585/files
Rename parameter selectors https://github.com/matplotlib/matplotlib/pull/20585/files#top
Show all changes 18 commits https://github.com/matplotlib/matplotlib/pull/20585/files
ea665e9 Rename marker_props to handle_props and maxdist to handle_grab_distan… ericpre Jul 6, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/ea665e980ac49db17565ee3be362e157d0a3a33a
b92a132 Rename `markerprops` to `handle_props` and `vertex_select_radius` to … ericpre Jul 6, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/b92a13214a8202e10d52721b93840f8322be0738
1ce5fbf Document deprecation in doc/api/next_api_changes ericpre Jul 6, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/1ce5fbf0b7e06bdfb7713be47f6a46783e1474dd
e093d88 Remove docstring of deprecated arguments. ericpre Jul 7, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/e093d88349251bc262598d6bb0018c2087ad18d7
f1d7ac8 Move RectangleSelector from __init__ to class docstring. ericpre Jul 7, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/f1d7ac8ab90fbd7e28ea92ec8ff4eb9acf6237f8
9ed4cac Add example to RectangleSelector docstring and improve EllipseSelecto… ericpre Jul 7, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/9ed4cac667cca98913f1229b4faea6f92fa99043
fbdae90 Use docstring.Substitution instead of editing __doc__ ericpre Jul 7, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/fbdae90b08140d46a6d3bbb792f9c700c0d9305f
479d9cf Add deprecation accessors to old attribute ericpre Jul 8, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/479d9cf706ad0d83c8351dc9a3d11ae4e09cacce
b72fcde Improve docstring selectors ericpre Jul 10, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/b72fcde2f50532c28e573c0af90b0cdfb2f28e2b
0885e2e Rename rectprops/lineprops to props ericpre Jul 10, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/0885e2e29de3bea9fecfd35fb9a861cb18331178
ae16462 Improve docstring: add links to properties description, clarify defau… ericpre Jul 12, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/ae16462f5a8ba619fbd90457b87d75d3221bbde6
f071815 Rename `handle_grad_distance` to `grab_range` ericpre Jul 12, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/f071815711379986db4ea4a455c68106723363c2
3bbe997 Revert changes of other selectors and simplify parsing `handle_props`… ericpre Jul 16, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/3bbe997d3504b1f866727172ceccc4bfc36a6134
8ff493c Fix flake8 ericpre Jul 16, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/8ff493c6cf939ca0c5be0a10a3f9eb0fc6bb1370
f3fa7f7 Apply suggestions from code review regarding the documentation of API… ericpre Jul 17, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/f3fa7f7be4946de904d05aea263b82faea97ace8
4d3abfc Simplify parsing dictionary ericpre Jul 17, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/4d3abfcf3c7b0f887650b5df11814ecf2f62f3d4
00444e4 Fix indentation docstring, update API changes and update SpanSelector… ericpre Jul 18, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/00444e4ff3719c1ca0760e6e804d030e21f3f781
8682b5f Fix deprecated attribute setter. ericpre Jul 19, 2021 https://github.com/matplotlib/matplotlib/pull/20585/commits/8682b5f082a530341f54de31776318ad00fb8ea8
Clear filters https://github.com/matplotlib/matplotlib/pull/20585/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20585/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20585/files
20585-EP.rst https://github.com/matplotlib/matplotlib/pull/20585/files#diff-44153f20d8e44e0a45d2e223d15c45236a7743cbccdf605c549f2d3285a9c3ec
span_selector.py https://github.com/matplotlib/matplotlib/pull/20585/files#diff-6ab5cb75fe82b986937c1193d7c3b9aba2260102a205e72c32f4018cfd2fa551
test_widgets.py https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
widgets.py https://github.com/matplotlib/matplotlib/pull/20585/files#diff-7e2b57811ea0cf4c29c147f61cff569194cdddfa9fea35eb897b4d786dca06ce
doc/api/next_api_changes/deprecations/20585-EP.rsthttps://github.com/matplotlib/matplotlib/pull/20585/files#diff-44153f20d8e44e0a45d2e223d15c45236a7743cbccdf605c549f2d3285a9c3ec
View file https://github.com/ericpre/matplotlib/blob/8682b5f082a530341f54de31776318ad00fb8ea8/doc/api/next_api_changes/deprecations/20585-EP.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20585/{{ revealButtonHref }}
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20585/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20585/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20585/files
examples/widgets/span_selector.pyhttps://github.com/matplotlib/matplotlib/pull/20585/files#diff-6ab5cb75fe82b986937c1193d7c3b9aba2260102a205e72c32f4018cfd2fa551
View file https://github.com/ericpre/matplotlib/blob/8682b5f082a530341f54de31776318ad00fb8ea8/examples/widgets/span_selector.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20585/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-6ab5cb75fe82b986937c1193d7c3b9aba2260102a205e72c32f4018cfd2fa551
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-6ab5cb75fe82b986937c1193d7c3b9aba2260102a205e72c32f4018cfd2fa551
lib/matplotlib/tests/test_widgets.pyhttps://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
View file https://github.com/ericpre/matplotlib/blob/8682b5f082a530341f54de31776318ad00fb8ea8/lib/matplotlib/tests/test_widgets.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20585/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
https://github.com/matplotlib/matplotlib/pull/20585/files#diff-49bef07a6ad7921c1aedc5b8786e8f86f5cd96ac5bb639b6d431f9d2b07d784c
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20585/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.