Title: Fix calls to np.ma.masked_where by QuLogic · Pull Request #20511 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix calls to np.ma.masked_where by QuLogic · Pull Request #20511 · matplotlib/matplotlib
X Title: Fix calls to np.ma.masked_where by QuLogic · Pull Request #20511 · matplotlib/matplotlib
Description: PR Summary Due to numpy/numpy#18967, I've audited all our calls to np.ma.masked_*(copy=False). When the input comes directly from the user, or is already stored somewhere already, then we don't want these calls to modify the existing values. This affects np.ma.masked_where and all simple wrappers around it like masked_less_equal. It does not affect masked_invalid, which continues to not modify the input. I have asked upstream numpy/numpy#19332 whether that is intended. If they intend to change masked_invalid also, then we will need to make a few more changes like this, but we are mostly okay. PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). [n/a] New features are documented, with examples if plot related. [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
Open Graph Description: PR Summary Due to numpy/numpy#18967, I've audited all our calls to np.ma.masked_*(copy=False). When the input comes directly from the user, or is already stored somewhere already, then we don&#...
X Description: PR Summary Due to numpy/numpy#18967, I've audited all our calls to np.ma.masked_*(copy=False). When the input comes directly from the user, or is already stored somewhere already, then we d...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20511
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3838e2b5-23fd-6130-1353-8d2bba0c6502 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 847C:1525EF:A20654:D6E0AB:6A5186AC |
| html-safe-nonce | d0e36d1da08f2dc90bfdfe120914652cca1418bdd184d370223b42b68323cb95 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDdDOjE1MjVFRjpBMjA2NTQ6RDZFMEFCOjZBNTE4NkFDIiwidmlzaXRvcl9pZCI6IjM0OTE1MjM5MTA1MDMwNzM0NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 295807dd72f3198489261e9f84b83cf3f7c612a67addc821d723b57f6f2efb23 |
| hovercard-subject-tag | pull_request:677490488 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/20511/files |
| twitter:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| og:image:alt | PR Summary Due to numpy/numpy#18967, I've audited all our calls to np.ma.masked_*(copy=False). When the input comes directly from the user, or is already stored somewhere already, then we don&#... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cb77a7b8b06cd86c243be33fd8e7922d70a9d243 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width