René's URL Explorer Experiment


Title: FIX: ColorbarAxes properly in the axes stack by jklymak · Pull Request #20484 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: ColorbarAxes properly in the axes stack by jklymak · Pull Request #20484 · matplotlib/matplotlib

X Title: FIX: ColorbarAxes properly in the axes stack by jklymak · Pull Request #20484 · matplotlib/matplotlib

Description: PR Summary Closes #20479 ColorbarAxes was not sitting in the figure Axes stacks correctly - rather cb.outer_axes was still in the queue. Which worked fine, but didn't make mouseevents pass through properly. The solution here is to swap cb.ax for cb.outer_axes in the figure axes stacks, and to redefine draw on the ColorbarAxes to draw the outer axes first (i.e. set the aspect ratio and size of the bounding box for the colorbar). I was testing on the following, though the real test is simply that cb.ax appears in the figure axes list now: import numpy as np import matplotlib.pyplot as plt #from matplotlib.backend_bases import MouseButton def pick_fn(mouseevent): if mouseevent.inaxes is colorbar.ax: print('pick\n\nPICKKKKKKK') print(mouseevent.ydata, mouseevent.button) def motion_fn(mouseevent): if mouseevent.inaxes is colorbar.ax: print(mouseevent.ydata, mouseevent.button) pass fig, ax = plt.subplots() canvas = fig.canvas arr = np.random.randn(100, 100) axesimage = plt.imshow(arr) colorbar = plt.colorbar(axesimage, ax=ax, use_gridspec=True) # helps you see what value you are about to set the range to colorbar.ax.set_navigate(True) canvas.mpl_connect("motion_notify_event", motion_fn) colorbar.ax.set_picker(True) canvas.mpl_connect("button_press_event", pick_fn) plt.show() PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). New features are documented, with examples if plot related. Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Open Graph Description: PR Summary Closes #20479 ColorbarAxes was not sitting in the figure Axes stacks correctly - rather cb.outer_axes was still in the queue. Which worked fine, but didn't make mouseevents pass thr...

X Description: PR Summary Closes #20479 ColorbarAxes was not sitting in the figure Axes stacks correctly - rather cb.outer_axes was still in the queue. Which worked fine, but didn't make mouseevents pass...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20484

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2024a594-d206-e3f5-2b58-426e864f7a2b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDFE:1DC0B7:ABC357:EB717B:6A539C70
html-safe-noncec0b2ae68ea955e0c040b42734f0980b47db7ec21707019ba702e0a3e4a224659
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREZFOjFEQzBCNzpBQkMzNTc6RUI3MTdCOjZBNTM5QzcwIiwidmlzaXRvcl9pZCI6IjkxNDg4MTgyNTY4NTI5MTczNjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca6a25a168aee0eb766882a960b22edecb5b14cf17d039e634e9a86da573c636f
hovercard-subject-tagpull_request:675479334
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/20484/files
twitter:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
og:image:altPR Summary Closes #20479 ColorbarAxes was not sitting in the figure Axes stacks correctly - rather cb.outer_axes was still in the queue. Which worked fine, but didn't make mouseevents pass thr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/20484/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20484%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F20484%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/20484/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/20484/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/20484/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-colorbar-axes-stackhttps://github.com/jklymak/matplotlib/tree/fix-colorbar-axes-stack
Conversation 16 https://github.com/matplotlib/matplotlib/pull/20484
Commits 4 https://github.com/matplotlib/matplotlib/pull/20484/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/20484/checks
Files changed https://github.com/matplotlib/matplotlib/pull/20484/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
FIX: ColorbarAxes properly in the axes stack https://github.com/matplotlib/matplotlib/pull/20484/files#top
Show all changes 4 commits https://github.com/matplotlib/matplotlib/pull/20484/files
1b7bdfa FIX: colorbarAxes properly in the axes stack jklymak Jun 22, 2021 https://github.com/matplotlib/matplotlib/pull/20484/commits/1b7bdfa6b6d6fcf77a2179ac4bd157da61fd77f9
eb879a9 Make subplot_adjust work and remove work jklymak Jun 22, 2021 https://github.com/matplotlib/matplotlib/pull/20484/commits/eb879a94936f7b2b00fcbd2ba6d2e04d94bac3e0
f084fcb Flake8 jklymak Jun 22, 2021 https://github.com/matplotlib/matplotlib/pull/20484/commits/f084fcb4dc8f2561ce9f596f1f15560eaa6b0bbf
fb768c7 Deal with axes_grid differences jklymak Jun 22, 2021 https://github.com/matplotlib/matplotlib/pull/20484/commits/fb768c7b90b938f5a5904b4661f7779ae3bcde6c
Clear filters https://github.com/matplotlib/matplotlib/pull/20484/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
colorbar.py https://github.com/matplotlib/matplotlib/pull/20484/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
figure.py https://github.com/matplotlib/matplotlib/pull/20484/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
axes_grid.py https://github.com/matplotlib/matplotlib/pull/20484/files#diff-ba79d31808d1f55bdf8bf2896366c85122eb9488e140c5a4de060f2c4e1fa8f6
lib/matplotlib/colorbar.pyhttps://github.com/matplotlib/matplotlib/pull/20484/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
View file https://github.com/jklymak/matplotlib/blob/fb768c7b90b938f5a5904b4661f7779ae3bcde6c/lib/matplotlib/colorbar.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20484/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
greglucashttps://github.com/greglucas
Jun 22, 2021https://github.com/matplotlib/matplotlib/pull/20484/files#r656627636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
jklymakhttps://github.com/jklymak
Jun 22, 2021https://github.com/matplotlib/matplotlib/pull/20484/files#r656633460
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
greglucashttps://github.com/greglucas
Jun 22, 2021https://github.com/matplotlib/matplotlib/pull/20484/files#r656629266
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
jklymakhttps://github.com/jklymak
Jun 22, 2021https://github.com/matplotlib/matplotlib/pull/20484/files#r656633083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
greglucashttps://github.com/greglucas
Jun 23, 2021https://github.com/matplotlib/matplotlib/pull/20484/files#r656690859
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
greglucashttps://github.com/greglucas
Jun 22, 2021https://github.com/matplotlib/matplotlib/pull/20484/files#r656629665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
jklymakhttps://github.com/jklymak
Jun 22, 2021https://github.com/matplotlib/matplotlib/pull/20484/files#r656633591
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
jklymakhttps://github.com/jklymak
Jun 22, 2021https://github.com/matplotlib/matplotlib/pull/20484/files#r656635679
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
greglucashttps://github.com/greglucas
Jun 23, 2021https://github.com/matplotlib/matplotlib/pull/20484/files#r656690704
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/20484/files
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
lib/matplotlib/figure.pyhttps://github.com/matplotlib/matplotlib/pull/20484/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
View file https://github.com/jklymak/matplotlib/blob/fb768c7b90b938f5a5904b4661f7779ae3bcde6c/lib/matplotlib/figure.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20484/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
lib/mpl_toolkits/axes_grid1/axes_grid.pyhttps://github.com/matplotlib/matplotlib/pull/20484/files#diff-ba79d31808d1f55bdf8bf2896366c85122eb9488e140c5a4de060f2c4e1fa8f6
View file https://github.com/jklymak/matplotlib/blob/fb768c7b90b938f5a5904b4661f7779ae3bcde6c/lib/mpl_toolkits/axes_grid1/axes_grid.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/20484/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-ba79d31808d1f55bdf8bf2896366c85122eb9488e140c5a4de060f2c4e1fa8f6
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-ba79d31808d1f55bdf8bf2896366c85122eb9488e140c5a4de060f2c4e1fa8f6
https://github.com/matplotlib/matplotlib/pull/20484/files#diff-ba79d31808d1f55bdf8bf2896366c85122eb9488e140c5a4de060f2c4e1fa8f6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.