Title: Move AxisArtistHelpers to toplevel. by anntzer · Pull Request #20214 · matplotlib/matplotlib · GitHub
Open Graph Title: Move AxisArtistHelpers to toplevel. by anntzer · Pull Request #20214 · matplotlib/matplotlib
X Title: Move AxisArtistHelpers to toplevel. by anntzer · Pull Request #20214 · matplotlib/matplotlib
Description: The axisartist has a concept of "axis_artist_helper", which computes various computations to draw slanted/curved axises. Confusingly, AxisArtistHelper (and likewise AxisArtistHelperRectlinear) do not define such helper classes; they are simply namespaces that hold the {AxisArtistHelper,AxisArtistHelperRectlinear}.{Fixed,Floating} nested classes which do define helpers. More specifically, AxisArtistHelper.{Fixed,Floating} act as abstract base classes for AxisArtistHelperRectlinear.{Fixed,Floating} which are actually usable. In order to slightly disentangle this move the actual helper classes to the toplevel (as _{Fixed,Floating}AxisArtistHelperBase and _{Fixed,Floating}AxisArtistHelperRectlinear), keeping the old "purely namespace" classes around for backcompat. (But note that end users should never have to directly interact with these classes anyways -- normally, they only construct GridHelpers which take care of the interaction with AxisArtistHelpers; see e.g. the various axisartist examples.) More simply, this commit simply dedents most of the definitions of the Helper classes. PR Summary PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). New features are documented, with examples if plot related. Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
Open Graph Description: The axisartist has a concept of "axis_artist_helper", which computes various computations to draw slanted/curved axises. Confusingly, AxisArtistHelper (and likewise AxisArtistHelperRectl...
X Description: The axisartist has a concept of "axis_artist_helper", which computes various computations to draw slanted/curved axises. Confusingly, AxisArtistHelper (and likewise AxisArtistHel...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/20214
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:06e22c5d-f624-2f1c-422f-90dc0bf0a9a6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92D4:24C5C6:512D68:6BE48B:6A517145 |
| html-safe-nonce | 414ead21a344eb6f59c4b3b72330cdc3a94758d677427b2ded0204914f18fbdf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkQ0OjI0QzVDNjo1MTJENjg6NkJFNDhCOjZBNTE3MTQ1IiwidmlzaXRvcl9pZCI6IjEyMzg2OTU1NzI0MDk1MTIyNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9a1c206236f1570637fbf2d65af818186a3cb12a35a7f084fe9b016437133635 |
| hovercard-subject-tag | pull_request:643341625 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/20214/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | The axisartist has a concept of "axis_artist_helper", which computes various computations to draw slanted/curved axises. Confusingly, AxisArtistHelper (and likewise AxisArtistHelperRectl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b19955a9dd40fd99462443f7911b522d7216776a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width