| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2ed708d8-d17b-4bf0-b402-48d3d7d9cd8e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AAE2:2946B:2EA3F1:425459:6A50F63D |
| html-safe-nonce | ddb49a8bffd0d3636d5f781dfa429c45fc1b5ff2d145538946fce24c0cc8448c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUUyOjI5NDZCOjJFQTNGMTo0MjU0NTk6NkE1MEY2M0QiLCJ2aXNpdG9yX2lkIjoiNTk2MjY5NjA5ODAyMzc5ODMzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fada2283d56f4174eb5b575d16ecec65cf85a094a266cafae818d77ae528c47f |
| hovercard-subject-tag | pull_request:603195281 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/19816/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/792da441844a81bbfc9062e9154ce1025728354870b866d291970ba0f4c5b5f5/matplotlib/matplotlib/pull/19816 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/792da441844a81bbfc9062e9154ce1025728354870b866d291970ba0f4c5b5f5/matplotlib/matplotlib/pull/19816 |
| og:image:alt | PR Summary
This is a slight backport of ed6d92b, namely ignoring the array update status when updating the scalar mappable.
To not break the watchers though, the check must still be called to updat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | QuLogic |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838 |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8d836581d020676cc0ef4a83cd2fe17e4af02c3d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/19816#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19816 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19816 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/19816 |
| Reload | https://github.com/matplotlib/matplotlib/pull/19816 |
| Reload | https://github.com/matplotlib/matplotlib/pull/19816 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
410
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| tacaswell | https://github.com/tacaswell |
| matplotlib:v3.4.x | https://github.com/matplotlib/matplotlib/tree/v3.4.x |
| QuLogic:fix-scatter-legend | https://github.com/QuLogic/matplotlib/tree/fix-scatter-legend |
| Conversation | https://github.com/matplotlib/matplotlib/pull/19816 |
| Commits1 (1) | https://github.com/matplotlib/matplotlib/pull/19816/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/19816/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/19816/files |
| Fix legend of colour-mapped scatter plots. | https://github.com/matplotlib/matplotlib/pull/19816#top |
| tacaswell | https://github.com/tacaswell |
| matplotlib:v3.4.x | https://github.com/matplotlib/matplotlib/tree/v3.4.x |
| QuLogic:fix-scatter-legend | https://github.com/QuLogic/matplotlib/tree/fix-scatter-legend |
|
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Mar 29, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#issue-843869171 |
| ed6d92b | https://github.com/matplotlib/matplotlib/commit/ed6d92b00426429d3f4350fc3710155fa46160c0 |
| #19779 | https://github.com/matplotlib/matplotlib/issues/19779 |
| Flake 8 | https://flake8.pycqa.org/en/latest/ |
| build | https://matplotlib.org/devel/documenting_mpl.html#building-the-docs |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Release critical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22 |
| Mar 29, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#event-4524183080 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| v3.4.1 | https://github.com/matplotlib/matplotlib/milestone/61 |
| Mar 29, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#event-4524183084 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| efiring | https://github.com/efiring |
| March 29, 2021 22:30 | https://github.com/matplotlib/matplotlib/pull/19816#event-4524183087 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Mar 30, 2021
| https://github.com/matplotlib/matplotlib/pull/19816#pullrequestreview-623772995 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/19816/files |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Mar 30, 2021
| https://github.com/matplotlib/matplotlib/pull/19816#pullrequestreview-623774387 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/19816/files |
| lib/matplotlib/collections.py | https://github.com/matplotlib/matplotlib/pull/19816/files#diff-0563f83260b79acbd260c8f0207b01ba8182df37bf2ccd9216d9a3c6a70cbf29 |
| tacaswell | https://github.com/tacaswell |
| Mar 30, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#discussion_r603720303 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| https://github.com/smartlixx |
| smartlixx | https://github.com/smartlixx |
|
Mar 30, 2021
| https://github.com/matplotlib/matplotlib/pull/19816#pullrequestreview-623777214 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/19816/files |
| lib/matplotlib/collections.py | https://github.com/matplotlib/matplotlib/pull/19816/files#diff-0563f83260b79acbd260c8f0207b01ba8182df37bf2ccd9216d9a3c6a70cbf29 |
| smartlixx | https://github.com/smartlixx |
| Mar 30, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#discussion_r603722768 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| matplotlib/lib/matplotlib/collections.py | https://github.com/matplotlib/matplotlib/blob/e6fd9012d823fde63db620412e1ce9c36d94eb63/lib/matplotlib/collections.py#L927-L934 |
| e6fd901 | https://github.com/matplotlib/matplotlib/commit/e6fd9012d823fde63db620412e1ce9c36d94eb63 |
| matplotlib/lib/matplotlib/collections.py | https://github.com/matplotlib/matplotlib/blob/e6fd9012d823fde63db620412e1ce9c36d94eb63/lib/matplotlib/collections.py#L379-L380 |
| e6fd901 | https://github.com/matplotlib/matplotlib/commit/e6fd9012d823fde63db620412e1ce9c36d94eb63 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| efiring | https://github.com/efiring |
| Mar 30, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#discussion_r603733214 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| https://github.com/efiring |
| efiring | https://github.com/efiring |
|
Mar 30, 2021
| https://github.com/matplotlib/matplotlib/pull/19816#pullrequestreview-623790751 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/19816/files |
| efiring | https://github.com/efiring |
| https://github.com/matplotlib/matplotlib/pull/19816#pullrequestreview-623790751 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Mar 30, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#issuecomment-809967107 |
| matplotlib/lib/matplotlib/collections.py | https://github.com/matplotlib/matplotlib/blob/315ff0623652bbcca8111bf71727aed04cfe4009/lib/matplotlib/collections.py#L942-L962 |
| 315ff06 | https://github.com/matplotlib/matplotlib/commit/315ff0623652bbcca8111bf71727aed04cfe4009 |
| #18480 | https://github.com/matplotlib/matplotlib/pull/18480 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| March 30, 2021 07:01 | https://github.com/matplotlib/matplotlib/pull/19816#event-4525572662 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Mar 30, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#issuecomment-809979504 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
|
| https://github.com/QuLogic |
| Copy new attributes in Collection.update_from. | https://github.com/matplotlib/matplotlib/pull/19816/commits/ee8dc54f758359bc1ca6ce1e0422103af629783b |
| ee8dc54 | https://github.com/matplotlib/matplotlib/pull/19816/commits/ee8dc54f758359bc1ca6ce1e0422103af629783b |
| matplotlib#18480 | https://github.com/matplotlib/matplotlib/pull/18480 |
| matplotlib#19779 | https://github.com/matplotlib/matplotlib/issues/19779 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/7c1b2c0575f17ac797e3e1edc7e18af89e72e417..ee8dc54f758359bc1ca6ce1e0422103af629783b |
| 7c1b2c0 | https://github.com/matplotlib/matplotlib/commit/7c1b2c0575f17ac797e3e1edc7e18af89e72e417 |
| ee8dc54 | https://github.com/matplotlib/matplotlib/commit/ee8dc54f758359bc1ca6ce1e0422103af629783b |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/7c1b2c0575f17ac797e3e1edc7e18af89e72e417..ee8dc54f758359bc1ca6ce1e0422103af629783b |
| March 30, 2021 21:31 | https://github.com/matplotlib/matplotlib/pull/19816#event-4530503122 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| March 30, 2021 21:43 | https://github.com/matplotlib/matplotlib/pull/19816#event-4530556713 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| efiring | https://github.com/efiring |
| tacaswell | https://github.com/tacaswell |
| March 30, 2021 21:43 | https://github.com/matplotlib/matplotlib/pull/19816#event-4530557153 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Mar 30, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#issuecomment-810597862 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Mar 30, 2021
| https://github.com/matplotlib/matplotlib/pull/19816#pullrequestreview-624775082 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/19816/files/ee8dc54f758359bc1ca6ce1e0422103af629783b |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Mar 30, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#issuecomment-810638421 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Mar 30, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#issuecomment-810640472 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Mar 31, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#issuecomment-810703914 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| 6547ba2 | https://github.com/matplotlib/matplotlib/commit/6547ba2effce34c0d3520e84e67e13504eeddc0a |
| Mar 31, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#event-4531470497 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| March 31, 2021 02:14 | https://github.com/matplotlib/matplotlib/pull/19816#event-4531480460 |
| https://github.com/efiring |
| efiring | https://github.com/efiring |
| Mar 31, 2021 | https://github.com/matplotlib/matplotlib/pull/19816#issuecomment-810707164 |
| @QuLogic | https://github.com/QuLogic |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
|
BUG: matplotlib 3.4.0 -- Scatter with colormap and legend gives TypeError: object of type 'NoneType' has no len()
#19779
| https://github.com/matplotlib/matplotlib/issues/19779 |
|
Merge v3.4.x into master
#19835
| https://github.com/matplotlib/matplotlib/pull/19835 |
| https://github.com/pllim |
| pllim | https://github.com/pllim |
|
Mar 31, 2021
| https://github.com/matplotlib/matplotlib/pull/19816#ref-pullrequest-842207066 |
|
MNT: matplotlib 3.4.0 broke plot_obs-planning.py
astropy/astropy#11437
| https://github.com/astropy/astropy/pull/11437 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19816 |
|
| https://github.com/tacaswell |
|
tacaswell
| https://github.com/tacaswell |
|
| https://github.com/matplotlib/matplotlib/pull/19816/files/ee8dc54f758359bc1ca6ce1e0422103af629783b |
|
| https://github.com/efiring |
|
efiring
| https://github.com/efiring |
|
| https://github.com/smartlixx |
|
smartlixx
| https://github.com/smartlixx |
|
| https://github.com/matplotlib/matplotlib/pull/19816/files/7c1b2c0575f17ac797e3e1edc7e18af89e72e417 |
|
Release critical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22 |
|
v3.4.1
| https://github.com/matplotlib/matplotlib/milestone/61 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/19816 |
|
| https://github.com/QuLogic |
|
| https://github.com/tacaswell |
|
| https://github.com/efiring |
|
| https://github.com/smartlixx |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |