René's URL Explorer Experiment


Title: Fix suptitle out of layout by jklymak · Pull Request #19805 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix suptitle out of layout by jklymak · Pull Request #19805 · matplotlib/matplotlib

X Title: Fix suptitle out of layout by jklymak · Pull Request #19805 · matplotlib/matplotlib

Description: PR Summary Closes: #19803 Subtitles should not be in constrained layout if they were positioned manually because constrained layout moves them. However, in 3.4 we took them out of the layout altogether, which breaks bbox_inches='tight' and the inline backend. Have a check for the hard-coded defaults. Maybe not the most robust, but we don't store the defaults anywhere. Could maybe store on figure and get from there, but... Storing on the subtitle object itself works fine. PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). New features are documented, with examples if plot related. Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Open Graph Description: PR Summary Closes: #19803 Subtitles should not be in constrained layout if they were positioned manually because constrained layout moves them. However, in 3.4 we took them out of the layout altog...

X Description: PR Summary Closes: #19803 Subtitles should not be in constrained layout if they were positioned manually because constrained layout moves them. However, in 3.4 we took them out of the layout altog...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/19805

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:89f8e1e4-67cb-6149-86eb-e872326824de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDFAE:3614ED:C40282:101F497:6A5190E4
html-safe-nonce76e803108f10cea35093bbdc494eec353983891f51e8ba96d18c2c118b67c2de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkFFOjM2MTRFRDpDNDAyODI6MTAxRjQ5Nzo2QTUxOTBFNCIsInZpc2l0b3JfaWQiOiIxMDYzMTE4NjI3OTA0MDAwMjI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0735ff8bddb81a6642bb20bbb0f02f9cbfbcfe834bbf06deaf3fd308456c3a1b
hovercard-subject-tagpull_request:602187340
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/19805/files
twitter:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
og:image:altPR Summary Closes: #19803 Subtitles should not be in constrained layout if they were positioned manually because constrained layout moves them. However, in 3.4 we took them out of the layout altog...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/19805/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19805%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19805%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/19805/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/19805/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/19805/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19805/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19805/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-suptitle-out-of-layouthttps://github.com/jklymak/matplotlib/tree/fix-suptitle-out-of-layout
Conversation 8 https://github.com/matplotlib/matplotlib/pull/19805
Commits 1 https://github.com/matplotlib/matplotlib/pull/19805/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/19805/checks
Files changed https://github.com/matplotlib/matplotlib/pull/19805/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19805/files
Fix suptitle out of layout https://github.com/matplotlib/matplotlib/pull/19805/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/19805/files
6924c26 FIX: fix taking suptitle (and friends) out of get_tightbbox jklymak Mar 24, 2021 https://github.com/matplotlib/matplotlib/pull/19805/commits/6924c26ebf8b14bc92bbf2a5c7df5648dc8d5409
Clear filters https://github.com/matplotlib/matplotlib/pull/19805/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19805/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19805/files
_constrained_layout.py https://github.com/matplotlib/matplotlib/pull/19805/files#diff-ec400fe5385be373ec266d3c296f8b3cb7bb327cc4b05b406e8d591fcb5eadf7
figure.py https://github.com/matplotlib/matplotlib/pull/19805/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
bbox_inches_tight_suptile_non_default.png https://github.com/matplotlib/matplotlib/pull/19805/files#diff-7c1eee035150526b1c4e603f5ad60fec81fff9169514fa70230212a7cc3316c8
test_bbox_tight.py https://github.com/matplotlib/matplotlib/pull/19805/files#diff-f2f0f12dbfe63ae94e21688d3465b81421c6a1c1d8876766a905040d449b14c8
lib/matplotlib/_constrained_layout.pyhttps://github.com/matplotlib/matplotlib/pull/19805/files#diff-ec400fe5385be373ec266d3c296f8b3cb7bb327cc4b05b406e8d591fcb5eadf7
View file https://github.com/jklymak/matplotlib/blob/6924c26ebf8b14bc92bbf2a5c7df5648dc8d5409/lib/matplotlib/_constrained_layout.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/19805/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/19805/files#diff-ec400fe5385be373ec266d3c296f8b3cb7bb327cc4b05b406e8d591fcb5eadf7
https://github.com/matplotlib/matplotlib/pull/19805/files#diff-ec400fe5385be373ec266d3c296f8b3cb7bb327cc4b05b406e8d591fcb5eadf7
lib/matplotlib/figure.pyhttps://github.com/matplotlib/matplotlib/pull/19805/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
View file https://github.com/jklymak/matplotlib/blob/6924c26ebf8b14bc92bbf2a5c7df5648dc8d5409/lib/matplotlib/figure.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/19805/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/19805/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/19805/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/19805/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
...tests/baseline_images/test_bbox_tight/bbox_inches_tight_suptile_non_default.pnghttps://github.com/matplotlib/matplotlib/pull/19805/files#diff-7c1eee035150526b1c4e603f5ad60fec81fff9169514fa70230212a7cc3316c8
View file https://github.com/jklymak/matplotlib/blob/6924c26ebf8b14bc92bbf2a5c7df5648dc8d5409/lib/matplotlib/tests/baseline_images/test_bbox_tight/bbox_inches_tight_suptile_non_default.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/19805/files
lib/matplotlib/tests/test_bbox_tight.pyhttps://github.com/matplotlib/matplotlib/pull/19805/files#diff-f2f0f12dbfe63ae94e21688d3465b81421c6a1c1d8876766a905040d449b14c8
View file https://github.com/jklymak/matplotlib/blob/6924c26ebf8b14bc92bbf2a5c7df5648dc8d5409/lib/matplotlib/tests/test_bbox_tight.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/19805/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/19805/files#diff-f2f0f12dbfe63ae94e21688d3465b81421c6a1c1d8876766a905040d449b14c8
https://github.com/matplotlib/matplotlib/pull/19805/files#diff-f2f0f12dbfe63ae94e21688d3465b81421c6a1c1d8876766a905040d449b14c8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.