René's URL Explorer Experiment


Title: Fix for issue 17769: wx interactive figure close cause crash by tohc1 · Pull Request #19596 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix for issue 17769: wx interactive figure close cause crash by tohc1 · Pull Request #19596 · matplotlib/matplotlib

X Title: Fix for issue 17769: wx interactive figure close cause crash by tohc1 · Pull Request #19596 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary Fix for issue #17769 On figure window (FigureFrameWx) close - remove figure manager from from Gcf class previously Gcf.destroy was called with FigureFrameWx not FigureManagerWx instanc...

X Description: PR Summary Fix for issue #17769 On figure window (FigureFrameWx) close - remove figure manager from from Gcf class previously Gcf.destroy was called with FigureFrameWx not FigureManagerWx instanc...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/19596

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:31254475-1dfb-a9ac-3ef4-ca71ba5089ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE7E2:13EA66:815E67:AF28AE:6A51501E
html-safe-nonce3b8d63f94d2e4fccd7492d586ca771f0ce2c1888ed3f70545da4c595af44730e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0UyOjEzRUE2Njo4MTVFNjc6QUYyOEFFOjZBNTE1MDFFIiwidmlzaXRvcl9pZCI6IjIwODY3ODM3OTE4MTczNzk4NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf04caa79cf1a632699a8d6e6ee1f2b17b38c31b55ac6c7bd9aa19856b603e89d
hovercard-subject-tagpull_request:581128735
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/19596/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/24c811ca1c6dd5567c9491bc39853e559a77398a7e10bc9c124a5018cbe57980/matplotlib/matplotlib/pull/19596
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/24c811ca1c6dd5567c9491bc39853e559a77398a7e10bc9c124a5018cbe57980/matplotlib/matplotlib/pull/19596
og:image:altPR Summary Fix for issue #17769 On figure window (FigureFrameWx) close - remove figure manager from from Gcf class previously Gcf.destroy was called with FigureFrameWx not FigureManagerWx instanc...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametohc1
hostnamegithub.com
expected-hostnamegithub.com
None6f17634ed2af1d116850bcea6c63a70a4d72970f33ade1dd3eef3764b7e16994
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release511bff6ea06e144ed085ff736aea4c6404987b00
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/19596#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19596
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19596
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/19596
Reloadhttps://github.com/matplotlib/matplotlib/pull/19596
Reloadhttps://github.com/matplotlib/matplotlib/pull/19596
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tohc1:wx_interactive_fixhttps://github.com/tohc1/matplotlib/tree/wx_interactive_fix
Conversationhttps://github.com/matplotlib/matplotlib/pull/19596
Commits7 (7)https://github.com/matplotlib/matplotlib/pull/19596/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/19596/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/19596/files
Fix for issue 17769: wx interactive figure close cause crashhttps://github.com/matplotlib/matplotlib/pull/19596#top
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tohc1:wx_interactive_fixhttps://github.com/tohc1/matplotlib/tree/wx_interactive_fix
https://github.com/tohc1
tohc1https://github.com/tohc1
Feb 26, 2021https://github.com/matplotlib/matplotlib/pull/19596#issue-817676650
#17769https://github.com/matplotlib/matplotlib/issues/17769
Flake 8https://flake8.pycqa.org/en/latest/
buildhttps://matplotlib.org/devel/documenting_mpl.html#building-the-docs
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
https://github.com/tohc1
Fix for issuehttps://github.com/matplotlib/matplotlib/pull/19596/commits/d165b0a1dc9898cb296c3ffbe1d1abd54fb132a9
matplotlib#17769https://github.com/matplotlib/matplotlib/issues/17769
d165b0ahttps://github.com/matplotlib/matplotlib/pull/19596/commits/d165b0a1dc9898cb296c3ffbe1d1abd54fb132a9
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 26, 2021 https://github.com/matplotlib/matplotlib/pull/19596#pullrequestreview-599960417
View reviewed changes https://github.com/matplotlib/matplotlib/pull/19596/files/d165b0a1dc9898cb296c3ffbe1d1abd54fb132a9
github-actionshttps://github.com/apps/github-actions
https://github.com/matplotlib/matplotlib/pull/19596#pullrequestreview-599960417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
on gitterhttps://gitter.im/matplotlib/matplotlib
the developer guidehttps://matplotlib.org/devdocs/devel/index.html
Code of Conducthttps://github.com/matplotlib/matplotlib/blob/master/CODE_OF_CONDUCT.md
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
tohc1https://github.com/tohc1
February 27, 2021 12:52https://github.com/matplotlib/matplotlib/pull/19596#commits-pushed-c7c727d
https://github.com/tohc1
Make plt.close() call thread safe to pass interactive backend testshttps://github.com/matplotlib/matplotlib/pull/19596/commits/c7c727d2be53b446f0549063fc43609ec7a28174
c7c727dhttps://github.com/matplotlib/matplotlib/pull/19596/commits/c7c727d2be53b446f0549063fc43609ec7a28174
https://github.com/tohc1
Linting fixeshttps://github.com/matplotlib/matplotlib/pull/19596/commits/329a5f20367941bdcaa896859f8481a98edc16f6
329a5f2https://github.com/matplotlib/matplotlib/pull/19596/commits/329a5f20367941bdcaa896859f8481a98edc16f6
https://github.com/tohc1
tohc1https://github.com/tohc1
Feb 27, 2021https://github.com/matplotlib/matplotlib/pull/19596#issuecomment-787084415
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 1, 2021 https://github.com/matplotlib/matplotlib/pull/19596#pullrequestreview-600863188
View reviewed changes https://github.com/matplotlib/matplotlib/pull/19596/files/329a5f20367941bdcaa896859f8481a98edc16f6
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 1, 2021https://github.com/matplotlib/matplotlib/pull/19596#issuecomment-788041137
@tohc1https://github.com/tohc1
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
Mar 1, 2021https://github.com/matplotlib/matplotlib/pull/19596#event-4390287103
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 1, 2021 https://github.com/matplotlib/matplotlib/pull/19596#pullrequestreview-601269976
View reviewed changes https://github.com/matplotlib/matplotlib/pull/19596/files/329a5f20367941bdcaa896859f8481a98edc16f6
lib/matplotlib/backends/backend_wx.pyhttps://github.com/matplotlib/matplotlib/pull/19596/files/329a5f20367941bdcaa896859f8481a98edc16f6#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
lib/matplotlib/backends/backend_wx.pyhttps://github.com/matplotlib/matplotlib/pull/19596/files/329a5f20367941bdcaa896859f8481a98edc16f6#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
lib/matplotlib/backends/backend_wx.pyhttps://github.com/matplotlib/matplotlib/pull/19596/files/329a5f20367941bdcaa896859f8481a98edc16f6#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
lib/matplotlib/backends/backend_wx.pyhttps://github.com/matplotlib/matplotlib/pull/19596/files/329a5f20367941bdcaa896859f8481a98edc16f6#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
tohc1https://github.com/tohc1
March 2, 2021 20:09https://github.com/matplotlib/matplotlib/pull/19596#commits-pushed-b5f5118
https://github.com/tohc1
https://github.com/QuLogic
Apply suggestions from code reviewhttps://github.com/matplotlib/matplotlib/pull/19596/commits/b5f5118beddcf65f52114fe90037f701529b2e62
b5f5118https://github.com/matplotlib/matplotlib/pull/19596/commits/b5f5118beddcf65f52114fe90037f701529b2e62
https://github.com/tohc1
Remove unneeded check for Nonehttps://github.com/matplotlib/matplotlib/pull/19596/commits/b9b40d14af0e99545751d42a01f0ffe80f409cdf
b9b40d1https://github.com/matplotlib/matplotlib/pull/19596/commits/b9b40d14af0e99545751d42a01f0ffe80f409cdf
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 2, 2021 https://github.com/matplotlib/matplotlib/pull/19596#pullrequestreview-602341047
View reviewed changes https://github.com/matplotlib/matplotlib/pull/19596/files/b9b40d14af0e99545751d42a01f0ffe80f409cdf
QuLogichttps://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/19596#pullrequestreview-602341047
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
lib/matplotlib/backends/backend_wx.pyhttps://github.com/matplotlib/matplotlib/pull/19596/files/b9b40d14af0e99545751d42a01f0ffe80f409cdf#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
tohc1https://github.com/tohc1
March 3, 2021 15:50https://github.com/matplotlib/matplotlib/pull/19596#commits-pushed-42bf181
https://github.com/tohc1
https://github.com/QuLogic
Update lib/matplotlib/backends/backend_wx.pyhttps://github.com/matplotlib/matplotlib/pull/19596/commits/42bf18142f29597877835b3ef040e78695f7b2dc
42bf181https://github.com/matplotlib/matplotlib/pull/19596/commits/42bf18142f29597877835b3ef040e78695f7b2dc
https://github.com/tohc1
Update backend_wx.pyhttps://github.com/matplotlib/matplotlib/pull/19596/commits/1852052c160f13aece9fb0eca157e5d3da03b36e
1852052https://github.com/matplotlib/matplotlib/pull/19596/commits/1852052c160f13aece9fb0eca157e5d3da03b36e
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
b7d57c9https://github.com/matplotlib/matplotlib/commit/b7d57c9d6d1ec0076358da0b8f01cdd7c5b6c552
Mar 3, 2021https://github.com/matplotlib/matplotlib/pull/19596#event-4404048428
meeseeksmachinehttps://github.com/meeseeksmachine
Mar 3, 2021 https://github.com/matplotlib/matplotlib/pull/19596#ref-commit-ed2827a
https://github.com/tacaswell
https://github.com/meeseeksmachine
Backport PRhttps://github.com/meeseeksmachine/matplotlib/commit/ed2827ac3a829fe29174bcfb6f10fbafcbbb2574
matplotlib#19596https://github.com/matplotlib/matplotlib/pull/19596
: Fix for issue 17769: wx interactive fig…https://github.com/meeseeksmachine/matplotlib/commit/ed2827ac3a829fe29174bcfb6f10fbafcbbb2574
ed2827ahttps://github.com/meeseeksmachine/matplotlib/commit/ed2827ac3a829fe29174bcfb6f10fbafcbbb2574
https://github.com/meeseeksmachine
meeseeksmachinehttps://github.com/meeseeksmachine
Mar 3, 2021 https://github.com/matplotlib/matplotlib/pull/19596#ref-pullrequest-821439041
Backport PR #19596 on branch v3.4.x (Fix for issue 17769: wx interactive figure close cause crash) #19630 https://github.com/matplotlib/matplotlib/pull/19630
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 3, 2021https://github.com/matplotlib/matplotlib/pull/19596#issuecomment-790017902
@tohc1https://github.com/tohc1
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
GUI: wx https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20wx%22
Mar 3, 2021https://github.com/matplotlib/matplotlib/pull/19596#event-4404604966
QuLogichttps://github.com/QuLogic
Mar 3, 2021 https://github.com/matplotlib/matplotlib/pull/19596#ref-commit-7a3b3b6
https://github.com/QuLogic
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/7a3b3b6b3e163c37f1f834bd415268b76233987e
#19630https://github.com/matplotlib/matplotlib/pull/19630
from meeseeksmachine/auto-backport-of-pr-19…https://github.com/matplotlib/matplotlib/commit/7a3b3b6b3e163c37f1f834bd415268b76233987e
7a3b3b6https://github.com/matplotlib/matplotlib/commit/7a3b3b6b3e163c37f1f834bd415268b76233987e
#19596https://github.com/matplotlib/matplotlib/pull/19596
https://github.com/carandraug
carandraughttps://github.com/carandraug
Apr 1, 2021 https://github.com/matplotlib/matplotlib/pull/19596#ref-issue-826568236
Display last Experiment in debug only runs once. microscope-cockpit/cockpit#725 https://github.com/microscope-cockpit/cockpit/issues/725
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19596
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/19596/files/329a5f20367941bdcaa896859f8481a98edc16f6
https://github.com/apps/github-actions
github-actions[bot] https://github.com/apps/github-actions
https://github.com/matplotlib/matplotlib/pull/19596/files/d165b0a1dc9898cb296c3ffbe1d1abd54fb132a9
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/19596/files/b9b40d14af0e99545751d42a01f0ffe80f409cdf
GUI: wx https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20wx%22
v3.4.0 https://github.com/matplotlib/matplotlib/milestone/53
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19596
https://github.com/tohc1
https://github.com/tacaswell
https://github.com/QuLogic
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.