René's URL Explorer Experiment


Title: Fix example's BasicUnit array conversion. by QuLogic · Pull Request #19535 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix example's BasicUnit array conversion. by QuLogic · Pull Request #19535 · matplotlib/matplotlib

X Title: Fix example's BasicUnit array conversion. by QuLogic · Pull Request #19535 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary The unit examples are broken in NumPy < 1.20. This fixes a bug that was exposed by #19415 , but does not fix the examples fully. radian_demo is fixed by this change, but ellipse_with_...

X Description: PR Summary The unit examples are broken in NumPy &lt; 1.20. This fixes a bug that was exposed by #19415 , but does not fix the examples fully. radian_demo is fixed by this change, but ellipse_w...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/19535

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9dce5053-7b2b-ae59-8e7e-99ee3e3b8e8e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB44:B0958:E86F4:130F46:6A51619E
html-safe-nonce9821adc0af9ee8b487f2020e60a678dd2e8018497da22222c23867759ebc1771
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjQ0OkIwOTU4OkU4NkY0OjEzMEY0Njo2QTUxNjE5RSIsInZpc2l0b3JfaWQiOiI1NjUzMjcxNzQ2MTg4NTAxNDA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac82b4f6e45ebeb1893e4261095a9c22e95156a2ba7868bb9a1f9c9529e350104d
hovercard-subject-tagpull_request:575439616
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/19535/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b4fc3eb7004b4e4bda52bad3042bce65d543b507ca5f97eac4f2da8026677dfa/matplotlib/matplotlib/pull/19535
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b4fc3eb7004b4e4bda52bad3042bce65d543b507ca5f97eac4f2da8026677dfa/matplotlib/matplotlib/pull/19535
og:image:altPR Summary The unit examples are broken in NumPy < 1.20. This fixes a bug that was exposed by #19415 , but does not fix the examples fully. radian_demo is fixed by this change, but ellipse_with_...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameQuLogic
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2eeb434949a926fad21064b4d395a54759f7a0b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/19535#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19535
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19535
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/19535
Reloadhttps://github.com/matplotlib/matplotlib/pull/19535
Reloadhttps://github.com/matplotlib/matplotlib/pull/19535
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
QuLogic:fix-units-old-nphttps://github.com/QuLogic/matplotlib/tree/fix-units-old-np
Conversationhttps://github.com/matplotlib/matplotlib/pull/19535
Commits3 (3)https://github.com/matplotlib/matplotlib/pull/19535/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/19535/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/19535/files
Fix example's BasicUnit array conversion.https://github.com/matplotlib/matplotlib/pull/19535#top
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
QuLogic:fix-units-old-nphttps://github.com/QuLogic/matplotlib/tree/fix-units-old-np
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Feb 18, 2021https://github.com/matplotlib/matplotlib/pull/19535#issue-810811205
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
#19415https://github.com/matplotlib/matplotlib/pull/19415
#19415https://github.com/matplotlib/matplotlib/pull/19415
#19415https://github.com/matplotlib/matplotlib/pull/19415
Flake 8https://flake8.pycqa.org/en/latest/
buildhttps://matplotlib.org/devel/documenting_mpl.html#building-the-docs
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Documentation https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3ADocumentation
topic: units and array ducktypes https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20units%20and%20array%20ducktypes%22
Feb 18, 2021https://github.com/matplotlib/matplotlib/pull/19535#event-4345066338
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
Feb 18, 2021https://github.com/matplotlib/matplotlib/pull/19535#event-4345066347
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Feb 18, 2021https://github.com/matplotlib/matplotlib/pull/19535#issuecomment-781102600
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
@dstansbyhttps://github.com/dstansby
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Feb 19, 2021https://github.com/matplotlib/matplotlib/pull/19535#issuecomment-781716754
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Feb 19, 2021https://github.com/matplotlib/matplotlib/pull/19535#issuecomment-781722353
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
force-pushedhttps://github.com/matplotlib/matplotlib/compare/dc89ababe36718c344ab60dda06502d4a0ba3e06..64a66b0a866a82250a883e0eea7bbae25bcedefd
dc89abahttps://github.com/matplotlib/matplotlib/commit/dc89ababe36718c344ab60dda06502d4a0ba3e06
64a66b0https://github.com/matplotlib/matplotlib/commit/64a66b0a866a82250a883e0eea7bbae25bcedefd
Compare https://github.com/matplotlib/matplotlib/compare/dc89ababe36718c344ab60dda06502d4a0ba3e06..64a66b0a866a82250a883e0eea7bbae25bcedefd
March 24, 2021 01:15https://github.com/matplotlib/matplotlib/pull/19535#event-4499254485
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
force-pushedhttps://github.com/matplotlib/matplotlib/compare/64a66b0a866a82250a883e0eea7bbae25bcedefd..46ad1c94e48cf22959e9d802df0ca31b529a98f4
64a66b0https://github.com/matplotlib/matplotlib/commit/64a66b0a866a82250a883e0eea7bbae25bcedefd
46ad1c9https://github.com/matplotlib/matplotlib/commit/46ad1c94e48cf22959e9d802df0ca31b529a98f4
Compare https://github.com/matplotlib/matplotlib/compare/64a66b0a866a82250a883e0eea7bbae25bcedefd..46ad1c94e48cf22959e9d802df0ca31b529a98f4
March 25, 2021 00:01https://github.com/matplotlib/matplotlib/pull/19535#event-4505036356
QuLogichttps://github.com/QuLogic
March 25, 2021 04:16https://github.com/matplotlib/matplotlib/pull/19535#commits-pushed-2078daa
https://github.com/QuLogic
Fix example's BasicUnit array conversion.https://github.com/matplotlib/matplotlib/pull/19535/commits/2078daa9bc5189c95f0a1f86d2e8a449505ecb49
2078daahttps://github.com/matplotlib/matplotlib/pull/19535/commits/2078daa9bc5189c95f0a1f86d2e8a449505ecb49
matplotlib#19415https://github.com/matplotlib/matplotlib/pull/19415
https://github.com/QuLogic
ci: Install Python dependencies in one go on Circle.https://github.com/matplotlib/matplotlib/pull/19535/commits/9038b45d1ba2ef53c84a1c81a8f1883e1240464f
9038b45https://github.com/matplotlib/matplotlib/pull/19535/commits/9038b45d1ba2ef53c84a1c81a8f1883e1240464f
https://github.com/QuLogic
DOC: Only define __getitem__ on NumPy 1.20+.https://github.com/matplotlib/matplotlib/pull/19535/commits/3488dc7764c32bff3550d740302d471a83fb0430
3488dc7https://github.com/matplotlib/matplotlib/pull/19535/commits/3488dc7764c32bff3550d740302d471a83fb0430
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
force-pushedhttps://github.com/matplotlib/matplotlib/compare/46ad1c94e48cf22959e9d802df0ca31b529a98f4..3488dc7764c32bff3550d740302d471a83fb0430
46ad1c9https://github.com/matplotlib/matplotlib/commit/46ad1c94e48cf22959e9d802df0ca31b529a98f4
3488dc7https://github.com/matplotlib/matplotlib/commit/3488dc7764c32bff3550d740302d471a83fb0430
Compare https://github.com/matplotlib/matplotlib/compare/46ad1c94e48cf22959e9d802df0ca31b529a98f4..3488dc7764c32bff3550d740302d471a83fb0430
March 25, 2021 08:30https://github.com/matplotlib/matplotlib/pull/19535#event-4506409038
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Mar 25, 2021https://github.com/matplotlib/matplotlib/pull/19535#issuecomment-806813700
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 25, 2021 https://github.com/matplotlib/matplotlib/pull/19535#pullrequestreview-621502926
View reviewed changes https://github.com/matplotlib/matplotlib/pull/19535/files/3488dc7764c32bff3550d740302d471a83fb0430
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
1fdc2cdhttps://github.com/matplotlib/matplotlib/commit/1fdc2cda42f642a09dea727ba058efa75dd5cc2e
Mar 25, 2021https://github.com/matplotlib/matplotlib/pull/19535#event-4509772537
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Mar 25, 2021https://github.com/matplotlib/matplotlib/pull/19535#issuecomment-807333030
#19535https://github.com/matplotlib/matplotlib/pull/19535
suggest an improvementhttps://github.com/MeeseeksBox/MeeseeksDev
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Still Needs Manual Backport https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22
Mar 25, 2021https://github.com/matplotlib/matplotlib/pull/19535#event-4509775214
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
March 25, 2021 19:31https://github.com/matplotlib/matplotlib/pull/19535#event-4509791307
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 25, 2021https://github.com/matplotlib/matplotlib/pull/19535#issuecomment-807342603
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 25, 2021https://github.com/matplotlib/matplotlib/pull/19535#issuecomment-807485485
@meeseeksdevhttps://github.com/meeseeksdev
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
https://github.com/meeseeksmachine
meeseeksmachinehttps://github.com/meeseeksmachine
Mar 25, 2021 https://github.com/matplotlib/matplotlib/pull/19535#ref-pullrequest-841307377
Backport PR #19535 on branch v3.4.x (Fix example's BasicUnit array conversion.) #19772 https://github.com/matplotlib/matplotlib/pull/19772
meeseeksmachinehttps://github.com/meeseeksmachine
Mar 25, 2021 https://github.com/matplotlib/matplotlib/pull/19535#ref-commit-b46c7c5
https://github.com/tacaswell
https://github.com/meeseeksmachine
Backport PRhttps://github.com/meeseeksmachine/matplotlib/commit/b46c7c5d2a3f935c572b52c1353cf4b3e32a9974
matplotlib#19535https://github.com/matplotlib/matplotlib/pull/19535
: Fix example's BasicUnit array conversion.https://github.com/meeseeksmachine/matplotlib/commit/b46c7c5d2a3f935c572b52c1353cf4b3e32a9974
b46c7c5https://github.com/meeseeksmachine/matplotlib/commit/b46c7c5d2a3f935c572b52c1353cf4b3e32a9974
QuLogichttps://github.com/QuLogic
Mar 25, 2021 https://github.com/matplotlib/matplotlib/pull/19535#ref-commit-bdb7774
https://github.com/QuLogic
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/bdb7774bc0fcf7cb69408e118c67cbdfe60a8ec1
#19772https://github.com/matplotlib/matplotlib/pull/19772
from meeseeksmachine/auto-backport-of-pr-19…https://github.com/matplotlib/matplotlib/commit/bdb7774bc0fcf7cb69408e118c67cbdfe60a8ec1
bdb7774https://github.com/matplotlib/matplotlib/commit/bdb7774bc0fcf7cb69408e118c67cbdfe60a8ec1
#19535https://github.com/matplotlib/matplotlib/pull/19535
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Still Needs Manual Backport https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22
Mar 31, 2021https://github.com/matplotlib/matplotlib/pull/19535#event-4532052384
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Apr 1, 2021 https://github.com/matplotlib/matplotlib/pull/19535#ref-issue-847784460
basic units example's subclassing is broken #19841 https://github.com/matplotlib/matplotlib/issues/19841
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19535
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/19535/files/3488dc7764c32bff3550d740302d471a83fb0430
Documentation https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3ADocumentation
topic: units and array ducktypes https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20units%20and%20array%20ducktypes%22
v3.4.0 https://github.com/matplotlib/matplotlib/milestone/53
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19535
https://github.com/QuLogic
https://github.com/tacaswell
https://github.com/jklymak
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.