René's URL Explorer Experiment


Title: Fix build with LTO disabled in environment by QuLogic · Pull Request #19238 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix build with LTO disabled in environment by QuLogic · Pull Request #19238 · matplotlib/matplotlib

X Title: Fix build with LTO disabled in environment by QuLogic · Pull Request #19238 · matplotlib/matplotlib

Description: PR Summary Fixes #19227. PR Checklist [n/a] Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). [n/a] New features are documented, with examples if plot related. [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all). [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Open Graph Description: PR Summary Fixes #19227. PR Checklist [n/a] Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). [n/a] New features are documented, with e...

X Description: PR Summary Fixes #19227. PR Checklist [n/a] Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). [n/a] New features are documented, with e...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/19238

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:34544b9a-ffb0-9388-8e3f-e79f1c553eec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD0A6:36F659:11B043:182206:6A55348E
html-safe-nonce5680dbcaed949c3dc72fe704cc6f053ee45f339fe4d63c20b02420a07145d1f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEE2OjM2RjY1OToxMUIwNDM6MTgyMjA2OjZBNTUzNDhFIiwidmlzaXRvcl9pZCI6IjgzNjQxNTUzNzg1NzgzMDYxOTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9be85d76d7e1ad1a6ff75ce3e8d09f9ee4b24ea494ec386fc9fd1477e77b2fb7
hovercard-subject-tagpull_request:548534888
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/19238/files
twitter:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302469?s=400&v=4
og:image:altPR Summary Fixes #19227. PR Checklist [n/a] Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). [n/a] New features are documented, with e...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefbd8fce4d63ac394c5405faa20aa50d5c9e56b979ac43ee1b26f8e7c47c4cd89
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecf96660b44878f418b09d3d6ecde00ad62332910
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/19238/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19238%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19238%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/19238/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/19238/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/19238/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19238/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19238/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
QuLogic:disable-ltohttps://github.com/QuLogic/matplotlib/tree/disable-lto
Conversation 22 https://github.com/matplotlib/matplotlib/pull/19238
Commits 4 https://github.com/matplotlib/matplotlib/pull/19238/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/19238/checks
Files changed https://github.com/matplotlib/matplotlib/pull/19238/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19238/files
Fix build with LTO disabled in environment https://github.com/matplotlib/matplotlib/pull/19238/files#top
Show all changes 4 commits https://github.com/matplotlib/matplotlib/pull/19238/files
4155d91 Disable LTO if -fno-lto is in *FLAGS environment. QuLogic Jan 4, 2021 https://github.com/matplotlib/matplotlib/pull/19238/commits/4155d918bb2b0ef7c902cad9df9a58565413387b
a786d2a Inline convert_voidptr to tkagg. QuLogic Jan 27, 2021 https://github.com/matplotlib/matplotlib/pull/19238/commits/a786d2a3e09b4853aaa7d5d60089a6e0dbc8b444
8bb0379 Disable LTO in one test configuration. QuLogic Jan 14, 2021 https://github.com/matplotlib/matplotlib/pull/19238/commits/8bb0379feb00ae6f00530eec2643f5752a3c89b0
988bfc5 Reduce redundancy while checking *FLAGS for LTO. QuLogic Jan 27, 2021 https://github.com/matplotlib/matplotlib/pull/19238/commits/988bfc597c96bcf7f5be802df4c7c8ed39e85e06
Clear filters https://github.com/matplotlib/matplotlib/pull/19238/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19238/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19238/files
tests.yml https://github.com/matplotlib/matplotlib/pull/19238/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957f
setup.py https://github.com/matplotlib/matplotlib/pull/19238/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
setupext.py https://github.com/matplotlib/matplotlib/pull/19238/files#diff-113dbd0ff67f6e8e817884a3e98962eec6856df1fb826932442487e374b827f0
_tkagg.cpp https://github.com/matplotlib/matplotlib/pull/19238/files#diff-3738bd01dcd1fd4455918f1845644a116249a0c94b2f8663e905a7ea909460d3
py_converters.cpp https://github.com/matplotlib/matplotlib/pull/19238/files#diff-208ad6082c53f7a1ccf5e9e9a8b8798b75452f8324599d555e09b02f45dfbae5
py_converters.h https://github.com/matplotlib/matplotlib/pull/19238/files#diff-9a010dee0bbc8d3d6a015ede097edf7085423385426b40183a0f1fa627dd8c78
.github/workflows/tests.ymlhttps://github.com/matplotlib/matplotlib/pull/19238/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957f
View file https://github.com/QuLogic/matplotlib/blob/988bfc597c96bcf7f5be802df4c7c8ed39e85e06/.github/workflows/tests.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/19238/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957f
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957f
setup.pyhttps://github.com/matplotlib/matplotlib/pull/19238/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
View file https://github.com/QuLogic/matplotlib/blob/988bfc597c96bcf7f5be802df4c7c8ed39e85e06/setup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/19238/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
setupext.pyhttps://github.com/matplotlib/matplotlib/pull/19238/files#diff-113dbd0ff67f6e8e817884a3e98962eec6856df1fb826932442487e374b827f0
View file https://github.com/QuLogic/matplotlib/blob/988bfc597c96bcf7f5be802df4c7c8ed39e85e06/setupext.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/19238/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-113dbd0ff67f6e8e817884a3e98962eec6856df1fb826932442487e374b827f0
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-113dbd0ff67f6e8e817884a3e98962eec6856df1fb826932442487e374b827f0
src/_tkagg.cpphttps://github.com/matplotlib/matplotlib/pull/19238/files#diff-3738bd01dcd1fd4455918f1845644a116249a0c94b2f8663e905a7ea909460d3
View file https://github.com/QuLogic/matplotlib/blob/988bfc597c96bcf7f5be802df4c7c8ed39e85e06/src/_tkagg.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/19238/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-3738bd01dcd1fd4455918f1845644a116249a0c94b2f8663e905a7ea909460d3
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-3738bd01dcd1fd4455918f1845644a116249a0c94b2f8663e905a7ea909460d3
src/py_converters.cpphttps://github.com/matplotlib/matplotlib/pull/19238/files#diff-208ad6082c53f7a1ccf5e9e9a8b8798b75452f8324599d555e09b02f45dfbae5
View file https://github.com/QuLogic/matplotlib/blob/988bfc597c96bcf7f5be802df4c7c8ed39e85e06/src/py_converters.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/19238/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-208ad6082c53f7a1ccf5e9e9a8b8798b75452f8324599d555e09b02f45dfbae5
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-208ad6082c53f7a1ccf5e9e9a8b8798b75452f8324599d555e09b02f45dfbae5
src/py_converters.hhttps://github.com/matplotlib/matplotlib/pull/19238/files#diff-9a010dee0bbc8d3d6a015ede097edf7085423385426b40183a0f1fa627dd8c78
View file https://github.com/QuLogic/matplotlib/blob/988bfc597c96bcf7f5be802df4c7c8ed39e85e06/src/py_converters.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/19238/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-9a010dee0bbc8d3d6a015ede097edf7085423385426b40183a0f1fa627dd8c78
https://github.com/matplotlib/matplotlib/pull/19238/files#diff-9a010dee0bbc8d3d6a015ede097edf7085423385426b40183a0f1fa627dd8c78
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.