René's URL Explorer Experiment


Title: Ignore CLOSEPOLY vertices when computing dataLim from patches by jsberg-bnl · Pull Request #19088 · matplotlib/matplotlib · GitHub

Open Graph Title: Ignore CLOSEPOLY vertices when computing dataLim from patches by jsberg-bnl · Pull Request #19088 · matplotlib/matplotlib

X Title: Ignore CLOSEPOLY vertices when computing dataLim from patches by jsberg-bnl · Pull Request #19088 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary CLOSEPOLY verticies are not actual points in a path, but _update_patch_limits uses them anyhow when computing dataLim. This patch removes the CLOSEPOLY vertices from the list of vertices...

X Description: PR Summary CLOSEPOLY verticies are not actual points in a path, but _update_patch_limits uses them anyhow when computing dataLim. This patch removes the CLOSEPOLY vertices from the list of vertices...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/19088

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5059a675-89d5-85ce-fc6d-5372bce944f0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD758:E05E1:CDA1F:1130CF:6A526BB3
html-safe-nonced330d5b92137da308ce5f84997ddc9d38c9d61c70ac5251e89e5b511cd442835
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzU4OkUwNUUxOkNEQTFGOjExMzBDRjo2QTUyNkJCMyIsInZpc2l0b3JfaWQiOiIzNDk0Nzc0MTMxMjk5MzQ3Mzc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac943dc8e9a3bc1c38741e7168f7fb26c77f3d6d87c2fbbbc3fa9790a7ed6526d3
hovercard-subject-tagpull_request:535473785
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/19088/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4812858a5ede3e1dbbf57cec518064a9fcfdfb6981ce639ebae62d796172b043/matplotlib/matplotlib/pull/19088
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4812858a5ede3e1dbbf57cec518064a9fcfdfb6981ce639ebae62d796172b043/matplotlib/matplotlib/pull/19088
og:image:altPR Summary CLOSEPOLY verticies are not actual points in a path, but _update_patch_limits uses them anyhow when computing dataLim. This patch removes the CLOSEPOLY vertices from the list of vertices...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejsberg-bnl
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/19088#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19088
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19088
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/19088
Reloadhttps://github.com/matplotlib/matplotlib/pull/19088
Reloadhttps://github.com/matplotlib/matplotlib/pull/19088
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19088
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19088
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jsberg-bnl:issue-19078https://github.com/jsberg-bnl/matplotlib/tree/issue-19078
Conversationhttps://github.com/matplotlib/matplotlib/pull/19088
Commits6 (6)https://github.com/matplotlib/matplotlib/pull/19088/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/19088/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/19088/files
Ignore CLOSEPOLY vertices when computing dataLim from patcheshttps://github.com/matplotlib/matplotlib/pull/19088#top
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jsberg-bnl:issue-19078https://github.com/jsberg-bnl/matplotlib/tree/issue-19078
https://github.com/jsberg-bnl
jsberg-bnlhttps://github.com/jsberg-bnl
Dec 9, 2020https://github.com/matplotlib/matplotlib/pull/19088#issue-760683255
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19088
#19078https://github.com/matplotlib/matplotlib/issues/19078
Flake 8https://flake8.pycqa.org/en/latest/
buildhttps://matplotlib.org/devel/documenting_mpl.html#building-the-docs
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19088
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Dec 9, 2020 https://github.com/matplotlib/matplotlib/pull/19088#pullrequestreview-548695359
View reviewed changes https://github.com/matplotlib/matplotlib/pull/19088/files
lib/matplotlib/axes/_base.pyhttps://github.com/matplotlib/matplotlib/pull/19088/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19088
https://github.com/jsberg-bnl
jsberg-bnlhttps://github.com/jsberg-bnl
force-pushedhttps://github.com/matplotlib/matplotlib/compare/35eba0918952f1987963dbcb6579f739d63fd14e..edd8a64d54235a757ca5253b5b6d4e554735dd38
35eba09https://github.com/matplotlib/matplotlib/commit/35eba0918952f1987963dbcb6579f739d63fd14e
edd8a64https://github.com/matplotlib/matplotlib/commit/edd8a64d54235a757ca5253b5b6d4e554735dd38
Compare https://github.com/matplotlib/matplotlib/compare/35eba0918952f1987963dbcb6579f739d63fd14e..edd8a64d54235a757ca5253b5b6d4e554735dd38
December 11, 2020 02:50https://github.com/matplotlib/matplotlib/pull/19088#event-4098186691
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Dec 22, 2020 https://github.com/matplotlib/matplotlib/pull/19088#pullrequestreview-556887110
View reviewed changes https://github.com/matplotlib/matplotlib/pull/19088/files
lib/matplotlib/tests/test_axes.pyhttps://github.com/matplotlib/matplotlib/pull/19088/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19088
lib/matplotlib/tests/test_axes.pyhttps://github.com/matplotlib/matplotlib/pull/19088/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19088
jsberg-bnlhttps://github.com/jsberg-bnl
December 22, 2020 09:13https://github.com/matplotlib/matplotlib/pull/19088#commits-pushed-2f493e5
https://github.com/jsberg-bnl
Don't include CLOSEPOLY verticies when computing patch boundshttps://github.com/matplotlib/matplotlib/pull/19088/commits/2f493e501587597819ee19a09693e8dc457bffba
2f493e5https://github.com/matplotlib/matplotlib/pull/19088/commits/2f493e501587597819ee19a09693e8dc457bffba
https://github.com/jsberg-bnl
Make flake8 happyhttps://github.com/matplotlib/matplotlib/pull/19088/commits/fcd1699fc8f133b85129fa2d0719f14d8b855f3a
fcd1699https://github.com/matplotlib/matplotlib/pull/19088/commits/fcd1699fc8f133b85129fa2d0719f14d8b855f3a
https://github.com/jsberg-bnl
Add test for ingoring CLOSEPOLY verticies in patcheshttps://github.com/matplotlib/matplotlib/pull/19088/commits/57995b3f1b6cf64379f406e2261f0e6781b13dc4
57995b3https://github.com/matplotlib/matplotlib/pull/19088/commits/57995b3f1b6cf64379f406e2261f0e6781b13dc4
https://github.com/jsberg-bnl
Also ignore STOP verticies when computing boundshttps://github.com/matplotlib/matplotlib/pull/19088/commits/ad31040d77fec23a4038905500159b5d7ea25f12
ad31040https://github.com/matplotlib/matplotlib/pull/19088/commits/ad31040d77fec23a4038905500159b5d7ea25f12
https://github.com/jsberg-bnl
_update_patch_limits: use a simpler method to select the vertices to …https://github.com/matplotlib/matplotlib/pull/19088/commits/2e71850e3fb1dbb7b6696178dada05445bc4d326
2e71850https://github.com/matplotlib/matplotlib/pull/19088/commits/2e71850e3fb1dbb7b6696178dada05445bc4d326
https://github.com/jsberg-bnl
test_patch_bounds: use numpy in place of math/syshttps://github.com/matplotlib/matplotlib/pull/19088/commits/039e4163b543d12f31636cb45057d09ba8f88a15
039e416https://github.com/matplotlib/matplotlib/pull/19088/commits/039e4163b543d12f31636cb45057d09ba8f88a15
https://github.com/jsberg-bnl
jsberg-bnlhttps://github.com/jsberg-bnl
force-pushedhttps://github.com/matplotlib/matplotlib/compare/edd8a64d54235a757ca5253b5b6d4e554735dd38..039e4163b543d12f31636cb45057d09ba8f88a15
edd8a64https://github.com/matplotlib/matplotlib/commit/edd8a64d54235a757ca5253b5b6d4e554735dd38
039e416https://github.com/matplotlib/matplotlib/commit/039e4163b543d12f31636cb45057d09ba8f88a15
Compare https://github.com/matplotlib/matplotlib/compare/edd8a64d54235a757ca5253b5b6d4e554735dd38..039e4163b543d12f31636cb45057d09ba8f88a15
December 22, 2020 18:19https://github.com/matplotlib/matplotlib/pull/19088#event-4141267398
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Dec 23, 2020 https://github.com/matplotlib/matplotlib/pull/19088#pullrequestreview-557835338
View reviewed changes https://github.com/matplotlib/matplotlib/pull/19088/files/039e4163b543d12f31636cb45057d09ba8f88a15
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Dec 24, 2020 https://github.com/matplotlib/matplotlib/pull/19088#pullrequestreview-558278840
View reviewed changes https://github.com/matplotlib/matplotlib/pull/19088/files/039e4163b543d12f31636cb45057d09ba8f88a15
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
3798e5fhttps://github.com/matplotlib/matplotlib/commit/3798e5f916418854fa24b78ad27b62244c4059b6
Dec 24, 2020https://github.com/matplotlib/matplotlib/pull/19088#event-4145830637
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Dec 24, 2020https://github.com/matplotlib/matplotlib/pull/19088#issuecomment-750606333
@jsberg-bnlhttps://github.com/jsberg-bnl
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19088
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
Dec 24, 2020https://github.com/matplotlib/matplotlib/pull/19088#event-4145831213
https://github.com/dopplershift
dopplershifthttps://github.com/dopplershift
Dec 24, 2020 https://github.com/matplotlib/matplotlib/pull/19088#ref-pullrequest-772353068
Ignore closepoly vertices in _update_patch_limits. #19159 https://github.com/matplotlib/matplotlib/pull/19159
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F19088
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/19088/files/039e4163b543d12f31636cb45057d09ba8f88a15
https://github.com/timhoffm
timhoffm https://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/19088/files/039e4163b543d12f31636cb45057d09ba8f88a15
v3.4.0 https://github.com/matplotlib/matplotlib/milestone/53
_update_patch_limits should not use CLOSEPOLY vertices for updating https://github.com/matplotlib/matplotlib/issues/19078
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/19088
https://github.com/jsberg-bnl
https://github.com/QuLogic
https://github.com/timhoffm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.