René's URL Explorer Experiment


Title: Simplify wx rubberband drawing. by anntzer · Pull Request #18599 · matplotlib/matplotlib · GitHub

Open Graph Title: Simplify wx rubberband drawing. by anntzer · Pull Request #18599 · matplotlib/matplotlib

X Title: Simplify wx rubberband drawing. by anntzer · Pull Request #18599 · matplotlib/matplotlib

Description: Like for qt/gtk, it's much easier to just draw the rectangle at gui_repaint time. AFAICT this now works on Wayland too, and closes the rubberbanding part of #10417 / #11944. PR Summary PR Checklist Has pytest style unit tests (and pytest passes). Is Flake 8 compliant (run flake8 on changed files to check). New features are documented, with examples if plot related. Documentation is sphinx and numpydoc compliant (the docs should build without error). Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all). New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there). API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Open Graph Description: Like for qt/gtk, it's much easier to just draw the rectangle at gui_repaint time. AFAICT this now works on Wayland too, and closes the rubberbanding part of #10417 / #11944. PR Summary PR Check...

X Description: Like for qt/gtk, it&#39;s much easier to just draw the rectangle at gui_repaint time. AFAICT this now works on Wayland too, and closes the rubberbanding part of #10417 / #11944. PR Summary PR C...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/18599

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:95858b53-8d96-7b9d-16ca-a3081ad2db6f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2D2:10637F:14D5C2F:1B943BB:6A51BC87
html-safe-nonce82752cdc3b14bdc805d34c402280c53167725d6f6ee26f5a62177326a957090e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkQyOjEwNjM3RjoxNEQ1QzJGOjFCOTQzQkI6NkE1MUJDODciLCJ2aXNpdG9yX2lkIjoiNzA3Nzc5NDUyMTc2ODA5MDk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace1b88c8e422a1dc6ef64e1579b8ec82676b5873594b53634c8aa2e636fc7edd7
hovercard-subject-tagpull_request:494291423
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/18599/files
twitter:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
og:image:altLike for qt/gtk, it's much easier to just draw the rectangle at gui_repaint time. AFAICT this now works on Wayland too, and closes the rubberbanding part of #10417 / #11944. PR Summary PR Check...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/18599/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18599%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18599%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/18599/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/18599/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/18599/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18599/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18599/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
timhoffmhttps://github.com/timhoffm
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
anntzer:wxrubhttps://github.com/anntzer/matplotlib/tree/wxrub
Conversation 0 https://github.com/matplotlib/matplotlib/pull/18599
Commits 1 https://github.com/matplotlib/matplotlib/pull/18599/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/18599/checks
Files changed https://github.com/matplotlib/matplotlib/pull/18599/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18599/files
Simplify wx rubberband drawing. https://github.com/matplotlib/matplotlib/pull/18599/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/18599/files
7465670 Simplify wx rubberband drawing. anntzer Jul 10, 2020 https://github.com/matplotlib/matplotlib/pull/18599/commits/7465670e6a951fddffe5ff07d47e637d5299825a
Clear filters https://github.com/matplotlib/matplotlib/pull/18599/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18599/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18599/files
lib/matplotlib/backends/backend_wx.pyhttps://github.com/matplotlib/matplotlib/pull/18599/files#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
View file https://github.com/anntzer/matplotlib/blob/7465670e6a951fddffe5ff07d47e637d5299825a/lib/matplotlib/backends/backend_wx.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/18599/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/18599/files#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
https://github.com/matplotlib/matplotlib/pull/18599/files#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
https://github.com/matplotlib/matplotlib/pull/18599/files#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
https://github.com/matplotlib/matplotlib/pull/18599/files#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
https://github.com/matplotlib/matplotlib/pull/18599/files#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
https://github.com/matplotlib/matplotlib/pull/18599/files#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
https://github.com/matplotlib/matplotlib/pull/18599/files#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
https://github.com/matplotlib/matplotlib/pull/18599/files#diff-30d70e32e6418d40a97e2afc459a0a2d55bc4f8905c6420c88ddb22478047523
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.