René's URL Explorer Experiment


Title: Fix stairs() tests by timhoffm · Pull Request #18579 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix stairs() tests by timhoffm · Pull Request #18579 · matplotlib/matplotlib

X Title: Fix stairs() tests by timhoffm · Pull Request #18579 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary CC @andrzejnovak Fixes: check_figures_equal tests did not test anything because fixture figures were not used. Instead the tests created new figures, which were not compared. Limited th...

X Description: PR Summary CC @andrzejnovak Fixes: check_figures_equal tests did not test anything because fixture figures were not used. Instead the tests created new figures, which were not compared. Limited th...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/18579

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:53837e75-7707-3222-09f1-4547159324de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD836:29DE49:1C1E86F:251EC01:6A52D449
html-safe-nonce1c415396bed6509aa80b92900c191d82dd31980bbf8d4aa3b7f3dd20a9a2f641
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODM2OjI5REU0OToxQzFFODZGOjI1MUVDMDE6NkE1MkQ0NDkiLCJ2aXNpdG9yX2lkIjoiNTYyODU2NTM3NjMxNTA4NTg5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9f15d85a98f98b26d6f94c2450757de987b51c3e9df0949cca21a37d119a75af
hovercard-subject-tagpull_request:493383048
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/18579/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/18589e70e3e77c2ad34c6a0026e4fb19b6f2ff2315ccd6dafe22e5c7c53e8641/matplotlib/matplotlib/pull/18579
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/18589e70e3e77c2ad34c6a0026e4fb19b6f2ff2315ccd6dafe22e5c7c53e8641/matplotlib/matplotlib/pull/18579
og:image:altPR Summary CC @andrzejnovak Fixes: check_figures_equal tests did not test anything because fixture figures were not used. Instead the tests created new figures, which were not compared. Limited th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametimhoffm
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/18579#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18579
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18579
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/18579
Reloadhttps://github.com/matplotlib/matplotlib/pull/18579
Reloadhttps://github.com/matplotlib/matplotlib/pull/18579
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18579
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18579
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
dopplershifthttps://github.com/dopplershift
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
timhoffm:fix-stair-testshttps://github.com/timhoffm/matplotlib/tree/fix-stair-tests
Conversationhttps://github.com/matplotlib/matplotlib/pull/18579
Commits3 (3)https://github.com/matplotlib/matplotlib/pull/18579/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/18579/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/18579/files
Fix stairs() testshttps://github.com/matplotlib/matplotlib/pull/18579#top
dopplershifthttps://github.com/dopplershift
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
timhoffm:fix-stair-testshttps://github.com/timhoffm/matplotlib/tree/fix-stair-tests
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Sep 25, 2020https://github.com/matplotlib/matplotlib/pull/18579#issue-709297301
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18579
@andrzejnovakhttps://github.com/andrzejnovak
feat: StepPatch #18275 (review)https://github.com/matplotlib/matplotlib/pull/18275#pullrequestreview-487347047
feat: StepPatch #18275 (comment)https://github.com/matplotlib/matplotlib/pull/18275#issuecomment-692442104
https://user-images.githubusercontent.com/2836374/94317868-7feb0d00-ff87-11ea-9606-9a1f094a1f57.png
https://user-images.githubusercontent.com/2836374/94317935-a8730700-ff87-11ea-9acf-52a6189e897a.png
https://user-images.githubusercontent.com/2836374/94317177-0dc5f880-ff86-11ea-8bc5-b35e2d0488a9.png
https://user-images.githubusercontent.com/2836374/94317212-19b1ba80-ff86-11ea-810f-ea79fc4ef071.png
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18579
https://github.com/timhoffm
Fix stairs() testshttps://github.com/matplotlib/matplotlib/pull/18579/commits/71dc2d64a233b8702ccdb3c1fa75bff22402e846
71dc2d6https://github.com/matplotlib/matplotlib/pull/18579/commits/71dc2d64a233b8702ccdb3c1fa75bff22402e846
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
Sep 25, 2020https://github.com/matplotlib/matplotlib/pull/18579#event-3809469741
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Sep 25, 2020 https://github.com/matplotlib/matplotlib/pull/18579#ref-issue-709335185
Add a check in check_figures_equal that the test did not accidentally plot on non-fixture figures #18581 https://github.com/matplotlib/matplotlib/issues/18581
feat: StepPatch to take array as baseline #18511 https://github.com/matplotlib/matplotlib/pull/18511
Line2D and PathPatch have different defaults for capstyle and joinstyle #18597 https://github.com/matplotlib/matplotlib/issues/18597
https://github.com/timhoffm
Adapt Line2D styles in tests so that it matches the PathPatch stylehttps://github.com/matplotlib/matplotlib/pull/18579/commits/96ebbedc50ddf2c83497909c153342a290b1e988
96ebbedhttps://github.com/matplotlib/matplotlib/pull/18579/commits/96ebbedc50ddf2c83497909c153342a290b1e988
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Sep 27, 2020https://github.com/matplotlib/matplotlib/pull/18579#issuecomment-699696648
#18597https://github.com/matplotlib/matplotlib/issues/18597
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18579
https://github.com/andrzejnovak
andrzejnovakhttps://github.com/andrzejnovak
Sep 27, 2020https://github.com/matplotlib/matplotlib/pull/18579#issuecomment-699697442
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18579
https://github.com/timhoffm
fix test_stairs_updatehttps://github.com/matplotlib/matplotlib/pull/18579/commits/b2fd5ed4b9b1c7710b21bfe7bdadf5eef37b141c
b2fd5edhttps://github.com/matplotlib/matplotlib/pull/18579/commits/b2fd5ed4b9b1c7710b21bfe7bdadf5eef37b141c
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Sep 29, 2020https://github.com/matplotlib/matplotlib/pull/18579#issuecomment-700962268
@andrzejnovakhttps://github.com/andrzejnovak
#18511https://github.com/matplotlib/matplotlib/pull/18511
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18579
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Oct 1, 2020 https://github.com/matplotlib/matplotlib/pull/18579#pullrequestreview-500097181
View reviewed changes https://github.com/matplotlib/matplotlib/pull/18579/files/b2fd5ed4b9b1c7710b21bfe7bdadf5eef37b141c
https://github.com/dopplershift
dopplershifthttps://github.com/dopplershift
Oct 1, 2020 https://github.com/matplotlib/matplotlib/pull/18579#pullrequestreview-500440069
View reviewed changes https://github.com/matplotlib/matplotlib/pull/18579/files/b2fd5ed4b9b1c7710b21bfe7bdadf5eef37b141c
https://github.com/dopplershift
dopplershifthttps://github.com/dopplershift
3c1b27fhttps://github.com/matplotlib/matplotlib/commit/3c1b27fbbf3a0f61f39c6ac6eea26bf54df43111
Oct 1, 2020https://github.com/matplotlib/matplotlib/pull/18579#event-3829973262
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
October 1, 2020 20:48https://github.com/matplotlib/matplotlib/pull/18579#event-3831392374
https://github.com/andrzejnovak
andrzejnovakhttps://github.com/andrzejnovak
Oct 5, 2020 https://github.com/matplotlib/matplotlib/pull/18579#ref-pullrequest-715017834
fix: keep baseline scale to baseline 0 even if set to None #18663 https://github.com/matplotlib/matplotlib/pull/18663
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18579
https://github.com/dopplershift
dopplershift https://github.com/dopplershift
https://github.com/matplotlib/matplotlib/pull/18579/files/b2fd5ed4b9b1c7710b21bfe7bdadf5eef37b141c
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/18579/files/b2fd5ed4b9b1c7710b21bfe7bdadf5eef37b141c
v3.4.0 https://github.com/matplotlib/matplotlib/milestone/53
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18579
https://github.com/timhoffm
https://github.com/andrzejnovak
https://github.com/dopplershift
https://github.com/QuLogic
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.