| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:21568a6d-656f-7d15-e6c5-8434bf1414a5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CE32:E6D1D:BDF4C0:101F864:6A520C23 |
| html-safe-nonce | 37dd3f9008c66d5616e6f36d445c10a274f01328e12bbcb6772584a47b6acdfe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTMyOkU2RDFEOkJERjRDMDoxMDFGODY0OjZBNTIwQzIzIiwidmlzaXRvcl9pZCI6IjMwOTE2NjgzMTY3NDk4NTUwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fcdc73905973f3221899e8472f4d0551c12dcd372d651d4b23cff59dfb6b3a5d |
| hovercard-subject-tag | pull_request:467508161 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/18243/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/76dd96cb81bc78569ad69a35c024ba7dfeebd265dfbc4c41386ec16503306e2b/matplotlib/matplotlib/pull/18243 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/76dd96cb81bc78569ad69a35c024ba7dfeebd265dfbc4c41386ec16503306e2b/matplotlib/matplotlib/pull/18243 |
| og:image:alt | PR Summary
Closes #18234
cbook._reshape_2D was altered to check for iterables in a list, which is great, except categorical strings are iterables. This broke:
import matplotlib.pyplot as plt
fig,... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jklymak |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/18243#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18243 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18243 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/18243 |
| Reload | https://github.com/matplotlib/matplotlib/pull/18243 |
| Reload | https://github.com/matplotlib/matplotlib/pull/18243 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18243 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18243 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| QuLogic | https://github.com/QuLogic |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jklymak:fix-reshape-list-of-strings | https://github.com/jklymak/matplotlib/tree/fix-reshape-list-of-strings |
| Conversation | https://github.com/matplotlib/matplotlib/pull/18243 |
| Commits3 (3) | https://github.com/matplotlib/matplotlib/pull/18243/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/18243/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/18243/files |
| Fix reshape list of strings | https://github.com/matplotlib/matplotlib/pull/18243#top |
| QuLogic | https://github.com/QuLogic |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jklymak:fix-reshape-list-of-strings | https://github.com/jklymak/matplotlib/tree/fix-reshape-list-of-strings |
|
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#issue-678584816 |
| #18234 | https://github.com/matplotlib/matplotlib/issues/18234 |
| https://user-images.githubusercontent.com/1562854/90162461-814ed600-dd49-11ea-9ccd-6c492631afa4.png |
| https://user-images.githubusercontent.com/1562854/90162467-83189980-dd49-11ea-9793-fb254ad21dc6.png |
| Flake 8 | http://flake8.pycqa.org/en/latest/ |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18243 |
| jklymak | https://github.com/jklymak |
| August 13, 2020 09:29 | https://github.com/matplotlib/matplotlib/pull/18243#commits-pushed-91685a1 |
|
| https://github.com/jklymak |
| FIX: list of strings not reshaped properly | https://github.com/matplotlib/matplotlib/pull/18243/commits/91685a18f5d959dc5acb17dafa9e327e3e30331b |
| 91685a1 | https://github.com/matplotlib/matplotlib/pull/18243/commits/91685a18f5d959dc5acb17dafa9e327e3e30331b |
|
| https://github.com/jklymak |
| FIX: list of strings not reshaped properly | https://github.com/matplotlib/matplotlib/pull/18243/commits/90194cacdde15b25bc5db699e91f4a2217bb6c15 |
| 90194ca | https://github.com/matplotlib/matplotlib/pull/18243/commits/90194cacdde15b25bc5db699e91f4a2217bb6c15 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
topic: categorical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20categorical%22 |
|
topic: testing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22 |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#event-3652934360 |
|
| https://github.com/jklymak |
| TST: test categorical | https://github.com/matplotlib/matplotlib/pull/18243/commits/cd42a3f944ac34eb8998100187d83393919b02e2 |
| cd42a3f | https://github.com/matplotlib/matplotlib/pull/18243/commits/cd42a3f944ac34eb8998100187d83393919b02e2 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/e9efb6c047f810bdbb691b08f45ce995e7078924..cd42a3f944ac34eb8998100187d83393919b02e2 |
| e9efb6c | https://github.com/matplotlib/matplotlib/commit/e9efb6c047f810bdbb691b08f45ce995e7078924 |
| cd42a3f | https://github.com/matplotlib/matplotlib/commit/cd42a3f944ac34eb8998100187d83393919b02e2 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/e9efb6c047f810bdbb691b08f45ce995e7078924..cd42a3f944ac34eb8998100187d83393919b02e2 |
| August 13, 2020 16:45 | https://github.com/matplotlib/matplotlib/pull/18243#event-3652938413 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#issuecomment-673586782 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18243 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| v3.3.1 | https://github.com/matplotlib/matplotlib/milestone/56 |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#event-3652941257 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
Release critical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22 |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#event-3652941596 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#issuecomment-673587260 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18243 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Aug 13, 2020
| https://github.com/matplotlib/matplotlib/pull/18243#pullrequestreview-467102802 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/18243/files/cd42a3f944ac34eb8998100187d83393919b02e2 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
|
Aug 13, 2020
| https://github.com/matplotlib/matplotlib/pull/18243#pullrequestreview-467102870 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/18243/files/cd42a3f944ac34eb8998100187d83393919b02e2 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#issuecomment-673692203 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18243 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Aug 13, 2020
| https://github.com/matplotlib/matplotlib/pull/18243#ref-issue-678735393 |
|
test_never_update is flaky
#18246
| https://github.com/matplotlib/matplotlib/issues/18246 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Aug 13, 2020
| https://github.com/matplotlib/matplotlib/pull/18243#pullrequestreview-467135589 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/18243/files/cd42a3f944ac34eb8998100187d83393919b02e2 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Aug 13, 2020
| https://github.com/matplotlib/matplotlib/pull/18243#pullrequestreview-467140469 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/18243/files/cd42a3f944ac34eb8998100187d83393919b02e2 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| 17a0ff7 | https://github.com/matplotlib/matplotlib/commit/17a0ff73282c1d8699abd29670b2d42505393c45 |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#event-3654035130 |
| https://github.com/apps/lumberbot-app |
| lumberbot-app | https://github.com/apps/lumberbot-app |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#issuecomment-673735827 |
| #18243 | https://github.com/matplotlib/matplotlib/pull/18243 |
| suggest an improvement | https://github.com/MeeseeksBox/MeeseeksDev |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18243 |
| https://github.com/apps/lumberbot-app |
| lumberbot-app | https://github.com/apps/lumberbot-app |
|
Still Needs Manual Backport
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22 |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#event-3654037232 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#issuecomment-673736853 |
| #18247 | https://github.com/matplotlib/matplotlib/pull/18247 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18243 |
| QuLogic | https://github.com/QuLogic |
|
Aug 13, 2020
| https://github.com/matplotlib/matplotlib/pull/18243#ref-commit-bcbabb3 |
|
| https://github.com/QuLogic |
| Backport PR | https://github.com/QuLogic/matplotlib/commit/bcbabb36b3ed755956cd5607184e62abd3293eef |
| matplotlib#18243 | https://github.com/matplotlib/matplotlib/pull/18243 |
| : Fix reshape list of strings | https://github.com/QuLogic/matplotlib/commit/bcbabb36b3ed755956cd5607184e62abd3293eef |
| bcbabb3 | https://github.com/QuLogic/matplotlib/commit/bcbabb36b3ed755956cd5607184e62abd3293eef |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Still Needs Manual Backport
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22 |
| Aug 13, 2020 | https://github.com/matplotlib/matplotlib/pull/18243#event-3654054874 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18243 |
|
| https://github.com/tacaswell |
|
tacaswell
| https://github.com/tacaswell |
|
| https://github.com/matplotlib/matplotlib/pull/18243/files/cd42a3f944ac34eb8998100187d83393919b02e2 |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/18243/files/cd42a3f944ac34eb8998100187d83393919b02e2 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/18243/files/cd42a3f944ac34eb8998100187d83393919b02e2 |
|
Release critical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22 |
|
topic: categorical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20categorical%22 |
|
topic: testing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22 |
|
v3.3.1
| https://github.com/matplotlib/matplotlib/milestone/56 |
|
_reshape_2D function behavior changed, breaks hist for some cases in 3.3.0
| https://github.com/matplotlib/matplotlib/issues/18234 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18243 |
|
| https://github.com/jklymak |
|
| https://github.com/tacaswell |
|
| https://github.com/QuLogic |
|
| https://github.com/timhoffm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |