René's URL Explorer Experiment


Title: Go back to checking figures for their manager in destroy. by QuLogic · Pull Request #18184 · matplotlib/matplotlib · GitHub

Open Graph Title: Go back to checking figures for their manager in destroy. by QuLogic · Pull Request #18184 · matplotlib/matplotlib

X Title: Go back to checking figures for their manager in destroy. by QuLogic · Pull Request #18184 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary This is a partial revert of a small part of #13581. Fixes #18163. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant [n/a] New features are documented, with examples i...

X Description: PR Summary This is a partial revert of a small part of #13581. Fixes #18163. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant [n/a] New features are documented, with examples i...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/18184

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8df239d4-c47a-895d-5a5e-e4928e7afca5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2EE:1BADF1:C5A26:109C33:6A526B9E
html-safe-nonce0feefd5098b3bba8d766274c681fd3f3cfebfae591742429ed40c66f87d0df14
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkVFOjFCQURGMTpDNUEyNjoxMDlDMzM6NkE1MjZCOUUiLCJ2aXNpdG9yX2lkIjoiNzkwNDAzMDk0OTQyNzUzODg0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccaa544436efe8a5d4ab36dd52dda69234de398e82428ad9236a147b92873d341
hovercard-subject-tagpull_request:463589041
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/18184/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/78576a9c86f5a6cdd6bc12a8d66882c2315f980b87c43feb3638bfd9a60f2365/matplotlib/matplotlib/pull/18184
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/78576a9c86f5a6cdd6bc12a8d66882c2315f980b87c43feb3638bfd9a60f2365/matplotlib/matplotlib/pull/18184
og:image:altPR Summary This is a partial revert of a small part of #13581. Fixes #18163. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant [n/a] New features are documented, with examples i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameQuLogic
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/18184#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18184
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18184
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/18184
Reloadhttps://github.com/matplotlib/matplotlib/pull/18184
Reloadhttps://github.com/matplotlib/matplotlib/pull/18184
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
QuLogic:revert-canvas-manager-destroyhttps://github.com/QuLogic/matplotlib/tree/revert-canvas-manager-destroy
Conversationhttps://github.com/matplotlib/matplotlib/pull/18184
Commits2 (2)https://github.com/matplotlib/matplotlib/pull/18184/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/18184/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/18184/files
Go back to checking figures for their manager in destroy.https://github.com/matplotlib/matplotlib/pull/18184#top
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
QuLogic:revert-canvas-manager-destroyhttps://github.com/QuLogic/matplotlib/tree/revert-canvas-manager-destroy
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Aug 5, 2020https://github.com/matplotlib/matplotlib/pull/18184#issue-673783642
#13581https://github.com/matplotlib/matplotlib/pull/13581
#18163https://github.com/matplotlib/matplotlib/issues/18163
Flake 8http://flake8.pycqa.org/en/latest/
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v3.3.1https://github.com/matplotlib/matplotlib/milestone/56
Aug 5, 2020https://github.com/matplotlib/matplotlib/pull/18184#event-3626081257
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Aug 5, 2020 https://github.com/matplotlib/matplotlib/pull/18184#pullrequestreview-461954995
View reviewed changes https://github.com/matplotlib/matplotlib/pull/18184/files
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Aug 5, 2020 https://github.com/matplotlib/matplotlib/pull/18184#pullrequestreview-462071234
View reviewed changes https://github.com/matplotlib/matplotlib/pull/18184/files
lib/matplotlib/_pylab_helpers.pyhttps://github.com/matplotlib/matplotlib/pull/18184/files#diff-6fee3de4018308e35f310215012b364f52aebf566b582176dc846399815b9397
timhoffmhttps://github.com/timhoffm
Aug 5, 2020https://github.com/matplotlib/matplotlib/pull/18184#discussion_r466042653
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
QuLogichttps://github.com/QuLogic
Aug 5, 2020https://github.com/matplotlib/matplotlib/pull/18184#discussion_r466059844
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Aug 5, 2020 https://github.com/matplotlib/matplotlib/pull/18184#pullrequestreview-462096777
View reviewed changes https://github.com/matplotlib/matplotlib/pull/18184/files
timhoffmhttps://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/18184#pullrequestreview-462096777
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Aug 5, 2020https://github.com/matplotlib/matplotlib/pull/18184#issuecomment-669603003
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Aug 6, 2020https://github.com/matplotlib/matplotlib/pull/18184#issuecomment-669610967
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
force-pushedhttps://github.com/matplotlib/matplotlib/compare/4d8e0d14290d866ba8db6ec535a9656f0ca8486f..f65eb17105368aa570d102c4b8ebe114c2170b24
4d8e0d1https://github.com/matplotlib/matplotlib/commit/4d8e0d14290d866ba8db6ec535a9656f0ca8486f
f65eb17https://github.com/matplotlib/matplotlib/commit/f65eb17105368aa570d102c4b8ebe114c2170b24
Compare https://github.com/matplotlib/matplotlib/compare/4d8e0d14290d866ba8db6ec535a9656f0ca8486f..f65eb17105368aa570d102c4b8ebe114c2170b24
August 6, 2020 03:47https://github.com/matplotlib/matplotlib/pull/18184#event-3627255548
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Aug 6, 2020https://github.com/matplotlib/matplotlib/pull/18184#issuecomment-669667532
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Aug 10, 2020https://github.com/matplotlib/matplotlib/pull/18184#issuecomment-671575829
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Aug 10, 2020 https://github.com/matplotlib/matplotlib/pull/18184#ref-issue-676400695
Figure out why test_interactive_backend fails on Travis macOS #18213 https://github.com/matplotlib/matplotlib/issues/18213
QuLogichttps://github.com/QuLogic
August 10, 2020 16:37https://github.com/matplotlib/matplotlib/pull/18184#commits-pushed-2ba9f29
https://github.com/QuLogic
Go back to checking figures for their manager in destroy.https://github.com/matplotlib/matplotlib/pull/18184/commits/2ba9f296afb3c2a831e5d1b6bb1293bed293b357
2ba9f29https://github.com/matplotlib/matplotlib/pull/18184/commits/2ba9f296afb3c2a831e5d1b6bb1293bed293b357
matplotlib#13581https://github.com/matplotlib/matplotlib/pull/13581
matplotlib#18163https://github.com/matplotlib/matplotlib/issues/18163
https://github.com/QuLogic
Skip test_interactive_backend on macOS Travis.https://github.com/matplotlib/matplotlib/pull/18184/commits/db6fb4dff060f63b8b10f06cf7bd9e46bc41fc94
db6fb4dhttps://github.com/matplotlib/matplotlib/pull/18184/commits/db6fb4dff060f63b8b10f06cf7bd9e46bc41fc94
matplotlib#18213https://github.com/matplotlib/matplotlib/issues/18213
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
force-pushedhttps://github.com/matplotlib/matplotlib/compare/f65eb17105368aa570d102c4b8ebe114c2170b24..db6fb4dff060f63b8b10f06cf7bd9e46bc41fc94
f65eb17https://github.com/matplotlib/matplotlib/commit/f65eb17105368aa570d102c4b8ebe114c2170b24
db6fb4dhttps://github.com/matplotlib/matplotlib/commit/db6fb4dff060f63b8b10f06cf7bd9e46bc41fc94
Compare https://github.com/matplotlib/matplotlib/compare/f65eb17105368aa570d102c4b8ebe114c2170b24..db6fb4dff060f63b8b10f06cf7bd9e46bc41fc94
August 10, 2020 20:37https://github.com/matplotlib/matplotlib/pull/18184#event-3640399931
https://github.com/jklymak
jklymakhttps://github.com/jklymak
5426474https://github.com/matplotlib/matplotlib/commit/54264746cb607d9084b948a16053e2327a891061
Aug 11, 2020https://github.com/matplotlib/matplotlib/pull/18184#event-3641192780
meeseeksmachinehttps://github.com/meeseeksmachine
Aug 11, 2020 https://github.com/matplotlib/matplotlib/pull/18184#ref-commit-0745b37
https://github.com/jklymak
https://github.com/meeseeksmachine
Backport PRhttps://github.com/meeseeksmachine/matplotlib/commit/0745b37b752c981dbc22e466abf248459b8d2f0a
matplotlib#18184https://github.com/matplotlib/matplotlib/pull/18184
: Go back to checking figures for their m…https://github.com/meeseeksmachine/matplotlib/commit/0745b37b752c981dbc22e466abf248459b8d2f0a
0745b37https://github.com/meeseeksmachine/matplotlib/commit/0745b37b752c981dbc22e466abf248459b8d2f0a
https://github.com/meeseeksmachine
meeseeksmachinehttps://github.com/meeseeksmachine
Aug 11, 2020 https://github.com/matplotlib/matplotlib/pull/18184#ref-pullrequest-676537953
Backport PR #18184 on branch v3.3.x (Go back to checking figures for their manager in destroy.) #18214 https://github.com/matplotlib/matplotlib/pull/18214
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
August 11, 2020 02:56https://github.com/matplotlib/matplotlib/pull/18184#event-3641209227
QuLogichttps://github.com/QuLogic
Aug 11, 2020 https://github.com/matplotlib/matplotlib/pull/18184#ref-commit-d5f1d55
https://github.com/QuLogic
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/d5f1d5547ec95c80fc86ff6f1dca9ccaae00c13e
#18214https://github.com/matplotlib/matplotlib/pull/18214
from meeseeksmachine/auto-backport-of-pr-18…https://github.com/matplotlib/matplotlib/commit/d5f1d5547ec95c80fc86ff6f1dca9ccaae00c13e
d5f1d55https://github.com/matplotlib/matplotlib/commit/d5f1d5547ec95c80fc86ff6f1dca9ccaae00c13e
#18184https://github.com/matplotlib/matplotlib/pull/18184
https://github.com/danielballan
danielballanhttps://github.com/danielballan
Dec 8, 2020 https://github.com/matplotlib/matplotlib/pull/18184#ref-pullrequest-759735794
Fix HeadlessFigure.close_figure. bluesky/bluesky-widgets#74 https://github.com/bluesky/bluesky-widgets/pull/74
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18184
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/18184/files/f65eb17105368aa570d102c4b8ebe114c2170b24
https://github.com/timhoffm
timhoffm https://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/18184/files/f65eb17105368aa570d102c4b8ebe114c2170b24
v3.3.1 https://github.com/matplotlib/matplotlib/milestone/56
Figure cannot be closed if it has associated Agg canvas https://github.com/matplotlib/matplotlib/issues/18163
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18184
https://github.com/QuLogic
https://github.com/tacaswell
https://github.com/timhoffm
https://github.com/jklymak
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.