René's URL Explorer Experiment


Title: Correctly handle 'none' facecolors in do_3d_projection by dstansby · Pull Request #18060 · matplotlib/matplotlib · GitHub

Open Graph Title: Correctly handle 'none' facecolors in do_3d_projection by dstansby · Pull Request #18060 · matplotlib/matplotlib

X Title: Correctly handle 'none' facecolors in do_3d_projection by dstansby · Pull Request #18060 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: Fixes #18020. Changes made in #17543 meant that _facecolor3d can now be an empty array, therefore make sure do_3d_projection only handles the case where the facecolor is set.

X Description: Fixes #18020. Changes made in #17543 meant that _facecolor3d can now be an empty array, therefore make sure do_3d_projection only handles the case where the facecolor is set.

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/18060

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8afa9a83-3e3a-b025-1f31-0493c8610883
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5C0:3AC8D5:EFFBD:14E8E5:6A511094
html-safe-nonce93b61c4ea07233fd1389a1d913748b52dc52c628e724978e5b634826eeb13771
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUMwOjNBQzhENTpFRkZCRDoxNEU4RTU6NkE1MTEwOTQiLCJ2aXNpdG9yX2lkIjoiMzM0ODk4ODUyNzM2Mjc3MzE0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca727eb1878f0f6fddd23c1f9bdd2844f6d3f6bee48f7d99ead818d339d584af0
hovercard-subject-tagpull_request:456617954
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/18060/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b0eaa2995e068c71e890f6e8e583d6c4829859b722170b9b92b7918bf5e75b20/matplotlib/matplotlib/pull/18060
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b0eaa2995e068c71e890f6e8e583d6c4829859b722170b9b92b7918bf5e75b20/matplotlib/matplotlib/pull/18060
og:image:altFixes #18020. Changes made in #17543 meant that _facecolor3d can now be an empty array, therefore make sure do_3d_projection only handles the case where the facecolor is set.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedstansby
hostnamegithub.com
expected-hostnamegithub.com
Noneb076e100febaa00374cd89239f915d00dd3187f7c68b12bc2b7688181305344d
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef9137f6d981cbbfd780af369f80ce890b2d0d2d4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/18060#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18060
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18060
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/18060
Reloadhttps://github.com/matplotlib/matplotlib/pull/18060
Reloadhttps://github.com/matplotlib/matplotlib/pull/18060
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
dstansbyhttps://github.com/dstansby
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
dstansby:rgba-fixhttps://github.com/dstansby/matplotlib/tree/rgba-fix
Conversationhttps://github.com/matplotlib/matplotlib/pull/18060
Commits1 (1)https://github.com/matplotlib/matplotlib/pull/18060/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/18060/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/18060/files
Correctly handle 'none' facecolors in do_3d_projectionhttps://github.com/matplotlib/matplotlib/pull/18060#top
dstansbyhttps://github.com/dstansby
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
dstansby:rgba-fixhttps://github.com/dstansby/matplotlib/tree/rgba-fix
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Jul 25, 2020https://github.com/matplotlib/matplotlib/pull/18060#issue-665589026
#18020https://github.com/matplotlib/matplotlib/issues/18020
#17543https://github.com/matplotlib/matplotlib/pull/17543
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
https://github.com/dstansby
Only handle len > 0 facecolors in do_3d_projectionhttps://github.com/matplotlib/matplotlib/pull/18060/commits/4d60247274e0d58ae14eb580594f2a01004fd57c
4d60247https://github.com/matplotlib/matplotlib/pull/18060/commits/4d60247274e0d58ae14eb580594f2a01004fd57c
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
topic: mplot3d https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20mplot3d%22
Jul 25, 2020https://github.com/matplotlib/matplotlib/pull/18060#event-3586288291
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Jul 25, 2020https://github.com/matplotlib/matplotlib/pull/18060#event-3586292865
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Release critical https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22
Jul 25, 2020https://github.com/matplotlib/matplotlib/pull/18060#event-3586325355
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
v3.3.1https://github.com/matplotlib/matplotlib/milestone/56
Jul 25, 2020https://github.com/matplotlib/matplotlib/pull/18060#event-3586325446
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Jul 25, 2020 https://github.com/matplotlib/matplotlib/pull/18060#pullrequestreview-455312328
View reviewed changes https://github.com/matplotlib/matplotlib/pull/18060/files/4d60247274e0d58ae14eb580594f2a01004fd57c
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jul 28, 2020https://github.com/matplotlib/matplotlib/pull/18060#issuecomment-664730926
#17861https://github.com/matplotlib/matplotlib/pull/17861
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jul 28, 2020https://github.com/matplotlib/matplotlib/pull/18060#issuecomment-664731168
#17850https://github.com/matplotlib/matplotlib/pull/17850
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
v3.3.1https://github.com/matplotlib/matplotlib/milestone/56
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
Jul 30, 2020https://github.com/matplotlib/matplotlib/pull/18060#event-3604087839
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Release critical https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22
Jul 30, 2020https://github.com/matplotlib/matplotlib/pull/18060#event-3604087994
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Jul 30, 2020https://github.com/matplotlib/matplotlib/pull/18060#issuecomment-666393255
MNT: set the facecolor of nofill markers #17850https://github.com/matplotlib/matplotlib/pull/17850
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
https://github.com/jklymak
jklymakhttps://github.com/jklymak
status: needs rebase https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20rebase%22
Aug 24, 2020https://github.com/matplotlib/matplotlib/pull/18060#event-3685954116
https://github.com/jklymak
jklymakhttps://github.com/jklymak
August 24, 2020 15:18https://github.com/matplotlib/matplotlib/pull/18060#event-3685954441
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
status: waiting for other PR https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20waiting%20for%20other%20PR%22
Aug 25, 2020https://github.com/matplotlib/matplotlib/pull/18060#event-3690030151
https://github.com/jklymak
jklymakhttps://github.com/jklymak
v3.4.0https://github.com/matplotlib/matplotlib/milestone/53
v3.4.1https://github.com/matplotlib/matplotlib/milestone/61
Jan 27, 2021https://github.com/matplotlib/matplotlib/pull/18060#event-4257972805
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Feb 19, 2021https://github.com/matplotlib/matplotlib/pull/18060#issuecomment-781746760
#17850https://github.com/matplotlib/matplotlib/pull/17850
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
status: needs revision https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20revision%22
Feb 19, 2021https://github.com/matplotlib/matplotlib/pull/18060#event-4349738841
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v3.4.1https://github.com/matplotlib/matplotlib/milestone/61
v3.4.2https://github.com/matplotlib/matplotlib/milestone/63
Mar 30, 2021https://github.com/matplotlib/matplotlib/pull/18060#event-4524519622
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Apr 4, 2021https://github.com/matplotlib/matplotlib/pull/18060#issuecomment-813011315
#18020https://github.com/matplotlib/matplotlib/issues/18020
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Apr 4, 2021https://github.com/matplotlib/matplotlib/pull/18060#event-4548974090
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Apr 6, 2021https://github.com/matplotlib/matplotlib/pull/18060#issuecomment-814451093
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18060
https://github.com/timhoffm
timhoffm https://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/18060/files/4d60247274e0d58ae14eb580594f2a01004fd57c
status: needs rebase https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20rebase%22
status: needs revision https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20revision%22
status: waiting for other PR https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20waiting%20for%20other%20PR%22
topic: mplot3d https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20mplot3d%22
v3.4.2 https://github.com/matplotlib/matplotlib/milestone/63
Scatter3D: facecolor or color to "none" leads to an error https://github.com/matplotlib/matplotlib/issues/18020
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/18060
https://github.com/dstansby
https://github.com/tacaswell
https://github.com/QuLogic
https://github.com/timhoffm
https://github.com/jklymak
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.