| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cf5d0e70-1057-fa8e-28ba-edde945092d2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E1F0:A21B7:526D23:6E82FD:6A5235C8 |
| html-safe-nonce | 844a9a35277764c027a004afb7138cb99d176f171bc38259f41660f5657f5959 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUYwOkEyMUI3OjUyNkQyMzo2RTgyRkQ6NkE1MjM1QzgiLCJ2aXNpdG9yX2lkIjoiNDUwMjY2MDUyNTk2NTA2MzYyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d0dd3cfe68a46c4baffc90761f726945693dc1cf8247d05f4965457b17ecb5a6 |
| hovercard-subject-tag | pull_request:455258781 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/18021/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/86bd56dfc7a264e4916f20484923c15b23d210075ff937a5d650c3fc6ef66501/matplotlib/matplotlib/pull/18021 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/86bd56dfc7a264e4916f20484923c15b23d210075ff937a5d650c3fc6ef66501/matplotlib/matplotlib/pull/18021 |
| og:image:alt | PR Summary
I guess if epoch2num should be follow matplotlib epoch, then julian2num should as well...
Follow up to #17983
PR Checklist
Has Pytest style unit tests
Code is Flake 8 compliant
New f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jklymak |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/18021#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18021 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18021 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/18021 |
| Reload | https://github.com/matplotlib/matplotlib/pull/18021 |
| Reload | https://github.com/matplotlib/matplotlib/pull/18021 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| QuLogic | https://github.com/QuLogic |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jklymak:fix-update-num2julian | https://github.com/jklymak/matplotlib/tree/fix-update-num2julian |
| Conversation | https://github.com/matplotlib/matplotlib/pull/18021 |
| Commits1 (1) | https://github.com/matplotlib/matplotlib/pull/18021/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/18021/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/18021/files |
| FIX: update num2julian and julian2num | https://github.com/matplotlib/matplotlib/pull/18021#top |
| QuLogic | https://github.com/QuLogic |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jklymak:fix-update-num2julian | https://github.com/jklymak/matplotlib/tree/fix-update-num2julian |
|
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Jul 22, 2020 | https://github.com/matplotlib/matplotlib/pull/18021#issue-663932785 |
| #17983 | https://github.com/matplotlib/matplotlib/pull/17983 |
| Flake 8 | http://flake8.pycqa.org/en/latest/ |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
topic: date handling
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20date%20handling%22 |
| Jul 22, 2020 | https://github.com/matplotlib/matplotlib/pull/18021#event-3576845019 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| v3.3.1 | https://github.com/matplotlib/matplotlib/milestone/56 |
| Jul 22, 2020 | https://github.com/matplotlib/matplotlib/pull/18021#event-3576845230 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/9611ec8cdaf8560df0d00f61fe9c79cdbd3cd66b..cec46b53c45d970d3b55757a2c26a0bad04792d4 |
| 9611ec8 | https://github.com/matplotlib/matplotlib/commit/9611ec8cdaf8560df0d00f61fe9c79cdbd3cd66b |
| cec46b5 | https://github.com/matplotlib/matplotlib/commit/cec46b53c45d970d3b55757a2c26a0bad04792d4 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/9611ec8cdaf8560df0d00f61fe9c79cdbd3cd66b..cec46b53c45d970d3b55757a2c26a0bad04792d4 |
| July 22, 2020 23:19 | https://github.com/matplotlib/matplotlib/pull/18021#event-3577897487 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Jul 23, 2020 | https://github.com/matplotlib/matplotlib/pull/18021#issuecomment-662760961 |
| https://41969-1385122-gh.circle-artifacts.com/0/doc/build/html/api/next_api_changes/deprecations/17983-JMK.html#functions-epoch2num-and-julian2num-use-rcparams-date-epoch-default-1970-01-01t00-00-00 | https://41969-1385122-gh.circle-artifacts.com/0/doc/build/html/api/next_api_changes/deprecations/17983-JMK.html#functions-epoch2num-and-julian2num-use-rcparams-date-epoch-default-1970-01-01t00-00-00 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Jul 23, 2020
| https://github.com/matplotlib/matplotlib/pull/18021#pullrequestreview-454484555 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/18021/files |
| setup.cfg.template | https://github.com/matplotlib/matplotlib/pull/18021/files#diff-3fea3c9278f0604dd9147ebb424348ca51bb5918b284066bdbc0741350a4cc0c |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
| lib/matplotlib/dates.py | https://github.com/matplotlib/matplotlib/pull/18021/files#diff-31219318ec1480e3b32a4dc999aeb48c78f14cc19a24b2c709c00ae1cbd508b2 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
| lib/matplotlib/dates.py | https://github.com/matplotlib/matplotlib/pull/18021/files#diff-31219318ec1480e3b32a4dc999aeb48c78f14cc19a24b2c709c00ae1cbd508b2 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/aa871f8407d850b02aa9c42e5f1cd543e3b16e70..97d1685a4f61164a7e983f62ebe4d7c235368b70 |
| aa871f8 | https://github.com/matplotlib/matplotlib/commit/aa871f8407d850b02aa9c42e5f1cd543e3b16e70 |
| 97d1685 | https://github.com/matplotlib/matplotlib/commit/97d1685a4f61164a7e983f62ebe4d7c235368b70 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/aa871f8407d850b02aa9c42e5f1cd543e3b16e70..97d1685a4f61164a7e983f62ebe4d7c235368b70 |
| July 23, 2020 21:16 | https://github.com/matplotlib/matplotlib/pull/18021#event-3581758049 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Jul 24, 2020
| https://github.com/matplotlib/matplotlib/pull/18021#pullrequestreview-454623532 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/18021/files |
| QuLogic | https://github.com/QuLogic |
| https://github.com/matplotlib/matplotlib/pull/18021#pullrequestreview-454623532 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
| doc/api/next_api_changes/deprecations/17983-JMK.rst | https://github.com/matplotlib/matplotlib/pull/18021/files#diff-43746c94605053dd587ec3d421e5fe86d4d0471ea0d65629d9bc57d68cf2b439 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
| lib/matplotlib/dates.py | https://github.com/matplotlib/matplotlib/pull/18021/files#diff-31219318ec1480e3b32a4dc999aeb48c78f14cc19a24b2c709c00ae1cbd508b2 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Jul 24, 2020
| https://github.com/matplotlib/matplotlib/pull/18021#pullrequestreview-454897472 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/18021/files |
| timhoffm | https://github.com/timhoffm |
| https://github.com/matplotlib/matplotlib/pull/18021#pullrequestreview-454897472 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
|
| https://github.com/jklymak |
|
| https://github.com/QuLogic |
| FIX: update num2julian and julian2num | https://github.com/matplotlib/matplotlib/pull/18021/commits/4757d983b8f9739d4eef84e2d6ef6b4bddbd6121 |
| 4757d98 | https://github.com/matplotlib/matplotlib/pull/18021/commits/4757d983b8f9739d4eef84e2d6ef6b4bddbd6121 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/9c20006a654689c2a226e4c0db57ebe48df89587..4757d983b8f9739d4eef84e2d6ef6b4bddbd6121 |
| 9c20006 | https://github.com/matplotlib/matplotlib/commit/9c20006a654689c2a226e4c0db57ebe48df89587 |
| 4757d98 | https://github.com/matplotlib/matplotlib/commit/4757d983b8f9739d4eef84e2d6ef6b4bddbd6121 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/9c20006a654689c2a226e4c0db57ebe48df89587..4757d983b8f9739d4eef84e2d6ef6b4bddbd6121 |
| July 24, 2020 14:20 | https://github.com/matplotlib/matplotlib/pull/18021#event-3584147320 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Jul 24, 2020
| https://github.com/matplotlib/matplotlib/pull/18021#pullrequestreview-455167005 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/18021/files/4757d983b8f9739d4eef84e2d6ef6b4bddbd6121 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| 4b179b9 | https://github.com/matplotlib/matplotlib/commit/4b179b92c0fa100a2ebea3a80aadf4fc59b8d14d |
| Jul 24, 2020 | https://github.com/matplotlib/matplotlib/pull/18021#event-3585375433 |
| https://github.com/apps/lumberbot-app |
| lumberbot-app | https://github.com/apps/lumberbot-app |
| Jul 24, 2020 | https://github.com/matplotlib/matplotlib/pull/18021#issuecomment-663721174 |
| #18021 | https://github.com/matplotlib/matplotlib/pull/18021 |
| suggest an improvement | https://github.com/MeeseeksBox/MeeseeksDev |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
| https://github.com/apps/lumberbot-app |
| lumberbot-app | https://github.com/apps/lumberbot-app |
|
Still Needs Manual Backport
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22 |
| Jul 24, 2020 | https://github.com/matplotlib/matplotlib/pull/18021#event-3585377944 |
| jklymak | https://github.com/jklymak |
|
Jul 24, 2020
| https://github.com/matplotlib/matplotlib/pull/18021#ref-commit-f4606b1 |
|
| https://github.com/QuLogic |
|
| https://github.com/jklymak |
| Backport PR | https://github.com/jklymak/matplotlib/commit/f4606b19e9ba5d85755ed0e2cba8f1620b48bfe8 |
| matplotlib#18021 | https://github.com/matplotlib/matplotlib/pull/18021 |
| : FIX: update num2julian and julian2num | https://github.com/jklymak/matplotlib/commit/f4606b19e9ba5d85755ed0e2cba8f1620b48bfe8 |
| f4606b1 | https://github.com/jklymak/matplotlib/commit/f4606b19e9ba5d85755ed0e2cba8f1620b48bfe8 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
Still Needs Manual Backport
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22 |
| Jul 24, 2020 | https://github.com/matplotlib/matplotlib/pull/18021#event-3585542328 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| July 24, 2020 21:34 | https://github.com/matplotlib/matplotlib/pull/18021#event-3585542510 |
| QuLogic | https://github.com/QuLogic |
|
Jul 24, 2020
| https://github.com/matplotlib/matplotlib/pull/18021#ref-commit-daf999e |
|
| https://github.com/QuLogic |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/daf999e4b841c4d061de0b6b19f4f0853407a4e8 |
| #18053 | https://github.com/matplotlib/matplotlib/pull/18053 |
| from jklymak/auto-backport-of-pr-18021-on-v… | https://github.com/matplotlib/matplotlib/commit/daf999e4b841c4d061de0b6b19f4f0853407a4e8 |
| daf999e | https://github.com/matplotlib/matplotlib/commit/daf999e4b841c4d061de0b6b19f4f0853407a4e8 |
| #18021 | https://github.com/matplotlib/matplotlib/pull/18021 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F18021 |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/18021/files/4757d983b8f9739d4eef84e2d6ef6b4bddbd6121 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/18021/files/9c20006a654689c2a226e4c0db57ebe48df89587 |
|
topic: date handling
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20date%20handling%22 |
|
v3.3.1
| https://github.com/matplotlib/matplotlib/milestone/56 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/18021 |
|
| https://github.com/jklymak |
|
| https://github.com/QuLogic |
|
| https://github.com/timhoffm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |