Title: ENH: Add version check for mac sdk version by dopplershift · Pull Request #17956 · matplotlib/matplotlib · GitHub
Open Graph Title: ENH: Add version check for mac sdk version by dopplershift · Pull Request #17956 · matplotlib/matplotlib
X Title: ENH: Add version check for mac sdk version by dopplershift · Pull Request #17956 · matplotlib/matplotlib
Description: PR Summary This specifically lists the macOS SDK version (currently 10.11) needed to build the osx backend. It also turns on compiler warnings for when code uses features newer than the minimum version (and makes warnings errors for this file). This should hopefully help CI catch when we start using API's past our minimum desired version. It's currently set to 10.9 specifically to see it now fail. Questions: Where in the docs should we document that we only support macOS >= 10.11? By having the compiler flag set the version, we override anywhere else right now using e.g. MACOS_DEPLOYMENT_TARGET. The problem right now is that most places (default Python builds, etc.) are using 10.9, so this has to be set somewhere for things to build properly out of the box. PR Checklist Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way
Open Graph Description: PR Summary This specifically lists the macOS SDK version (currently 10.11) needed to build the osx backend. It also turns on compiler warnings for when code uses features newer than the minimum ver...
X Description: PR Summary This specifically lists the macOS SDK version (currently 10.11) needed to build the osx backend. It also turns on compiler warnings for when code uses features newer than the minimum ver...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/17956
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5844bf3c-d0e3-e209-1e3d-f92b8f59bd37 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF4E:3A8C96:1CF4C78:2A0B648:6A57954D |
| html-safe-nonce | 9db432b930fa49fa7a92dd27e6c56839a506b68346ac2ca621f3d4d00ed54bc0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjRFOjNBOEM5NjoxQ0Y0Qzc4OjJBMEI2NDg6NkE1Nzk1NEQiLCJ2aXNpdG9yX2lkIjoiNDE4MzI5ODE2NDE0NTI0NzQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9e828cf33bb83346dd27f2107c649a09456a214849e0819acd0b13f64984e314 |
| hovercard-subject-tag | pull_request:451547545 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/17956/files |
| twitter:image | https://avatars.githubusercontent.com/u/221526?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/221526?s=400&v=4 |
| og:image:alt | PR Summary This specifically lists the macOS SDK version (currently 10.11) needed to build the osx backend. It also turns on compiler warnings for when code uses features newer than the minimum ver... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | a87fc68e9bdf22e1c7e48ac6a60b98882f4bb103314b3f26b3460c61fc5441ae |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a2198d0212ed703af207673eb4d0868d4f867a5b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width