| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c40e13ee-212f-b7ff-3d58-ab43adea06c9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D8CC:E6E6A:64EBD:867CA:6A52B2C6 |
| html-safe-nonce | 6890a5f50a8dbfeff8106bf759bb390ab01f047a25b8ffbf25691ed237c7ad06 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOENDOkU2RTZBOjY0RUJEOjg2N0NBOjZBNTJCMkM2IiwidmlzaXRvcl9pZCI6IjMyNjE0MDMzNTE0NDc2MjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f4b4bcad8a6a36bfe424c23e8bd5390c548f0b66d3a7eee8a4e09dc3c10ff5e1 |
| hovercard-subject-tag | pull_request:449172059 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/17926/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d998c86873905b63c3149e247054ef34c2c5b23df9bed6ec6ce8e5e75b75aaee/matplotlib/matplotlib/pull/17926 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d998c86873905b63c3149e247054ef34c2c5b23df9bed6ec6ce8e5e75b75aaee/matplotlib/matplotlib/pull/17926 |
| og:image:alt | PR Summary
I noticed while going over the hatch doc PRs that we don't really validate this. This magically works because we just check for the count of the various hatch characters. Since it us... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | QuLogic |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/17926#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17926 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17926 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/17926 |
| Reload | https://github.com/matplotlib/matplotlib/pull/17926 |
| Reload | https://github.com/matplotlib/matplotlib/pull/17926 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| dstansby | https://github.com/dstansby |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| QuLogic:warn-hatch | https://github.com/QuLogic/matplotlib/tree/warn-hatch |
| Conversation | https://github.com/matplotlib/matplotlib/pull/17926 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/17926/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/17926/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/17926/files |
| Deprecate hatch patterns with invalid values | https://github.com/matplotlib/matplotlib/pull/17926#top |
| dstansby | https://github.com/dstansby |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| QuLogic:warn-hatch | https://github.com/QuLogic/matplotlib/tree/warn-hatch |
|
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Jul 15, 2020 | https://github.com/matplotlib/matplotlib/pull/17926#issue-656969467 |
| Flake 8 | http://flake8.pycqa.org/en/latest/ |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| v3.4.0 | https://github.com/matplotlib/matplotlib/milestone/53 |
| Jul 15, 2020 | https://github.com/matplotlib/matplotlib/pull/17926#event-3546353563 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
API: argument checking
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22API%3A%20argument%20checking%22 |
| Jul 15, 2020 | https://github.com/matplotlib/matplotlib/pull/17926#event-3546364037 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Jul 15, 2020
| https://github.com/matplotlib/matplotlib/pull/17926#pullrequestreview-448548395 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/17926/files |
| lib/matplotlib/hatch.py | https://github.com/matplotlib/matplotlib/pull/17926/files#diff-9fa22d18bda986f54317196aa0414a09252e8421779c006ed9ac51bf229ed1e9 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
| lib/matplotlib/hatch.py | https://github.com/matplotlib/matplotlib/pull/17926/files#diff-9fa22d18bda986f54317196aa0414a09252e8421779c006ed9ac51bf229ed1e9 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/9e10c6e471e68070e24af3f6855e4d51c24565e8..9bbc045cc1464ee6cefd9976e83a2adfc7cd352d |
| 9e10c6e | https://github.com/matplotlib/matplotlib/commit/9e10c6e471e68070e24af3f6855e4d51c24565e8 |
| 9bbc045 | https://github.com/matplotlib/matplotlib/commit/9bbc045cc1464ee6cefd9976e83a2adfc7cd352d |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/9e10c6e471e68070e24af3f6855e4d51c24565e8..9bbc045cc1464ee6cefd9976e83a2adfc7cd352d |
| July 15, 2020 05:49 | https://github.com/matplotlib/matplotlib/pull/17926#event-3546960916 |
| https://github.com/dstansby |
| dstansby | https://github.com/dstansby |
|
Jul 15, 2020
| https://github.com/matplotlib/matplotlib/pull/17926#pullrequestreview-448879937 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/17926/files |
| dstansby | https://github.com/dstansby |
| https://github.com/matplotlib/matplotlib/pull/17926#pullrequestreview-448879937 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
| lib/matplotlib/hatch.py | https://github.com/matplotlib/matplotlib/pull/17926/files#diff-9fa22d18bda986f54317196aa0414a09252e8421779c006ed9ac51bf229ed1e9 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
| lib/matplotlib/hatch.py | https://github.com/matplotlib/matplotlib/pull/17926/files#diff-9fa22d18bda986f54317196aa0414a09252e8421779c006ed9ac51bf229ed1e9 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Jul 15, 2020
| https://github.com/matplotlib/matplotlib/pull/17926#pullrequestreview-449383047 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/17926/files |
| QuLogic | https://github.com/QuLogic |
| July 16, 2020 19:39 | https://github.com/matplotlib/matplotlib/pull/17926#commits-pushed-a413e43 |
|
| https://github.com/QuLogic |
| Deprecate hatch patterns with invalid values. | https://github.com/matplotlib/matplotlib/pull/17926/commits/a413e432a29d552933b730874ed35e7ee1a1cd04 |
| a413e43 | https://github.com/matplotlib/matplotlib/pull/17926/commits/a413e432a29d552933b730874ed35e7ee1a1cd04 |
|
| https://github.com/QuLogic |
| DOC: Use hatch style reference in Collection docstring. | https://github.com/matplotlib/matplotlib/pull/17926/commits/4da5274c3ff3760c1a429c1f9e428e3b0a0241f0 |
| 4da5274 | https://github.com/matplotlib/matplotlib/pull/17926/commits/4da5274c3ff3760c1a429c1f9e428e3b0a0241f0 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/9bbc045cc1464ee6cefd9976e83a2adfc7cd352d..4da5274c3ff3760c1a429c1f9e428e3b0a0241f0 |
| 9bbc045 | https://github.com/matplotlib/matplotlib/commit/9bbc045cc1464ee6cefd9976e83a2adfc7cd352d |
| 4da5274 | https://github.com/matplotlib/matplotlib/commit/4da5274c3ff3760c1a429c1f9e428e3b0a0241f0 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/9bbc045cc1464ee6cefd9976e83a2adfc7cd352d..4da5274c3ff3760c1a429c1f9e428e3b0a0241f0 |
| July 16, 2020 23:39 | https://github.com/matplotlib/matplotlib/pull/17926#event-3555596969 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Jul 16, 2020 | https://github.com/matplotlib/matplotlib/pull/17926#issuecomment-659736669 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
| https://github.com/dstansby |
| dstansby | https://github.com/dstansby |
|
Jul 17, 2020
| https://github.com/matplotlib/matplotlib/pull/17926#pullrequestreview-450487808 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/17926/files/4da5274c3ff3760c1a429c1f9e428e3b0a0241f0 |
| https://github.com/dstansby |
| dstansby | https://github.com/dstansby |
| e5454a3 | https://github.com/matplotlib/matplotlib/commit/e5454a3fa79753a23337e53721ec4e6b1f9c17f6 |
| Jul 17, 2020 | https://github.com/matplotlib/matplotlib/pull/17926#event-3557109164 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| July 17, 2020 09:07 | https://github.com/matplotlib/matplotlib/pull/17926#event-3557165903 |
| https://github.com/mtb-za |
| mtb-za | https://github.com/mtb-za |
|
Jul 20, 2021
| https://github.com/matplotlib/matplotlib/pull/17926#ref-issue-948485932 |
|
Define additional/custom hatches
#20690
| https://github.com/matplotlib/matplotlib/issues/20690 |
| https://github.com/story645 |
| story645 | https://github.com/story645 |
|
Dec 21, 2022
| https://github.com/matplotlib/matplotlib/pull/17926#ref-issue-1505748149 |
|
[MNT]: de-duplicate hatch validation
#24797
| https://github.com/matplotlib/matplotlib/issues/24797 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17926 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/17926/files/9bbc045cc1464ee6cefd9976e83a2adfc7cd352d |
|
| https://github.com/dstansby |
|
dstansby
| https://github.com/dstansby |
|
| https://github.com/matplotlib/matplotlib/pull/17926/files/4da5274c3ff3760c1a429c1f9e428e3b0a0241f0 |
|
API: argument checking
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22API%3A%20argument%20checking%22 |
|
v3.4.0
| https://github.com/matplotlib/matplotlib/milestone/53 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17926 |
|
| https://github.com/QuLogic |
|
| https://github.com/timhoffm |
|
| https://github.com/dstansby |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |