René's URL Explorer Experiment


Title: BF: ignore CLOSEPOLY after NaN in PathNanRemover by brunobeltran · Pull Request #17885 · matplotlib/matplotlib · GitHub

Open Graph Title: BF: ignore CLOSEPOLY after NaN in PathNanRemover by brunobeltran · Pull Request #17885 · matplotlib/matplotlib

X Title: BF: ignore CLOSEPOLY after NaN in PathNanRemover by brunobeltran · Pull Request #17885 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary Fixes #17868. In short, the current PathNanRemover always keeps CLOSEPOLY "vertices" around, even if they contain NaN. This is arguably okay (since it is documented in comment...

X Description: PR Summary Fixes #17868. In short, the current PathNanRemover always keeps CLOSEPOLY "vertices" around, even if they contain NaN. This is arguably okay (since it is documented in...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/17885

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6519cd7f-7512-c72f-7255-8c7462fd926d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id86E6:17A3BE:4FF68C:6F1EA9:6A51200F
html-safe-nonce2eaa7bd6010ca38386312111bba40dc1ea3003bd90b3e2bcfb6c2756a74bff34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkU2OjE3QTNCRTo0RkY2OEM6NkYxRUE5OjZBNTEyMDBGIiwidmlzaXRvcl9pZCI6Ijc4Mzk3Njc0ODQwODExODQ3ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac05be617a486850ebcfa51b0bb2d74ffae88ddc68eea83b56a0042c2747ac1a40
hovercard-subject-tagpull_request:447703853
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/17885/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e9d1c28724af7e05efc30265e65eabe8d2131dbf62972437624689e05cda5612/matplotlib/matplotlib/pull/17885
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e9d1c28724af7e05efc30265e65eabe8d2131dbf62972437624689e05cda5612/matplotlib/matplotlib/pull/17885
og:image:altPR Summary Fixes #17868. In short, the current PathNanRemover always keeps CLOSEPOLY "vertices" around, even if they contain NaN. This is arguably okay (since it is documented in comment...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrunobeltran
hostnamegithub.com
expected-hostnamegithub.com
None689b683944b0d7f015d0e776452c970832fa81b82dc15284469b556ecced715b
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release942b51ed3bd5feee3d5e2719f890a5fe286edbbb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/17885#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17885
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17885
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/17885
Reloadhttps://github.com/matplotlib/matplotlib/pull/17885
Reloadhttps://github.com/matplotlib/matplotlib/pull/17885
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
brunobeltran:ignore_closepoly_after_nanhttps://github.com/brunobeltran/matplotlib/tree/ignore_closepoly_after_nan
Conversationhttps://github.com/matplotlib/matplotlib/pull/17885
Commits2 (2)https://github.com/matplotlib/matplotlib/pull/17885/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/17885/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/17885/files
BF: ignore CLOSEPOLY after NaN in PathNanRemoverhttps://github.com/matplotlib/matplotlib/pull/17885#top
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
brunobeltran:ignore_closepoly_after_nanhttps://github.com/brunobeltran/matplotlib/tree/ignore_closepoly_after_nan
https://github.com/brunobeltran
brunobeltranhttps://github.com/brunobeltran
Jul 11, 2020https://github.com/matplotlib/matplotlib/pull/17885#issue-655112834
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
#17868https://github.com/matplotlib/matplotlib/issues/17868
Flake 8http://flake8.pycqa.org/en/latest/
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
https://github.com/brunobeltran
brunobeltranhttps://github.com/brunobeltran
topic: path handling https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20path%20handling%22
Release critical https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22
Jul 11, 2020https://github.com/matplotlib/matplotlib/pull/17885#event-3535881736
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Jul 11, 2020https://github.com/matplotlib/matplotlib/pull/17885#issuecomment-657011705
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
v3.3.0https://github.com/matplotlib/matplotlib/milestone/48
Jul 11, 2020https://github.com/matplotlib/matplotlib/pull/17885#event-3536460312
https://github.com/brunobeltran
brunobeltranhttps://github.com/brunobeltran
Jul 13, 2020https://github.com/matplotlib/matplotlib/pull/17885#issuecomment-657658380
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
https://github.com/brunobeltran
brunobeltranhttps://github.com/brunobeltran
Jul 13, 2020https://github.com/matplotlib/matplotlib/pull/17885#issuecomment-657665547
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jul 13, 2020 https://github.com/matplotlib/matplotlib/pull/17885#pullrequestreview-447538846
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17885/files
https://github.com/brunobeltran
brunobeltranhttps://github.com/brunobeltran
Jul 13, 2020https://github.com/matplotlib/matplotlib/pull/17885#issuecomment-657756703
#17868https://github.com/matplotlib/matplotlib/issues/17868
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Jul 14, 2020 https://github.com/matplotlib/matplotlib/pull/17885#pullrequestreview-447752514
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17885/files
lib/matplotlib/tests/test_path.pyhttps://github.com/matplotlib/matplotlib/pull/17885/files#diff-e446ca1d11a78abed51db186fcc91bacaae90e4746f46ace9ba3cc1e642ec227
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
src/path_converters.hhttps://github.com/matplotlib/matplotlib/pull/17885/files#diff-36d69dfa667beb67da44e7bc61c9e0ca35deea173c1cb43e77637c7cbcb4a939
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
https://github.com/brunobeltran
BF: ignore CLOSEPOLY after NaN in PathNanRemoverhttps://github.com/matplotlib/matplotlib/pull/17885/commits/11d00b5c246af45d52a949e52de9135b7b0e3909
11d00b5https://github.com/matplotlib/matplotlib/pull/17885/commits/11d00b5c246af45d52a949e52de9135b7b0e3909
https://github.com/brunobeltran
brunobeltranhttps://github.com/brunobeltran
force-pushedhttps://github.com/matplotlib/matplotlib/compare/e90850f0e2cc22d439bc173ed348f1183bbacc20..b95ce022a8eb9150ec1b4baee26fe176537cc215
e90850fhttps://github.com/matplotlib/matplotlib/commit/e90850f0e2cc22d439bc173ed348f1183bbacc20
b95ce02https://github.com/matplotlib/matplotlib/commit/b95ce022a8eb9150ec1b4baee26fe176537cc215
Compare https://github.com/matplotlib/matplotlib/compare/e90850f0e2cc22d439bc173ed348f1183bbacc20..b95ce022a8eb9150ec1b4baee26fe176537cc215
July 15, 2020 18:12https://github.com/matplotlib/matplotlib/pull/17885#event-3549735363
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jul 15, 2020 https://github.com/matplotlib/matplotlib/pull/17885#pullrequestreview-449236879
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17885/files
tacaswellhttps://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/17885#pullrequestreview-449236879
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
https://github.com/brunobeltran
https://github.com/QuLogic
TESTS: ensure removing nan's doesn't break barhttps://github.com/matplotlib/matplotlib/pull/17885/commits/e216e59cb219ac68b78301c23ad1ac6faeae3d43
e216e59https://github.com/matplotlib/matplotlib/pull/17885/commits/e216e59cb219ac68b78301c23ad1ac6faeae3d43
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
force-pushedhttps://github.com/matplotlib/matplotlib/compare/b95ce022a8eb9150ec1b4baee26fe176537cc215..e216e59cb219ac68b78301c23ad1ac6faeae3d43
b95ce02https://github.com/matplotlib/matplotlib/commit/b95ce022a8eb9150ec1b4baee26fe176537cc215
e216e59https://github.com/matplotlib/matplotlib/commit/e216e59cb219ac68b78301c23ad1ac6faeae3d43
Compare https://github.com/matplotlib/matplotlib/compare/b95ce022a8eb9150ec1b4baee26fe176537cc215..e216e59cb219ac68b78301c23ad1ac6faeae3d43
July 15, 2020 20:19https://github.com/matplotlib/matplotlib/pull/17885#event-3550191274
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Jul 15, 2020 https://github.com/matplotlib/matplotlib/pull/17885#pullrequestreview-449300025
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17885/files
QuLogichttps://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/17885#pullrequestreview-449300025
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
b7ba9e4https://github.com/matplotlib/matplotlib/commit/b7ba9e49b07c821bf042f8d69093a616ac8f13c3
Jul 15, 2020https://github.com/matplotlib/matplotlib/pull/17885#event-3550514614
meeseeksmachinehttps://github.com/meeseeksmachine
Jul 15, 2020 https://github.com/matplotlib/matplotlib/pull/17885#ref-commit-563139a
https://github.com/QuLogic
https://github.com/meeseeksmachine
Backport PRhttps://github.com/meeseeksmachine/matplotlib/commit/563139a9aafa377ebd997c36be0c4e678957e2db
matplotlib#17885https://github.com/matplotlib/matplotlib/pull/17885
: BF: ignore CLOSEPOLY after NaN in PathN…https://github.com/meeseeksmachine/matplotlib/commit/563139a9aafa377ebd997c36be0c4e678957e2db
563139ahttps://github.com/meeseeksmachine/matplotlib/commit/563139a9aafa377ebd997c36be0c4e678957e2db
https://github.com/meeseeksmachine
meeseeksmachinehttps://github.com/meeseeksmachine
Jul 15, 2020 https://github.com/matplotlib/matplotlib/pull/17885#ref-pullrequest-657685763
Backport PR #17885 on branch v3.3.x (BF: ignore CLOSEPOLY after NaN in PathNanRemover) #17940 https://github.com/matplotlib/matplotlib/pull/17940
jklymakhttps://github.com/jklymak
Jul 15, 2020 https://github.com/matplotlib/matplotlib/pull/17885#ref-commit-31e5c15
https://github.com/jklymak
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/31e5c1505175b704e63656ee33ad8238a8fe48f6
#17940https://github.com/matplotlib/matplotlib/pull/17940
from meeseeksmachine/auto-backport-of-pr-17…https://github.com/matplotlib/matplotlib/commit/31e5c1505175b704e63656ee33ad8238a8fe48f6
31e5c15https://github.com/matplotlib/matplotlib/commit/31e5c1505175b704e63656ee33ad8238a8fe48f6
#17885https://github.com/matplotlib/matplotlib/pull/17885
https://github.com/brunobeltran
brunobeltranhttps://github.com/brunobeltran
Jul 21, 2020 https://github.com/matplotlib/matplotlib/pull/17885#ref-pullrequest-662284141
BF: for degenerate polygons, add CLOSEPOLY vertex #17982 https://github.com/matplotlib/matplotlib/pull/17982
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17885
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/17885/files/b95ce022a8eb9150ec1b4baee26fe176537cc215
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/17885/files/b95ce022a8eb9150ec1b4baee26fe176537cc215
Release critical https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22
topic: path handling https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20path%20handling%22
v3.3.0 https://github.com/matplotlib/matplotlib/milestone/48
plt.bar with nan input fails rendering in notebook using 3.3.0rc1 https://github.com/matplotlib/matplotlib/issues/17868
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17885
https://github.com/brunobeltran
https://github.com/QuLogic
https://github.com/tacaswell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.